Review Request: Make Quick Open dialog be KDialog instead of QDialog

[Kris Wong]

What's the point of a minimum size? Dialogs can't be sized any smaller than
their layout allows. I've learned the hard way to always avoid using minimum
sizes with Qt.

Kris Wong


> -----Original Message-----
> From: kdevelop-devel-bounces at barney.cs.uni-potsdam.de
> [mailto:kdevelop-devel-bounces at barney.cs.uni-potsdam.de] On
> Behalf Of Matt Rogers
> Sent: Friday, February 27, 2009 1:43 PM
> To: Dmitry Suzdalev; KDevelop; Matt Rogers
> Subject: Re: Review Request: Make Quick Open dialog be
> KDialog instead of QDialog
>
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/174/#review296
> -----------------------------------------------------------
>
> Ship it!
>
>
> looks fine to me. Please don't forget to mark this review
> request as submitted when you commit it.
>
> - Matt
>
>
> On 2009-02-24 08:09:14, Dmitry Suzdalev wrote:
> >
> > -----------------------------------------------------------
> > This is an automatically generated e-mail. To reply, visit:
> > http://reviewboard.kde.org/r/174/
> > -----------------------------------------------------------
> >
> > (Updated 2009-02-24 08:09:14)
> >
> >
> > Review request for KDevelop.
> >
> >
> > Summary
> > -------
> >
> > This patch makes quick open plugin use KDialog instead of
> QDialog for its dialog widget.
> >
> > I made an ui file a simple QWidget and in cpp file just do
> >
> > setupUi(m_dialog->mainWindow())
> >
> > as needed for KDialog.
> >
> > Also I set some sensible minimumSize for dialog (735x490)
> >
> >
> > This addresses bug 181704.
> >     https://bugs.kde.org/show_bug.cgi?id=181704
> >
> >
> > Diffs
> > -----
> >
> >   trunk/KDE/kdevplatform/plugins/quickopen/quickopen.ui 930794
> >   trunk/KDE/kdevplatform/plugins/quickopen/quickopenplugin.h 930794
> >
> trunk/KDE/kdevplatform/plugins/quickopen/quickopenplugin.cpp 930794
> >
> > Diff: http://reviewboard.kde.org/r/174/diff
> >
> >
> > Testing
> > -------
> >
> >
> > Thanks,
> >
> > Dmitry
> >
> >
>
>
> _______________________________________________
> KDevelop-devel mailing list
> KDevelop-devel at kdevelop.org
> https://barney.cs.uni-potsdam.de/mailman/listinfo/kdevelop-devel
>