Bug#1606: marked as done (Next Error moves to wrong line in output window [23:31,22.07.99])

[Stephan Kulow]

Your message dated Fri, 30 Jul 1999 01:31:05 +0200
with message-id <99073001313009.06893 at ati17>
and subject line (no subject)
has caused the attached bug report to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what I'm
talking about this indicates a serious mail system misconfiguration
somewhere.  Please contact me immediately.)

Stephan Kulow
(administrator, KDE bugs database)

Received: (at submit) by bugs.kde.org; 22 Jul 1999 21:49:20 +0000
>From gtyler at iafrica.com Thu Jul 22 23:49:20 1999
Received: from smtp03.iafrica.com ([196.7.0.133]:23822 "EHLO smtp03.iafrica.com" ident: "NO-IDENT-SERVICE[2]") by max.tat.physik.uni-tuebingen.de with ESMTP id <744969-2982>; Thu, 22 Jul 1999 23:49:07 +0200
Received: from [196.31.83.133] (helo=196-31-83-133 ident=gordon)
	by smtp03.iafrica.com with smtp (Exim 1.92 #1)
	for submit at bugs.kde.org
	id 117Qhj-000JKx-00; Thu, 22 Jul 1999 23:48:39 +0200
From:	Gordon Tyler <gtyler at iafrica.com>
To:	submit at bugs.kde.org
Subject: Next Error moves to wrong line in output window [23:31,22.07.99]
Date:	Thu, 22 Jul 1999 23:47:34 +0200
X-Mailer: KMail [version 1.0.24]
Content-Type: text/plain
MIME-Version: 1.0
Message-Id: <99072223492700.16278 at 196-31-83-133>
Content-Transfer-Encoding: 8bit
Return-Path: <gtyler at iafrica.com>
X-Orcpt: rfc822;submit at bugs.kde.org
X-UIDL: 932680160.635554.4540

Package: kdevelop
Version: 0.4-19990722
Severity: normal

Bugreport ID : 23:31,22.07.99

Originator       : Gordon Tyler
E-Mail   : gtyler at iafrica.com

Subject : Next Error moves to wrong line in output window

Error Class      : software bug
Error Location: editor
Priority         : low
Bug Description ---------------------------

When using the Next Error command, the cursor is placed on
the correct lsource ine for the error but the output window scrolls to 
the next line of the output and the statusbar displays the incorrect line.

How to repeat the error -------------------

Build with errors, select View->Next Error

Bugfix or Workaround ----------------------

I've fixed the bug and generated a patch with diff -u:
--- kdevelop/kdevelop/cerrormessageparser.cpp    Tue Jun  8 13:07:19 1999
+++ kdevelop-new/kdevelop/cerrormessageparser.cpp        Thu Jul 22 23:29:33 1999
@@ -57,7 +57,6 @@
QRegExp error_reg(":*:[0-9]*:*:"); // is it an error line for sgml2html?, I hope it works

for(str = outputlist.first();str != 0;str = outputlist.next()){
-    makeoutputline++;
if((pos1=error_reg.match(str)) != -1){ // error ?
pos2 = str.find(':',pos1+1);
error_str = str.mid(pos1+1,pos2-pos1-1);
@@ -71,6 +70,7 @@
 m_info_list.append( error_info);
}
}
+    makeoutputline++;
}
out();
//  cerr << endl << endl << ":::::::::";
@@ -115,7 +115,6 @@
QString error_str;

for(str = outputlist.first();str != 0;str = outputlist.next()){
-    makeoutputline++;
//enter directory
if((pos1=enter_reg.match(str)) != -1){
// extract the enter directory
@@ -167,6 +166,7 @@
 
}
}
+    makeoutputline++;
} //  end for outputlist
}


System Information ------------------------

KDevelop version         : 0.4-19990722
KDE version              : 1.1.1
QT version               : 1.44
OS/Distribution  : Linux / RedHat 6.0
Compiler                 : g++