[korganizer] [Bug 398459] Crash caused by color custimization
Denis Kurz
bugzilla_noreply at kde.org
Thu Oct 11 22:23:48 BST 2018
https://bugs.kde.org/show_bug.cgi?id=398459
Denis Kurz <kdenis at posteo.de> changed:
What |Removed |Added
----------------------------------------------------------------------------
Latest Commit| |https://commits.kde.org/ako
| |nadi/9d83f0752828942789535b
| |1d0dc0ddc3c8b479bd
Resolution|--- |FIXED
Version Fixed In| |5.9.3
Status|CONFIRMED |RESOLVED
--- Comment #3 from Denis Kurz <kdenis at posteo.de> ---
Git commit 9d83f0752828942789535b1d0dc0ddc3c8b479bd by Denis Kurz.
Committed on 11/10/2018 at 21:23.
Pushed by dkurz into branch 'Applications/18.08'.
Fix KOrg category color customization crash
Summary:
Use default value for NULL columns.
Without this patch, possibly different default values are used for
entity construction (default from akonadidb.xml) and when reading a row
from the database (default-constructed), resulting in inconsistencies.
For example, when modifying a Tag, the resulting Tag modify notification
indicates that the new parentId of the modified Tag is 0
(default-constructed qint64), whereas Tags without parents are
initialized with parentId -1. This patch fixes these inconsistencies by
considering the "default" value from akonadidb.xml for row-to-entity
conversion, too.
Set default Tag::parentId to -1.
A parentless Tag is initialized with parentId -1, so we should also
report that when reading a Tag from the database where the parentId
field is NULL.
FIXED-IN: 5.9.3
Test Plan:
KOrganizer stops crashing on category color customization
with this patch. More detailed test plan suggestions welcome.
Reviewers: #kde_pim, dvratil
Reviewed By: #kde_pim, dvratil
Subscribers: dvratil, kde-pim
Tags: #kde_pim
Differential Revision: https://phabricator.kde.org/D16051
M +2 -2 src/server/storage/akonadidb.xml
M +1 -1 src/server/storage/entities.xsl
https://commits.kde.org/akonadi/9d83f0752828942789535b1d0dc0ddc3c8b479bd
--
You are receiving this mail because:
You are the assignee for the bug.
More information about the Kdepim-bugs
mailing list