[kdepim] [Bug 400934] kdepim-runtime does not compile with qt 5.11 (because QString::QString(const char*), QChar::QChar(char) and QString::QString(const QByteArray&) are private)

[Laurent Montel]

https://bugs.kde.org/show_bug.cgi?id=400934

Laurent Montel <montel at kde.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |LATER
             Status|REOPENED                    |RESOLVED

--- Comment #15 from Laurent Montel <montel at kde.org> ---
(In reply to Manuel Nickschas from comment #14)
> The compiler flags -DQT_NO_CAST_FROM_ASCII -DQT_NO_CAST_FROM_BYTEARRAY
> -DQT_NO_CAST_TO_ASCII are enforced by extra-cmake-modules in
> KDEFrameworkCompilerSettings.cmake; so those are not added by Gentoo.

indeed it's in KDEFrameworkCompilerSettings.cmake I know as I added it in
kdepim-runtime.
but we use kdelibs4support which has remove_definition(....)
but as gentoo force it to build it will override remove_definition.
I tested in local it yesterday

> 
> In addition, resources/ews/ewsclient/auth/ewspkeyauthjob.cpp misses an
> #include <QUrlQuery>; also in that file, QString::toAscii() is used twice,
> which is deprecated since Qt 5.0 (and I guess something in KDE's build chain
> disables those methods, although I could not find the actual place).
> 
> Removing the flags from KDEFrameworkCompilerSettings.cmake, adding the
> missing include and changing toAscii() to toLatin1() fixes the
> kdepim-runtime build for me, but obviously these are hacks that should be
> fixed properly.

For sure they need to be fix. It's for that I close as 'later' as it compiles
fine for the moment

> 
> I'm reopening the bug, because these seem to be upstream issues rather than
> Gentoo issues. If you disagree, feel free to close again.

I disagreee => I close it

-- 
You are receiving this mail because:
You are the assignee for the bug.