<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/129270/">https://git.reviewboard.kde.org/r/129270/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for Kdenlive.</div>
<div>By alcinos alcinos.</div>
<p style="color: grey;"><i>Updated oct. 31, 2016, 1:18 matin</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Add base class to List Parameter</p></pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kdenlive
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">This is a first step towards a refactoring of the effects stack. Currently the different widgets do not share a base class and their creation based on the xml is a bit cluttered, with a lot of redundancies. The plan is to unify this by creating a proper factory method.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I'll split the work into small and hopefully easy to review bits so that we make sure that no feature is lost on the way.
In this diff, I only make DoubleParameterWidget a subclass of AbstractParameterWidget</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Tested with a mock project</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> (updated)</h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/CMakeLists.txt <span style="color: grey">(2814fa3)</span></li>
<li>src/effectstack/CMakeLists.txt <span style="color: grey">(80ae0d6)</span></li>
<li>src/effectstack/parametercontainer.h <span style="color: grey">(3b1b1b3)</span></li>
<li>src/effectstack/parametercontainer.cpp <span style="color: grey">(ccec798)</span></li>
<li>src/effectstack/widgets/abstractparamwidget.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/effectstack/widgets/doubleparameterwidget.h <span style="color: grey">(7c81a2e)</span></li>
<li>src/effectstack/widgets/doubleparameterwidget.cpp <span style="color: grey">(bf7f245)</span></li>
<li>src/effectstack/widgets/draggablelabel.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/effectstack/widgets/draggablelabel.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/effectstack/widgets/listparamwidget.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/effectstack/widgets/listparamwidget.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/ui/listval_ui.ui <span style="color: grey">(7bc1925)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/129270/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>