<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/129023/">https://git.reviewboard.kde.org/r/129023/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#e0e0e0" width="100%" cellpadding="12" style="border: 1px gray solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<h1 style="margin: 0; padding: 0; font-size: 10pt;">This change has been marked as submitted.</h1>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for Kdenlive.</div>
<div>By The DiveO.</div>
<p style="color: grey;"><i>Updated Sept. 26, 2016, 8:26 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Submitted with commit e6561652db31de58ea4570da0edb4af3e7a02379 by Jean-Baptiste Mardelle to branch master.</pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kdenlive
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">This patch improves the existing expansion of playlist clips in the timeline as follows:
- improves on error reporting when there is not enough free track space to expand the clip, more precisly spelling out what amount of free track space is needed, as opposed to free tracks.
- improves overall error reporting in the context of expanding playlist clips by adding user-visible reporting where we only had debug messages so far.
- improves on collision detection, improving workflow for some Kdenlive library users, see below.
- playlist clip expansion is no <strong style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;">down</strong> instead of <em style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;">up</em>: this better matches the overall timeline concept, where in the timeline transitions belong to the "b track" upper track, as opposed to the "a track". Transitions extend <strong style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;">below</strong> the track they are placed on.
- if there isn't enough free room on the timeline <em style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;">below</em>, then, as before, the playlist clip is attempted to be shifted up for expansion in order to find enough free track space.
- following the timeline model, expand clip does not regard a transition immediately above the playlist to be a collision. In fact, as playlist clips cannot possess transitions with a "b track" above their topmost playlist track, there can't be such a collision anyway. In turn, this patch improves the workflow for those users that have things like overlay logos on a top track and need to expand a playlist clip immediately below it.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">On recent Kdenlive git master.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/timeline/customtrackview.cpp <span style="color: grey">(4ba92d9)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/129023/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>