<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/129011/">https://git.reviewboard.kde.org/r/129011/</a>
</td>
</tr>
</table>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="https://git.reviewboard.kde.org/r/129011/diff/1/?file=477425#file477425line2569" style="color: black; font-weight: bold; text-decoration: underline;">src/bin/bin.cpp</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">2569</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="k">if</span> <span class="p">(</span><span class="n">mltService</span> <span class="o">==</span> <span class="s">"avformat-novalidate"</span></pre></td>
</tr>
</tbody>
</table>
<div style="margin-left: 2em;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Very nice job, thanks a lot for that.
Just a detail, it is recommanded to use QLatin1String() in these string comparisons, like:
mltServie == QLatin1String("avformat-novalidate") ...</p></pre>
</div>
</div>
<br />
<p>- Jean-Baptiste Mardelle</p>
<br />
<p>On September 24th, 2016, 5:45 p.m. UTC, The DiveO wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for Kdenlive.</div>
<div>By The DiveO.</div>
<p style="color: grey;"><i>Updated Sept. 24, 2016, 5:45 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kdenlive
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">This patch gives a little love to Kdenlive's library:
- replaces the ambigious "+" icon to add a library clip to your project with the "add clip" icon, thus getting in line of adding a clip to the project bin.
- improves on error reporting during playlist expansion: errors are now clearly reported to the user through the status bar reporting mechanism; most users won't have a terminal window visible while using Kdenlive, so they won't see the error debug messages.
- fixes Kdenlive hanging for a very loooooooong time while trying to load producers after playlist expansion due to relative paths failing. This patch checks for relative producer urls during expansion and properly re-roots them based on the playlist's root element/directory. Of course, this does not fix issues where clips have been moved after a library playlist clip has been created.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Tested on recent Kdenlive git master.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/bin/bin.cpp <span style="color: grey">(00d9587)</span></li>
<li>src/library/librarywidget.cpp <span style="color: grey">(7620bbe)</span></li>
<li>src/mainwindow.cpp <span style="color: grey">(8022226)</span></li>
<li>src/timeline/customtrackview.cpp <span style="color: grey">(3462496)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/129011/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>