<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/126796/">https://git.reviewboard.kde.org/r/126796/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On January 20th, 2016, 10:28 a.m. UTC, <b>Jean-Baptiste Mardelle</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="https://git.reviewboard.kde.org/r/126796/diff/1/?file=434205#file434205line317" style="color: black; font-weight: bold; text-decoration: underline;">src/utils/freesound.cpp</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">310</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">m_previewProcess</span><span class="o">-></span><span class="n">start</span><span class="p">(</span><span class="n">KdenliveSettings</span><span class="o">::</span><span class="n">ffplaypath</span><span class="p">()</span> <span class="o">+</span> <span class="s">" "</span> <span class="o">+</span> <span class="n">url</span> <span class="o">+</span> <span class="s">" -nodisp -autoexit"</span><span class="p">);</span></pre></td>
</tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I'd prefer if you keep the previous format, calling start with: </p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">m_previewProcess->start(app, parameters);</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Seems more secure to me, especially if the url arg is comming from an unsecure source... I am not sure how Qt handles the situation if the url is like;</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">"http://test.org;rm -Rf *"</p></pre>
</blockquote>
<p>On January 20th, 2016, 9:46 p.m. UTC, <b>Roger Morton</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Right. Security and Url injection. I will see if I can get the other format working. I think now I remember resolving a confilict on this part. And I guess I resolved it the wrong way.</p></pre>
</blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Is this what you are thinking or something else again?
m_previewProcess->start(KdenliveSettings::ffplaypath(), QStringList() << url << QStringLiteral("-nodisp") << QStringLiteral("-autoexit"));</p></pre>
<br />
<p>- Roger</p>
<br />
<p>On January 18th, 2016, 1:54 p.m. UTC, Roger Morton wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for Kdenlive and Vincent Pinon.</div>
<div>By Roger Morton.</div>
<p style="color: grey;"><i>Updated Jan. 18, 2016, 1:54 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kdenlive
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">online resource -logs into users freesound accounts to get permission for HQ audio. Fixes archive.org video search new dependancy KF5WebKit. (libkf5webkit5-dev)</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Built. Tested file downloads from freesound. Auhenticates to freesound. keeps authenticated until you delete $HOME/.config/kde.org/kdenlive.conf
Archive.org video search is now working. Display animiated .gif as the preview file from Archive.org videos.
No longer have to click search button twice to get it to do the search the first time it runs
Option to not use personal freesound account and just use HQ preview file instead.
Downloads low quality preview file in background and does not notify you of it finishing.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/CMakeLists.txt <span style="color: grey">(87d29d2)</span></li>
<li>src/qt-oauth-lib/logindialog.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/qt-oauth-lib/logindialog.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/qt-oauth-lib/oauth2.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/qt-oauth-lib/oauth2.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/ui/freesound_ui.ui <span style="color: grey">(55a453d)</span></li>
<li>src/utils/abstractservice.h <span style="color: grey">(0a6a4a7)</span></li>
<li>src/utils/archiveorg.h <span style="color: grey">(5cdc84f)</span></li>
<li>src/utils/archiveorg.cpp <span style="color: grey">(1be4d6f)</span></li>
<li>src/utils/freesound.h <span style="color: grey">(f72d145)</span></li>
<li>src/utils/freesound.cpp <span style="color: grey">(932c47f)</span></li>
<li>src/utils/openclipart.h <span style="color: grey">(7a4df1e)</span></li>
<li>src/utils/openclipart.cpp <span style="color: grey">(adbba68)</span></li>
<li>src/utils/resourcewidget.h <span style="color: grey">(c171e3c)</span></li>
<li>src/utils/resourcewidget.cpp <span style="color: grey">(6453f7f)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/126796/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>