OK one more try...<br><br>Patch "kdenlive_DropFrame_Patch_v2.0.txt" resulted in a crash when opening the DVD Wizard from the File menu.<br><br>The new patch attached to issue #1033, "kdenlive_DropFrame_Patch_v2.1.txt" includes all the changes from the previous patch, but does not result in a crash when opening the DVD Wizard.<br>
<br>Here is the new patch 2.1: <a href="http://www.kdenlive.org/mantis/file_download.php?file_id=676&type=bug">http://www.kdenlive.org/mantis/file_download.php?file_id=676&type=bug</a><br><br>-JTM<br><br><br><div class="gmail_quote">
On Thu, Mar 18, 2010 at 1:53 PM, John T. Mertz <span dir="ltr"><<a href="mailto:thatonefilmguy@gmail.com">thatonefilmguy@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">
Ok I have found one issue with the (big) patch. The DVDWizard is<br>
broken. When trying to run it, kdenlive crashes when DvdWizardChapters<br>
calls resetProfiles() from monitormanager.cpp, which in turn calls<br>
updateTimecodeFormat() from monitor.cpp, which then seems to crash in<br>
the first line:<br>
<br>
m_frametimecode = KdenliveSettings::frametimecode();<br>
<br>
(I would reference the line number but that would be pointless with my<br>
local edited copy)<br>
<br>
If I put a kDebug() before and after that line, the first gets called<br>
but the second doesn't. Not sure why that line causes a crash. Any<br>
thoughts?<br>
<br>
Thanks,<br>
-JTM<br>
<div><div></div><div class="h5"><br>
On 3/18/10, John T. Mertz <<a href="mailto:thatonefilmguy@gmail.com">thatonefilmguy@gmail.com</a>> wrote:<br>
> Jb<br>
><br>
> Actually, I just finished the patch. There might be a couple of spots in<br>
> the GUI that I missed replacing with the "99:99.99:99" DF format, but at a<br>
> glance I did not find any. If anyone finds areas that have not been<br>
> replaced, please let me know. It should be easy to fix any missed areas.<br>
><br>
> The new patch is called "kdenlive_DropFrame_Patch_v2.0.txt" and I attached<br>
> it to bug #1033: <a href="http://www.kdenlive.org/mantis/view.php?id=1033" target="_blank">http://www.kdenlive.org/mantis/view.php?id=1033</a><br>
><br>
> A direct link to the patch:<br>
> <a href="http://www.kdenlive.org/mantis/file_download.php?file_id=675&type=bug" target="_blank">http://www.kdenlive.org/mantis/file_download.php?file_id=675&type=bug</a><br>
><br>
> The new patch does the following:<br>
><br>
> - Replaces the timecode separators in most (if not all) areas of the<br>
> application including: Timeline, Project/Clip Monitors, Add Title Clip,<br>
> Add<br>
> Color Clip, Add Slideshow Clip, and Clip Properties dialogue boxes, as<br>
> well<br>
> as Keyframe/Effects windows.<br>
><br>
><br>
><br>
> - Centralizes the inputMask values for DF/NDF into the new function<br>
> "inputMask()" which is part of the Timecode class. This function can be<br>
> called to get the appropriate inputMask QString, based on the timecode<br>
> object that calls it. Therefore inputMask for both DF and NDF projects<br>
> can<br>
> be set using, for example:<br>
><br>
> m_timePos->setInputMask(m_monitorManager->timecode().inputMask());<br>
><br>
> instead of setting it manually:<br>
><br>
> m_timePos->setInputMask("99:99:99:99");<br>
><br>
><br>
> - The patch also implements a simple function to reformat the separators<br>
> for timecode currently being displayed in the project. This is useful<br>
> if/when the user changes the project format to reformat timecode values<br>
> currently displayed if they are not already being refreshed when the<br>
> project<br>
> format changes. It is also useful for pre-processing default timecode<br>
> duration values (such as Color Clip default length) before setting the<br>
> default Color Clip duration value in the CC dialogue box. Supplying the<br>
> default NDF "00:05:00:00" to the duration dialogue when the inputMask is<br>
> set<br>
> to DF results in the default duration being improperly set, so<br>
> preprocessing<br>
> the default duration is required. The default duration must be set in<br>
> the<br>
> same format as the input mask.<br>
><br>
> The new function, "reformatSeparators(QString duration)" is also a part of<br>
> the Timecode class. So calling:<br>
><br>
> timecodeObject->reformatSeparators("00:05:00:00");<br>
><br>
> ...would reformat the timecode from "00:05.00:00" if the project is Drop<br>
> Frame, and will return it in the same format "00:05:00:00" if the project<br>
> is<br>
> NDF. Likewise, if "00:05.00:00" is supplied to the function and the<br>
> project<br>
> is NDF, then the function will return NDF timecode "00:05:00:00".<br>
><br>
><br>
> - It implements another new function, "df()" as part of the Timecode<br>
> class, which simply returns a boolean TRUE if the timecode object passed<br>
> to<br>
> it is drop frame.<br>
><br>
> if ( timecodeObject->df() ) { ... }<br>
><br>
><br>
> - For slideshow clips, the default transition (luma) duration previously<br>
> was hard coded to "00:00:00:24". Not only is this timecode value<br>
> invalid<br>
> for projects with 24 FPS or less, but it also is variable in duration<br>
> for<br>
> projects >25 FPS. This has been revised to always return a value of 1<br>
> second based on the FPS of the project:<br>
><br>
> m_view.luma_duration->setText(m_timecode.getTimecodeFromFrames(int(ceil(m_timecode.fps()))));<br>
><br>
> - Some other optimizations have also been made to Timecode.cpp which<br>
> makes it slightly more efficient, as well as accommodates the new DF<br>
> display<br>
> format.<br>
><br>
><br>
> Download it and take a look!<br>
><br>
> Cheers!<br>
> -JTM<br>
><br>
><br>
> On Thu, Mar 18, 2010 at 6:04 AM, John T. Mertz<br>
> <<a href="mailto:thatonefilmguy@gmail.com">thatonefilmguy@gmail.com</a>>wrote:<br>
><br>
>> Hi jb,<br>
>><br>
>> Please note I am working on a pretty massive patch which is a much more<br>
>> thorough fix for issue #1033, in addition to #1511 and #1512. The<br>
>> patches<br>
>> currently attached to issue #1033 should be ignored for now. The new<br>
>> patch<br>
>> I am writing replaces the existing patches and should be applied in place<br>
>> of, not on top of, the ones I already uploaded.<br>
>><br>
>> <a href="http://www.kdenlive.org/mantis/view.php?id=1511" target="_blank">http://www.kdenlive.org/mantis/view.php?id=1511</a><br>
>> <a href="http://www.kdenlive.org/mantis/view.php?id=1512" target="_blank">http://www.kdenlive.org/mantis/view.php?id=1512</a><br>
>><br>
>> It will change timecode display to drop frame throughout the application<br>
>> when a DF project is in use, and fixes a number of other various issues I<br>
>> found while going through the code. I will post a change list when the<br>
>> patch is available. It is almost done but has taken some time due to the<br>
>> massive amount of changes that were necessary to implement DF timecode<br>
>> throughout. I've done a fair amount of testing to ensure everything<br>
>> works<br>
>> OK, but needless to say it will definitely need more eyes on it due to<br>
>> the<br>
>> size and scope of the patch.<br>
>><br>
>> Also, in writing this patch I had to change the DF timecode mask to<br>
>> "99:99.99:99" (display standard typically seen on video cameras and<br>
>> decks)<br>
>> instead of the more standard "99:99:99;99" (display standard typically<br>
>> seen<br>
>> in NLEs) because I found that Qt's inputMask does not support semicolons<br>
>> as<br>
>> separators. Hopefully this will be resolved in some future version of<br>
>> Qt.<br>
>><br>
>> -JTM<br>
>><br>
>><br>
>><br>
>> On Thu, Mar 18, 2010 at 5:11 AM, jb <<a href="mailto:jb@kdenlive.org">jb@kdenlive.org</a>> wrote:<br>
>><br>
>>> On Tuesday 16 March 2010 01:48:06 T.J. Mertz wrote:<br>
>>> > Hello,<br>
>>> ><br>
>>> > I've attached a svn diff patch file to issue #1033 in Mantis which<br>
>>> resolves<br>
>>> > this issue.<br>
>>> ><br>
>>> > <a href="http://www.kdenlive.org/mantis/view.php?id=1033" target="_blank">http://www.kdenlive.org/mantis/view.php?id=1033</a><br>
>>><br>
>>> Thanks for the patch. I just moved to a new apartment, so had no time in<br>
>>> the<br>
>>> last weeks. Hope to be able to catch up and check your patch & other<br>
>>> issues in<br>
>>> next week, unless someone else can try it out & commit of course.<br>
>>><br>
>>> regards<br>
>>><br>
>>> jb<br>
>>><br>
>>><br>
>>> ------------------------------------------------------------------------------<br>
>>> Download Intel® Parallel Studio Eval<br>
>>> Try the new software tools for yourself. Speed compiling, find bugs<br>
>>> proactively, and fine-tune applications for parallel performance.<br>
>>> See why Intel Parallel Studio got high marks during beta.<br>
>>> <a href="http://p.sf.net/sfu/intel-sw-dev" target="_blank">http://p.sf.net/sfu/intel-sw-dev</a><br>
>>> _______________________________________________<br>
>>> Kdenlive-devel mailing list<br>
>>> <a href="mailto:Kdenlive-devel@lists.sourceforge.net">Kdenlive-devel@lists.sourceforge.net</a><br>
>>> <a href="https://lists.sourceforge.net/lists/listinfo/kdenlive-devel" target="_blank">https://lists.sourceforge.net/lists/listinfo/kdenlive-devel</a><br>
>>><br>
>><br>
>><br>
><br>
<br>
</div></div><font color="#888888">--<br>
Sent from my mobile device<br>
</font></blockquote></div><br>