<!DOCTYPE html PUBLIC "-//W3C//DTD HTML 4.01 Transitional//EN">
<html>
<head>
<meta content="text/html;charset=ISO-8859-1" http-equiv="Content-Type">
</head>
<body bgcolor="#ffffff" text="#000000">
Hi Dan,<br>
<br>
Dan Dennedy wrote:
<blockquote
cite="mid:27dd34e60908231707n384f7b80u920915c0ca3e6f6e@mail.gmail.com"
type="cite">
<pre wrap="">Not sure why this did not get to the MLT list.
2009/8/22 Ivan Schreter <a class="moz-txt-link-rfc2396E" href="mailto:schreter@gmx.net"><schreter@gmx.net></a>:
</pre>
<blockquote type="cite">
<pre wrap="">Hi all,
FYI: since there were no objections from FFmpeg since a week, I've just
committed my seeking patches to FFmpeg repository (revision 19681). MPEG-TS
(and thus also AVCHD) seeking now works, at least for AVCHD movies from my
Panasonic camcorder. I know that Canon camcorders had some issues with
proper key frame detection (files are missing appropriate SEI messages), so
they might still have a problem.
As for MLT, I've updated my patch for the newest MLT revision (as of today,
2009-08-22). I didn't test it too much, though, but here it is attached. So
feel free to test it.
</pre>
</blockquote>
<pre wrap=""><!---->
That's great! I will apply the patch, but in a way that requires an
explicit configure flag to enable it.
</pre>
<blockquote type="cite">
<pre wrap="">MPEG-PS movies (e.g., DVD VOB) don't work correctly with MLT patch only. Two
patches for FFmpeg are still needed, one which introduces proper seeking for
</pre>
</blockquote>
<pre wrap=""><!---->
I think I will name the flag --avformat-break-mpegps to make people
acknowledge the risk. My clients and I use a lot of non-VOB/DVD MPEG-2
Program Streams.
</pre>
</blockquote>
I'm working on another patch for MPEG-PS, so that will be supported in
the near future correctly as well, I hope.<br>
<br>
Since the changes I made are in if() conditions, you can eventually use
this to disable it for MPEG-PS for now. Configure flag with name
"*-breaks-*" doesn't sound particularly good :-)<br>
<br>
<blockquote
cite="mid:27dd34e60908231707n384f7b80u920915c0ca3e6f6e@mail.gmail.com"
type="cite">
<pre wrap=""></pre>
<blockquote type="cite">
<pre wrap="">MPEG-PS, one to fix a bug in mpegvideo parser. These patches are not yet
accepted by FFmpeg, but I attached them here. They also cause seeking
regression (patch NOT attached).
</pre>
</blockquote>
<pre wrap=""><!---->
Please explain further the last line. I had first read it to mean:
applying the patches breaks seeking on ps when the app has not made
some adjustments. However, I do not understand what patch you refer to
when you say it is not attached.
</pre>
</blockquote>
Only the patch with regression is not attached. The two FFmpeg patches
for parser fix and seek update were attached, so you have complete code.<br>
<br>
Applying the seeking patch on FFmpeg doesn't break apps. It just seeks
correctly. So the current workaround in MLT with seeking one second
backward will work with the patch in FFmpeg as well, you'll just get
less performance (as it is today) and off-by-2-3-frames. Only MLT patch
and no FFmpeg patches will break seeking of MPEG-PS.<br>
<br>
I hope it's clear now...<br>
<br>
Regards,<br>
<br>
Ivan<br>
<br>
<br>
</body>
</html>