[kdenlive] Review Request 126055: Don't hard code name of the pkg-config executable

Jean-Baptiste Mardelle jb at kdenlive.org
Fri Nov 13 20:53:05 UTC 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126055/#review88333
-----------------------------------------------------------

Ship it!


Ship It!

- Jean-Baptiste Mardelle


On Nov. 13, 2015, 5:07 p.m., Heiko Becker wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126055/
> -----------------------------------------------------------
> 
> (Updated Nov. 13, 2015, 5:07 p.m.)
> 
> 
> Review request for Kdenlive.
> 
> 
> Repository: kdenlive
> 
> 
> Description
> -------
> 
> Its name might be different and include an architecture or toolchain
> prefix. cmake's FindPkgConfig module respects the PKG_CONFIG env
> variable and sets PKG_CONFIG_EXECUTABLE accordingly.
> 
> 
> Diffs
> -----
> 
>   src/CMakeLists.txt e8c399f 
> 
> Diff: https://git.reviewboard.kde.org/r/126055/diff/
> 
> 
> Testing
> -------
> 
> Successfully tested with a x86_64-pc-linux-gnu named pkg-config executable, exported to ${PKG_CONFIG}.
> 
> 
> Thanks,
> 
> Heiko Becker
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdenlive/attachments/20151113/9c4436e5/attachment.html>


More information about the kdenlive mailing list