<table><tr><td style="">sredman added a subscriber: apol.<br />sredman added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D17214">View Revision</a></tr></table><br /><div><div><p>This is good so far. Thank you!</p>
<p>Two small bugs which come from the same source:</p>
<p>If I type the phone number of a contact with whom I do not have a conversation, that gets matched to the contact (nice job!)</p>
<p>Since the filter box has their phone number typed in, the contact is not visible, so you get the error: "TypeError: Cannot call method 'startChat' of null"</p>
<p>There is also an error when you type the phone number for a contact with whom there is already a conversation <a href="https://phabricator.kde.org/F6445105" style="background-color: #e7e7e7;
border-color: #e7e7e7;
border-radius: 3px;
padding: 0 4px;
font-weight: bold;
color: black;text-decoration: none;">F6445105: DoubleContact.png</a></p>
<p>However, I think that is more of a bug that was already in the search box. The search box should allow filtering by address as well as by contact name. That way, these situations could never occur.</p></div></div><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D17214#inline-94033">View Inline</a><span style="color: #4b4d51; font-weight: bold;">conversationsdbusinterface.cpp:125</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; "> <span style="color: #74777d">// Since there are no messages in the conversation, we can't do anything sensible</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);"> <span class="bright"></span><span class="n"><span class="bright">qCWarnin</span>g</span><span class="p">(</span><span class="n">KDECONNECT_CONVERSATIONS</span><span class="p">)</span> <span style="color: #aa2211"><<</span> <span style="color: #766510">"Got a conversationID for a conversation with no messages!"</span><span class="p">;</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="bright"></span><span style="color: #74777d"><span class="bright">// qCDebu</span>g(KDECONNECT_CONVERSATIONS) << "Got a conversationID for a conversation with no messages!";</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="n">qCDebug</span><span class="p">(</span><span class="n">KDECONNECT_CONVERSATIONS</span><span class="p">)</span> <span style="color: #aa2211"><<</span> <span style="color: #766510">"Trying to send a new message to new conversation with address "</span> <span style="color: #aa2211"><<</span> <span class="n">conversationID</span> <span style="color: #aa2211"><<</span> <span class="n">endl</span><span class="p">;</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">No need to keep commented-out code</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D17214#inline-94032">View Inline</a><span style="color: #4b4d51; font-weight: bold;">conversationsdbusinterface.cpp:127</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="n">qCDebug</span><span class="p">(</span><span class="n">KDECONNECT_CONVERSATIONS</span><span class="p">)</span> <span style="color: #aa2211"><<</span> <span style="color: #766510">"Trying to send a new message to new conversation with address "</span> <span style="color: #aa2211"><<</span> <span class="n">conversationID</span> <span style="color: #aa2211"><<</span> <span class="n">endl</span><span class="p">;</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="n">createNewConversation</span><span class="p">(</span><span class="n">conversationID</span><span class="p">,</span> <span class="n">message</span><span class="p">);</span>
</div><div style="padding: 0 8px; margin: 0 4px; "> <span style="color: #aa4000">return</span><span class="p">;</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">You pass the conversationID here, which you have hard-coded (in the QML application) to 0. That means that the phone tries to send a message to the phone number "0" which is probably not what was intended. Did you mean message.address()?<br />
<a href="https://phabricator.kde.org/F6445122" style="background-color: #e7e7e7;
border-color: #e7e7e7;
border-radius: 3px;
padding: 0 4px;
font-weight: bold;
color: black;text-decoration: none;">F6445122: MessageNullTarget.jpg</a></p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D17214#inline-94026">View Inline</a><span style="color: #4b4d51; font-weight: bold;">conversationlistmodel.cpp:170-185</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="n">QScopedPointer</span><span style="color: #aa2211"><</span><span class="n">KPeople</span><span style="color: #aa2211">::</span><span class="n">PersonData</span><span style="color: #aa2211">></span> <span class="n">personData</span><span class="p">(</span><span class="n">lookupPersonByAddress</span><span class="p">(</span><span class="n">address</span><span class="p">));</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="n">QStandardItem</span><span style="color: #aa2211">*</span> <span class="n">item</span> <span style="color: #aa2211">=</span> <span style="color: #aa4000">new</span> <span class="n">QStandardItem</span><span class="p">();</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #aa4000">if</span> <span class="p">(</span><span class="n">personData</span><span class="p">)</span> <span class="p">{</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="n">item</span><span style="color: #aa2211">-></span><span class="n">setText</span><span class="p">(</span><span class="n">personData</span><span style="color: #aa2211">-></span><span class="n">name</span><span class="p">());</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="n">item</span><span style="color: #aa2211">-></span><span class="n">setIcon</span><span class="p">(</span><span class="n">QIcon</span><span class="p">(</span><span class="n">personData</span><span style="color: #aa2211">-></span><span class="n">photo</span><span class="p">()));</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="n">item</span><span style="color: #aa2211">-></span><span class="n">setData</span><span class="p">(</span><span class="n">personData</span><span style="color: #aa2211">-></span><span class="n">personUri</span><span class="p">(),</span> <span class="n">PersonUriRole</span><span class="p">);</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="p">}</span> <span style="color: #aa4000">else</span> <span class="p">{</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">This is a good idea! However, since it is code that was copy-pasted from another method ("createRowFromMessage") could you make a helper function which can be used by both of those? For instance, maybe something like "createItemFromMessage" which returns QStandardItem*. That method gets used directly by "createRowFromMessage". This method ("createRowFromAddress") would construct the dummy message with the dummy "[New Conversation]" body and timestamp, then call the same helper</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D17214#inline-94027">View Inline</a><span style="color: #4b4d51; font-weight: bold;">conversationlistmodel.cpp:183</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="n">item</span><span style="color: #aa2211">-></span><span class="n">setData</span><span class="p">(</span><span class="n">ConversationMessage</span><span style="color: #aa2211">::</span><span class="n">MessageTypeSent</span><span class="p">,</span> <span class="n">FromMeRole</span><span class="p">);</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="n">item</span><span style="color: #aa2211">-></span><span class="n">setData</span><span class="p">(</span><span style="color: #766510">"[New conversation]"</span><span class="p">,</span> <span class="n">Qt</span><span style="color: #aa2211">::</span><span class="n">ToolTipRole</span><span class="p">);</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="n">item</span><span style="color: #aa2211">-></span><span class="n">setData</span><span class="p">(</span><span style="color: #601200">1</span><span class="p">,</span> <span class="n">DateRole</span><span class="p">);</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;"><a href="https://phabricator.kde.org/p/apol/" style="
border-color: #f1f7ff;
color: #19558d;
background-color: #f1f7ff;
border: 1px solid transparent;
border-radius: 3px;
font-weight: bold;
padding: 0 4px;">@apol</a> How do we make this translate-able?</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D17214#inline-94034">View Inline</a><span style="color: #4b4d51; font-weight: bold;">conversationlistmodel.cpp:184</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="n">item</span><span style="color: #aa2211">-></span><span class="n">setData</span><span class="p">(</span><span style="color: #766510">"[New conversation]"</span><span class="p">,</span> <span class="n">Qt</span><span style="color: #aa2211">::</span><span class="n">ToolTipRole</span><span class="p">);</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="n">item</span><span style="color: #aa2211">-></span><span class="n">setData</span><span class="p">(</span><span style="color: #601200">1</span><span class="p">,</span> <span class="n">DateRole</span><span class="p">);</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="n">appendRow</span><span class="p">(</span><span class="n">item</span><span class="p">);</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Do you need to specify this? What happens if you leave it out?</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D17214#inline-94028">View Inline</a><span style="color: #4b4d51; font-weight: bold;">ConversationList.qml:68</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; "> <span style="color: #aa4000">deviceId:</span> <span style="color: #004012">device</span> <span style="color: #aa2211">?</span> <span style="color: #004012">device</span><span class="p">.</span><span style="color: #004012">id</span><span class="p">()</span> <span style="color: #aa2211">:</span> <span style="color: #766510">""</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #aa4000">id: address</span>
</div><div style="padding: 0 8px; margin: 0 4px; "> <span class="p">}</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Is this used for anything?</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D17214#inline-94030">View Inline</a><span style="color: #4b4d51; font-weight: bold;">ConversationList.qml:85</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #004012">address</span><span class="p">.</span><span style="color: #004012">createRowFromAddress</span><span class="p">(</span><span style="color: #004012">filter</span><span class="p">.</span><span style="color: #004012">text</span><span class="p">)</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #004012">view</span><span class="p">.</span><span style="color: #004012">currentIndex</span> <span style="color: #aa2211">=</span> <span style="color: #601200">1</span> <span style="color: #74777d">// the first possible seleciton</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="p">}</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">This should be set to 0 instead of 1</p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R224 KDE Connect</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D17214">https://phabricator.kde.org/D17214</a></div></div><br /><div><strong>To: </strong>turx, albertvaka, nicolasfella, sredman, KDE Connect<br /><strong>Cc: </strong>apol, kdeconnect, varunp, shivanshukantprasad, skymoore, brute4s99, wistak, dvalencia, rmenezes, julioc, Leptopoda, timothyc, jdvr, Danial0_0, johnq, Pitel, adeen-s, SemperPeritus, daniel.z.tg, jeanv, seebauer, bugzy, MayeulC, menasshock, mikesomov, tctara<br /></div>