<table><tr><td style="">sredman added inline comments.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D17126">View Revision</a></tr></table><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D17126#inline-93508">View Inline</a><span style="color: #4b4d51; font-weight: bold;">AppDatabase.java:166</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="n">cv</span><span style="color: #aa2211">.</span><span style="color: #354bb3">put</span><span style="color: #aa2211">(</span><span class="n">KEY_PRIVACY_OPTIONS</span><span style="color: #aa2211">,</span> <span class="n">value</span><span style="color: #aa2211">);</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #74777d">// FIXME inserts data to a database, but getPrivacyOptionsValue() always returns 0</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #aa4000">if</span> <span style="color: #aa2211">(</span><span class="n">res</span><span style="color: #aa2211">.</span><span style="color: #354bb3">getCount</span><span style="color: #aa2211">()</span> <span style="color: #aa2211">></span> <span style="color: #601200">0</span><span style="color: #aa2211">)</span> <span style="color: #aa2211">{</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">I forgot to clean up this comment</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D17126#inline-93509">View Inline</a><span style="color: #4b4d51; font-weight: bold;">AppDatabase.java:177-191</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #aa4000">public</span> <span style="color: #aa4000">void</span> <span style="color: #004012">setPrivacy</span><span style="color: #aa2211">(</span><span class="n">String</span> <span class="n">packageName</span><span style="color: #aa2211">,</span> <span class="n">PrivacyOptions</span> <span class="n">option</span><span style="color: #aa2211">,</span> <span style="color: #aa4000">boolean</span> <span class="n">isBlocked</span><span style="color: #aa2211">)</span> <span style="color: #aa2211">{</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #aa4000">int</span> <span class="n">curBit</span> <span style="color: #aa2211">=</span> <span class="n">option</span><span style="color: #aa2211">.</span><span style="color: #354bb3">ordinal</span><span style="color: #aa2211">();</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #aa4000">int</span> <span class="n">value</span> <span style="color: #aa2211">=</span> <span class="n">getPrivacyOptionsValue</span><span style="color: #aa2211">(</span><span class="n">packageName</span><span style="color: #aa2211">);</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="n">value</span> <span style="color: #aa2211">|=</span> <span style="color: #aa2211">(</span><span style="color: #601200">1</span> <span style="color: #aa2211"><<</span> <span class="n">curBit</span><span style="color: #aa2211">);</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="n">value</span> <span style="color: #aa2211">^=</span> <span class="n">isBlocked</span> <span style="color: #aa2211">?</span> <span style="color: #601200">0</span> <span style="color: #aa2211">:</span> <span style="color: #aa2211">(</span><span style="color: #601200">1</span> <span style="color: #aa2211"><<</span> <span class="n">curBit</span><span style="color: #aa2211">);</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="n">setPrivacyOptionsValue</span><span style="color: #aa2211">(</span><span class="n">packageName</span><span style="color: #aa2211">,</span> <span class="n">value</span><span style="color: #aa2211">);</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #aa2211">}</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">These sections could do with some comments explaining how you are using the encoded bits to store the two privacy options.<br />
Alternatively, it would be clearer to read if the table had two boolean columns instead of one integer :)</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D17126#inline-93507">View Inline</a><span style="color: #4b4d51; font-weight: bold;">NotificationsPlugin.java:262-264</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="n">np</span><span style="color: #aa2211">.</span><span style="color: #354bb3">set</span><span style="color: #aa2211">(</span><span style="color: #766510">"ticker"</span><span style="color: #aa2211">,</span> <span style="color: #766510">""</span><span style="color: #aa2211">);</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="n">np</span><span style="color: #aa2211">.</span><span style="color: #354bb3">set</span><span style="color: #aa2211">(</span><span style="color: #766510">"title"</span><span style="color: #aa2211">,</span> <span style="color: #766510">""</span><span style="color: #aa2211">);</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #74777d">//np.set("text", "");</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">I was messing around with this (thus the commented-out line). Do any of these need to be here? I don't think so, but we should test. If not, then the "else" block which matches this "if" can probably be combined into the "if (!blockContents)" block starting at line 250</p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R225 KDE Connect - Android application</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D17126">https://phabricator.kde.org/D17126</a></div></div><br /><div><strong>To: </strong>alexkovrigin, sredman, KDE Connect<br /><strong>Cc: </strong>sredman, alexkovrigin, kdeconnect, varunp, shivanshukantprasad, skymoore, brute4s99, wistak, dvalencia, rmenezes, julioc, Leptopoda, timothyc, jdvr, Danial0_0, johnq, Pitel, adeen-s, SemperPeritus, daniel.z.tg, jeanv, seebauer, bugzy, MayeulC, menasshock, mikesomov, tctara, apol<br /></div>