<table><tr><td style="">albertvaka accepted this revision.<br />albertvaka added a comment.<br />This revision is now accepted and ready to land.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D16738">View Revision</a></tr></table><br /><div><div><p>LGTM.</p>
<p>Although, documentation says: <br />
<tt style="background: #ebebeb; font-size: 13px;">This constant was deprecated in API level 28. Apps should use the more versatile requestNetwork(NetworkRequest, PendingIntent), registerNetworkCallback(NetworkRequest, PendingIntent) or registerDefaultNetworkCallback(ConnectivityManager.NetworkCallback)</tt></p></div></div><br /><div><strong>REPOSITORY</strong><div><div>R225 KDE Connect - Android application</div></div></div><br /><div><strong>BRANCH</strong><div><div>network_change_detection</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D16738">https://phabricator.kde.org/D16738</a></div></div><br /><div><strong>To: </strong>eduisters, KDE Connect, albertvaka<br /><strong>Cc: </strong>albertvaka, kdeconnect, shivanshukantprasad, skymoore, wistak, dvalencia, rmenezes, julioc, Leptopoda, timothyc, jdvr, yannux, Danial0_0, johnq, Pitel, adeen-s, SemperPeritus, daniel.z.tg, jeanv, seebauer, bugzy, MayeulC, menasshock, tctara, apol<br /></div>