<table><tr><td style="">albertvaka added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D14597">View Revision</a></tr></table><br /><div><div><p>Indeed, this can be removed.</p>

<p>This patch seems mergeable as it is, maybe the fix for the test can be a separate patch?</p></div></div><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D14597#inline-77254">View Inline</a><span style="color: #4b4d51; font-weight: bold;">landevicelink.cpp:124</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; ">        <span class="n">QVariantMap</span> <span class="n">transferInfo</span> <span style="color: #aa2211">=</span> <span class="n">packet</span><span class="p">.</span><span class="n">payloadTransferInfo</span><span class="p">();</span>
</div><div style="padding: 0 8px; margin: 0 4px; ">        <span style="color: #74777d">//FIXME: The next two lines shouldn't be needed! Why are they here?</span>
</div><div style="padding: 0 8px; margin: 0 4px; ">        <span class="n">transferInfo</span><span class="p">.</span><span class="n">insert</span><span class="p">(</span><span class="n">QStringLiteral</span><span class="p">(</span><span style="color: #766510">"useSsl"</span><span class="p">),</span> <span style="color: #304a96">true</span><span class="p">);</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Have you tried if removing these lines breaks something? At least <tt style="background: #ebebeb; font-size: 13px;">useSsl</tt> is never checked for sure. Can be a good time to remove it.</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D14597#inline-77253">View Inline</a><span style="color: #4b4d51; font-weight: bold;">landevicelink.cpp:136</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">        <span class="n">socket</span><span style="color: #aa2211">-></span><span class="n">connectToHostEncrypted</span><span class="p">(</span><span class="n">m_socketLineReader</span><span style="color: #aa2211">-></span><span class="n">peerAddress</span><span class="p">().</span><span class="n">toString</span><span class="p">(),</span> <span class="n">transferInfo</span><span class="p">[</span><span class="n">QStringLiteral</span><span class="p">(</span><span style="color: #766510">"port"</span><span class="p">)].</span><span class="n">toInt</span><span class="p">(),</span> <span class="n">QIODevice</span><span style="color: #aa2211">::</span><span class="n">ReadWrite</span><span class="p">);</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">        <span class="n">packet</span><span class="p">.</span><span class="n">setPayload</span><span class="p">(</span><span class="n">socket</span><span class="p">,</span> <span class="n">packet</span><span class="p">.</span><span class="n">payloadSize</span><span class="p">());</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">This would be more legible if split in three lines:</p>

<div class="remarkup-code-block" style="margin: 12px 0;" data-code-lang="text" data-sigil="remarkup-code-block"><pre class="remarkup-code" style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; padding: 12px; margin: 0; background: rgba(71, 87, 120, 0.08);">QString address = ...;
quint16 port = ...;
socket->connectToHostEncrypted(address, port, QIODevice::ReadWrite);</pre></div></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R224 KDE Connect</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D14597">https://phabricator.kde.org/D14597</a></div></div><br /><div><strong>To: </strong>nicolasfella, KDE Connect<br /><strong>Cc: </strong>albertvaka, kdeconnect, rmenezes, julioc, Leptopoda, timothyc, jdvr, yannux, Danial0_0, johnq, Pitel, adeen-s, SemperPeritus, ndavis, daniel.z.tg, jeanv, seebauer, bugzy, MayeulC, menasshock, tctara, apol<br /></div>