<table><tr><td style="">broulik added inline comments.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D12293">View Revision</a></tr></table><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D12293#inline-62421">View Inline</a><span style="color: #4b4d51; font-weight: bold;">notification.cpp:114</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">    <span class="n">connect</span><span class="p">(</span><span class="n">m_notification</span><span class="p">,</span> <span class="n">QOverload</span><span style="color: #aa2211"><</span><span style="color: #aa4000">unsigned</span> <span style="color: #aa4000">int</span><span style="color: #aa2211">>::</span><span class="n">of</span><span class="p">(</span><span style="color: #aa2211">&</span><span class="n">KNotification</span><span style="color: #aa2211">::</span><span class="n">activated</span><span class="p">),</span> <span style="color: #aa4000">this</span><span class="p">,</span> <span class="p">[</span><span style="color: #aa4000">this</span><span class="p">]</span> <span class="p">(</span><span style="color: #aa4000">unsigned</span> <span style="color: #aa4000">int</span> <span class="n">actionIndex</span><span class="p">)</span> <span class="p">{</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">        <span class="n">Q_EMIT</span> <span class="n">actionTriggered</span><span class="p">(</span><span class="n">m_internalId</span><span class="p">,</span> <span class="n">m_actions</span><span class="p">[</span><span class="n">actionIndex</span><span class="p">]);</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">    <span class="p">});</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Not sure if that can happen but it looks like you might clear <tt style="background: #ebebeb; font-size: 13px;">m_actions</tt> at a point where a notifications still shown and then <tt style="background: #ebebeb; font-size: 13px;">m_actions[actionIndex]</tt> would be out of bounds</p>

<p style="padding: 0; margin: 8px;">And also, like the previous comment, when "Reply" is added, the index shifts.</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D12293#inline-62418">View Inline</a><span style="color: #4b4d51; font-weight: bold;">notification.cpp:128</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; ">    <span style="color: #aa4000">if</span> <span class="p">(</span><span style="color: #aa2211">!</span><span class="n">m_requestReplyId</span><span class="p">.</span><span class="n">isEmpty</span><span class="p">())</span> <span class="p">{</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);">        <span class="n">m_<span class="bright">notification</span></span><span class="bright"></span><span style="color: #aa2211"><span class="bright">-></span></span><span class="bright"></span><span class="n"><span class="bright">setA</span>ctions<span class="bright"></span></span><span class="bright"></span><span class="p"><span class="bright">(</span></span><span class="bright"></span><span class="n"><span class="bright">QStringList</span></span><span class="p">(</span><span class="n">i18n</span><span class="p">(</span><span style="color: #766510">"Reply"<span class="bright"></span></span><span class="bright"></span><span class="p"><span class="bright">)</span>));</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">        <span class="n">m_<span class="bright">a</span>ctions<span class="bright"></span></span><span class="bright"></span><span class="p"><span class="bright">.</span></span><span class="bright"></span><span class="n"><span class="bright">prepend</span></span><span class="p">(</span><span class="n">i18n</span><span class="p">(</span><span style="color: #766510">"Reply"</span><span class="p">));</span>
</div><div style="padding: 0 8px; margin: 0 4px; ">        <span class="n">connect</span><span class="p">(</span><span class="n">m_notification</span><span class="p">,</span> <span style="color: #aa2211">&</span><span class="n">KNotification</span><span style="color: #aa2211">::</span><span class="n">action1Activated</span><span class="p">,</span> <span style="color: #aa4000">this</span><span class="p">,</span> <span style="color: #aa2211">&</span><span class="n">Notification</span><span style="color: #aa2211">::</span><span class="n">reply</span><span class="p">);</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">You change <tt style="background: #ebebeb; font-size: 13px;">m_actions</tt> after having called <tt style="background: #ebebeb; font-size: 13px;">setActions()</tt> above</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D12293#inline-62420">View Inline</a><span style="color: #4b4d51; font-weight: bold;">notification.cpp:132</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; color: #888888;">(Empty.)</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Whitespace</p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R224 KDE Connect</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D12293">https://phabricator.kde.org/D12293</a></div></div><br /><div><strong>To: </strong>nicolasfella, KDE Connect<br /><strong>Cc: </strong>broulik, mtijink, KDE Connect, yannux, Danial0_0, johnq, Pitel, adeen-s, SemperPeritus, ahmedbesbes, ndavis, daniel.z.tg, jeanv, seebauer, bugzy, MayeulC, menasshock, ach, apol<br /></div>