<table><tr><td style="">nicolasfella requested changes to this revision.<br />nicolasfella added a comment.<br />This revision now requires changes to proceed.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D11684">View Revision</a></tr></table><br /><div><div><p>Please apply</p>

<div class="remarkup-code-block" style="margin: 12px 0;" data-code-lang="diff" data-sigil="remarkup-code-block"><pre class="remarkup-code" style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; padding: 12px; margin: 0; background: rgba(71, 87, 120, 0.08);"><span style="color: #000080">diff --git a/CMakeLists.txt b/CMakeLists.txt</span>
<span style="color: #000080">index 4d5d0229..6ad7b225 100644</span>
<span style="color: #a00000">--- a/CMakeLists.txt</span>
<span style="color: #00a000">+++ b/CMakeLists.txt</span>
<span style="color: #800080">@@ -8,7 +8,7 @@ set(KDECONNECT_VERSION_PATCH 1)</span>
 set(KDECONNECT_VERSION "${KDECONNECT_VERSION_MAJOR}.${KDECONNECT_VERSION_MINOR}.${KDECONNECT_VERSION_PATCH}")
 
 set(QT_MIN_VERSION "5.7.0")
<span style="color: #a00000">-set(KF5_MIN_VERSION "5.42.0")</span>
<span style="color: #00a000">+set(KF5_MIN_VERSION "5.45.0")</span>
 
 find_package(ECM ${KF5_MIN_VERSION} REQUIRED NO_MODULE)
 set(CMAKE_MODULE_PATH ${ECM_MODULE_PATH} ${ECM_KDE_MODULE_DIR} ${CMAKE_SOURCE_DIR}/cmake)
<span style="color: #000080">diff --git a/plugins/runcommand/runcommandplugin.cpp b/plugins/runcommand/runcommandplugin.cpp</span>
<span style="color: #000080">index 41787a79..482501e4 100644</span>
<span style="color: #a00000">--- a/plugins/runcommand/runcommandplugin.cpp</span>
<span style="color: #00a000">+++ b/plugins/runcommand/runcommandplugin.cpp</span>
<span style="color: #800080">@@ -69,7 +69,7 @@ bool RunCommandPlugin::receivePacket(const NetworkPacket& np)</span>
         QProcess::startDetached(QStringLiteral("/bin/sh"), QStringList()<< QStringLiteral("-c") << commandJson[QStringLiteral("command")].toString());
         return true;
     } else if (np.has("setup")) {
<span style="color: #a00000">-        QProcess::startDetached(QStringLiteral("kcmshell5"), {QStringLiteral("--args"), QString(device()->id() + QStringLiteral(":kdeconnect_runcommand")) });</span>
<span style="color: #00a000">+        QProcess::startDetached(QStringLiteral("kcmshell5"), {QStringLiteral("kdeconnect"), QStringLiteral("--args"), QString(device()->id() + QStringLiteral(":kdeconnect_runcommand")) });</span>
     }
 
     return false;
<span style="color: #800080">@@ -85,6 +85,7 @@ void RunCommandPlugin::sendConfig()</span>
 {
     QString commands = config()->get<QString>(QStringLiteral("commands"),QStringLiteral("{}"));
     NetworkPacket np(PACKET_TYPE_RUNCOMMAND, {{"commandList", commands}});
<span style="color: #00a000">+    np.set<bool>(QStringLiteral("canAddCommand"), true);</span>
     sendPacket(np);
 }</pre></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R224 KDE Connect</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D11684">https://phabricator.kde.org/D11684</a></div></div><br /><div><strong>To: </strong>apol, KDE Connect, nicolasfella<br /><strong>Cc: </strong>nicolasfella, yannux, Danial0_0, johnq, Pitel, adeen-s, SemperPeritus, ahmedbesbes, ndavis, daniel.z.tg, jeanv, seebauer, bugzy, MayeulC, menasshock, ach, apol<br /></div>