<table><tr><td style="">mtijink added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D12294">View Revision</a></tr></table><br /><div><div><p>I think we should also send the action icon. That might be hard at the moment though, because we can only send one payload.</p></div></div><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D12294#inline-62185">View Inline</a><span style="color: #4b4d51; font-weight: bold;">NotificationsPlugin.java:77</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; "> <span style="color: #aa4000">private</span> <span class="n">Map</span><span style="color: #aa2211"><</span><span class="n">String</span><span style="color: #aa2211">,</span> <span class="n">RepliableNotification</span><span style="color: #aa2211">></span> <span class="n">pendingIntents</span><span style="color: #aa2211">;</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #aa4000">private</span> <span class="n">Map</span><span style="color: #aa2211"><</span><span class="n">String</span><span style="color: #aa2211">,</span> <span class="n">List</span><span style="color: #aa2211"><</span><span class="n">Notification</span><span style="color: #aa2211">.</span><span style="color: #354bb3">Action</span><span style="color: #aa2211">>></span> <span class="n">actions</span><span style="color: #aa2211">;</span>
</div><div style="padding: 0 8px; margin: 0 4px; "> <span style="color: #aa4000">private</span> <span style="color: #aa4000">boolean</span> <span class="n">serviceReady</span><span style="color: #aa2211">;</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Maybe it's good to refactor this into <tt style="background: #ebebeb; font-size: 13px;">Map<String, RemotelyAccessedNotification></tt> or similar.</p>
<p style="padding: 0; margin: 8px;"><tt style="background: #ebebeb; font-size: 13px;">RemotelyAccessedNotification</tt> can then contain the id, the available actions and reply intent.</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D12294#inline-62187">View Inline</a><span style="color: #4b4d51; font-weight: bold;">NotificationsPlugin.java:264</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="n">actions</span><span style="color: #aa2211">.</span><span style="color: #354bb3">put</span><span style="color: #aa2211">(</span><span class="n">key</span><span style="color: #aa2211">,</span> <span style="color: #aa4000">new</span> <span class="n">LinkedList</span><span style="color: #aa2211"><</span><span class="n">Notification</span><span style="color: #aa2211">.</span><span style="color: #354bb3">Action</span><span style="color: #aa2211">>());</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="n">JSONArray</span> <span class="n">jsonArray</span> <span style="color: #aa2211">=</span> <span style="color: #aa4000">new</span> <span class="n">JSONArray</span><span style="color: #aa2211">();</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #aa4000">for</span> <span style="color: #aa2211">(</span><span class="n">Notification</span><span style="color: #aa2211">.</span><span style="color: #354bb3">Action</span> <span class="n">action</span> <span style="color: #aa2211">:</span> <span class="n">notification</span><span style="color: #aa2211">.</span><span style="color: #354bb3">actions</span><span style="color: #aa2211">)</span> <span style="color: #aa2211">{</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">I think renaming to <tt style="background: #ebebeb; font-size: 13px;">actionsJson</tt> is clearer.</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D12294#inline-62186">View Inline</a><span style="color: #4b4d51; font-weight: bold;">NotificationsPlugin.java:267</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #aa4000">if</span> <span style="color: #aa2211">(</span><span style="color: #000a65">null</span> <span style="color: #aa2211">==</span> <span class="n">action</span><span style="color: #aa2211">.</span><span style="color: #354bb3">title</span><span style="color: #aa2211">)</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #aa4000">break</span><span style="color: #aa2211">;</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="n">Log</span><span style="color: #aa2211">.</span><span style="color: #354bb3">d</span><span style="color: #aa2211">(</span><span class="n">TAG</span><span style="color: #aa2211">,</span> <span class="n">action</span><span style="color: #aa2211">.</span><span style="color: #354bb3">title</span><span style="color: #aa2211">.</span><span style="color: #354bb3">toString</span><span style="color: #aa2211">());</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Maybe if a single title is missing, don't send any actions? Otherwise, this can be confusing.</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D12294#inline-62188">View Inline</a><span style="color: #4b4d51; font-weight: bold;">NotificationsPlugin.java:273</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="n">np</span><span style="color: #aa2211">.</span><span style="color: #354bb3">set</span><span style="color: #aa2211">(</span><span style="color: #766510">"actions"</span><span style="color: #aa2211">,</span> <span class="n">jsonArray</span><span style="color: #aa2211">);</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="n">Log</span><span style="color: #aa2211">.</span><span style="color: #354bb3">d</span><span style="color: #aa2211">(</span><span class="n">TAG</span><span style="color: #aa2211">,</span> <span class="n">np</span><span style="color: #aa2211">.</span><span style="color: #354bb3">getString</span><span style="color: #aa2211">(</span><span style="color: #766510">"actions"</span><span style="color: #aa2211">));</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #aa2211">}</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Double <tt style="background: #ebebeb; font-size: 13px;">Log</tt> (with line 268), I'd remove at least one of them.</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D12294#inline-62189">View Inline</a><span style="color: #4b4d51; font-weight: bold;">NotificationsPlugin.java:508</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #aa2211">}</span> <span style="color: #aa4000">catch</span> <span style="color: #aa2211">(</span><span class="n">PendingIntent</span><span style="color: #aa2211">.</span><span style="color: #354bb3">CanceledException</span> <span class="n">e</span><span style="color: #aa2211">)</span> <span style="color: #aa2211">{</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="n">e</span><span style="color: #aa2211">.</span><span style="color: #354bb3">printStackTrace</span><span style="color: #aa2211">();</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #aa2211">}</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Something like <tt style="background: #ebebeb; font-size: 13px;">Log.e(TAG, "Firing action for notification failed", e)</tt> is better in general (colors the stacktrace etc., actually labels it as an error).</p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R225 KDE Connect - Android application</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D12294">https://phabricator.kde.org/D12294</a></div></div><br /><div><strong>To: </strong>nicolasfella, KDE Connect<br /><strong>Cc: </strong>mtijink, KDE Connect, yannux, Danial0_0, johnq, Pitel, adeen-s, SemperPeritus, ahmedbesbes, ndavis, daniel.z.tg, jeanv, seebauer, bugzy, MayeulC, menasshock, ach, apol<br /></div>