<table><tr><td style="">mtijink added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D11694">View Revision</a></tr></table><br /><div><div><p>I don't like some of the new changes. I understand this is all opinions, so we can't have everything, but I think that the following things are especially bad changes:</p>
<ul class="remarkup-list">
<li class="remarkup-list-item">The sidebar navigation should be visually distinct from the main view. In the light view, the main view is shaded and the sidebar has a drop shadow, we could do that here too. Or, if not possible, we should change the sidebar color.</li>
<li class="remarkup-list-item">The dark-orange toolbar doesn't match the other places where the orange color is used. I'd say they should be different hues or be exactly the same color. So either bright orange or black-ish, as <a href="https://phabricator.kde.org/p/nicolasfella/" style="
border-color: #f1f7ff;
color: #19558d;
background-color: #f1f7ff;
border: 1px solid transparent;
border-radius: 3px;
font-weight: bold;
padding: 0 4px;">@nicolasfella</a> suggested.</li>
</ul>
<p>Finally, a remark about black saving energy: KDE Connect is mostly a background app, so saving energy isn't that important. I'd prefer a grey background myself, but I guess other people like black more.</p></div></div><br /><div><strong>REPOSITORY</strong><div><div>R225 KDE Connect - Android application</div></div></div><br /><div><strong>BRANCH</strong><div><div>feature/dark-theme</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D11694">https://phabricator.kde.org/D11694</a></div></div><br /><div><strong>To: </strong>philipc, KDE Connect, mtijink, VDG<br /><strong>Cc: </strong>ngraham, nicolasfella, mtijink, yannux, Danial0_0, johnq, Pitel, adeen-s, SemperPeritus, ahmedbesbes, ndavis, daniel.z.tg, jeanv, seebauer, bugzy, MayeulC, menasshock, ach, apol<br /></div>