<table><tr><td style="">mtijink added inline comments.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D11698">View Revision</a></tr></table><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D11698#inline-58425">View Inline</a><span style="color: #4b4d51; font-weight: bold;">SMSHelper.java:44</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"><span style="color: #74777d">     */</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">    <span style="color: #aa4000">protected</span> <span style="color: #aa4000">static</span> <span class="n">Uri</span> <span style="color: #004012">getSMSURIBad</span><span style="color: #aa2211">()</span> <span style="color: #aa2211">{</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">        <span style="color: #aa4000">return</span> <span class="n">Uri</span><span style="color: #aa2211">.</span><span style="color: #354bb3">parse</span><span style="color: #aa2211">(</span><span style="color: #766510">"content://sms/"</span><span style="color: #aa2211">);</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;"><tt style="background: #ebebeb; font-size: 13px;">getSMSURIBad</tt>? I think <tt style="background: #ebebeb; font-size: 13px;">getSMSURIBase</tt> is more logical. Also, these can easily be inlined in the <tt style="background: #ebebeb; font-size: 13px;">getSMSUri</tt> function.</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D11698#inline-58426">View Inline</a><span style="color: #4b4d51; font-weight: bold;">SMSHelper.java:76</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"><span style="color: #74777d">     */</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">    <span style="color: #aa4000">public</span> <span style="color: #aa4000">static</span> <span class="n">Map</span><span style="color: #aa2211"><</span><span class="n">String</span><span style="color: #aa2211">,</span> <span class="n">List</span><span style="color: #aa2211"><</span><span class="n">Map</span><span style="color: #aa2211"><</span><span class="n">String</span><span style="color: #aa2211">,</span> <span class="n">String</span><span style="color: #aa2211">>>></span> <span style="color: #004012">getSMS</span><span style="color: #aa2211">(</span><span class="n">Context</span> <span class="n">context</span><span style="color: #aa2211">)</span> <span style="color: #aa2211">{</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">        <span class="n">HashMap</span><span style="color: #aa2211"><</span><span class="n">String</span><span style="color: #aa2211">,</span> <span class="n">List</span><span style="color: #aa2211"><</span><span class="n">Map</span><span style="color: #aa2211"><</span><span class="n">String</span><span style="color: #aa2211">,</span> <span class="n">String</span><span style="color: #aa2211">>>></span> <span class="n">toReturn</span> <span style="color: #aa2211">=</span> <span style="color: #aa4000">new</span> <span class="n">HashMap</span><span style="color: #aa2211"><>();</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">The return type could use some improvements. I'd suggest a data class holding these result with logical names.</p>

<p style="padding: 0; margin: 8px;">Also, <tt style="background: #ebebeb; font-size: 13px;">getSMS</tt> is not really discriptive for what the function actually does (getting SMS threads).</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D11698#inline-58427">View Inline</a><span style="color: #4b4d51; font-weight: bold;">SMSHelper.java:103</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">                <span style="color: #aa4000">if</span> <span style="color: #aa2211">(!</span> <span class="n">toReturn</span><span style="color: #aa2211">.</span><span style="color: #354bb3">containsKey</span><span style="color: #aa2211">(</span><span class="n">thread</span><span style="color: #aa2211">))</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">                <span style="color: #aa2211">{</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">                    <span class="n">toReturn</span><span style="color: #aa2211">.</span><span style="color: #354bb3">put</span><span style="color: #aa2211">(</span><span class="n">thread</span><span style="color: #aa2211">,</span> <span style="color: #aa4000">new</span> <span class="n">ArrayList</span><span style="color: #aa2211"><</span><span class="n">Map</span><span style="color: #aa2211"><</span><span class="n">String</span><span style="color: #aa2211">,</span> <span class="n">String</span><span style="color: #aa2211">>>());</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Android coding style.</p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R225 KDE Connect - Android application</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D11698">https://phabricator.kde.org/D11698</a></div></div><br /><div><strong>To: </strong>sredman<br /><strong>Cc: </strong>mtijink, KDE Connect, adeen-s, SemperPeritus, ahmedbesbes, daniel.z.tg, jeanv, seebauer, bugzy, MayeulC, menasshock, ach, apol<br /></div>