<table><tr><td style="">mtijink requested changes to this revision.<br />mtijink added a comment.<br />This revision now requires changes to proceed.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D7992">View Revision</a></tr></table><br /><div><div><p>Looks good. Is depending on PulseAudioQt okay already?</p></div></div><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D7992#inline-57633">View Inline</a><span style="color: #4b4d51; font-weight: bold;">systemvolumeplugin.cpp:62</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"><span class="p">{</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #aa4000">if</span> <span class="p">(</span><span class="n">np</span><span class="p">.</span><span class="n">type</span><span class="p">()</span> <span style="color: #aa2211">==</span> <span class="n">PACKET_TYPE_SYSTEMVOLUME</span><span class="p">)</span> <span class="p">{</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Do we need to check the packet type here? We already know it's destined for this plugin.</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D7992#inline-57634">View Inline</a><span style="color: #4b4d51; font-weight: bold;">systemvolumeplugin.cpp:69</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="p">}</span> <span style="color: #aa4000">else</span> <span style="color: #aa4000">if</span> <span class="p">(</span><span class="n">np</span><span class="p">.</span><span class="n">has</span><span class="p">(</span><span class="n">QStringLiteral</span><span class="p">(</span><span style="color: #766510">"volume"</span><span class="p">)))</span> <span class="p">{</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="n">sinksMap</span><span class="p">[</span><span class="n">np</span><span class="p">.</span><span class="n">get</span><span style="color: #aa2211"><</span><span class="n">QString</span><span style="color: #aa2211">></span><span class="p">(</span><span class="n">QStringLiteral</span><span class="p">(</span><span style="color: #766510">"name"</span><span class="p">))]</span><span style="color: #aa2211">-></span><span class="n">setVolume</span><span class="p">(</span><span class="n">np</span><span class="p">.</span><span class="n">get</span><span style="color: #aa2211"><</span><span style="color: #aa4000">int</span><span style="color: #aa2211">></span><span class="p">(</span><span class="n">QStringLiteral</span><span class="p">(</span><span style="color: #766510">"volume"</span><span class="p">)));</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="p">}</span> <span style="color: #aa4000">else</span> <span style="color: #aa4000">if</span> <span class="p">(</span><span class="n">np</span><span class="p">.</span><span class="n">has</span><span class="p">(</span><span class="n">QStringLiteral</span><span class="p">(</span><span style="color: #766510">"muted"</span><span class="p">)))</span> <span class="p">{</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Needs a check to see if the requested sink still exists.</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D7992#inline-57635">View Inline</a><span style="color: #4b4d51; font-weight: bold;">systemvolumeplugin.cpp:72</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="n">qCDebug</span><span class="p">(</span><span class="n">KDECONNECT_PLUGIN_SYSTEMVOLUME</span><span class="p">)</span> <span style="color: #aa2211"><<</span> <span style="color: #766510">"set muted"</span> <span style="color: #aa2211"><<</span> <span class="n">np</span><span class="p">.</span><span class="n">get</span><span style="color: #aa2211"><</span><span style="color: #aa4000">bool</span><span style="color: #aa2211">></span><span class="p">(</span><span class="n">QStringLiteral</span><span class="p">(</span><span style="color: #766510">"muted"</span><span class="p">));</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="n">sinksMap</span><span class="p">[</span><span class="n">np</span><span class="p">.</span><span class="n">get</span><span style="color: #aa2211"><</span><span class="n">QString</span><span style="color: #aa2211">></span><span class="p">(</span><span class="n">QStringLiteral</span><span class="p">(</span><span style="color: #766510">"name"</span><span class="p">))]</span><span style="color: #aa2211">-></span><span class="n">setMuted</span><span class="p">(</span><span class="n">np</span><span class="p">.</span><span class="n">get</span><span style="color: #aa2211"><</span><span style="color: #aa4000">bool</span><span style="color: #aa2211">></span><span class="p">(</span><span class="n">QStringLiteral</span><span class="p">(</span><span style="color: #766510">"muted"</span><span class="p">)));</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="p">}</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Same here.</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D7992#inline-57637">View Inline</a><span style="color: #4b4d51; font-weight: bold;">systemvolumeplugin.cpp:93</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="n">connect</span><span class="p">(</span><span class="n">sink</span><span class="p">,</span> <span style="color: #aa2211">&</span><span class="n">QPulseAudio</span><span style="color: #aa2211">::</span><span class="n">Sink</span><span style="color: #aa2211">::</span><span class="n">volumeChanged</span><span class="p">,</span> <span style="color: #aa4000">this</span><span class="p">,</span> <span class="p">[</span><span style="color: #aa4000">this</span><span class="p">,</span> <span class="n">sink</span><span class="p">]</span> <span class="p">{</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="n">NetworkPacket</span> <span class="n">np</span><span class="p">(</span><span class="n">PACKET_TYPE_SYSTEMVOLUME</span><span class="p">);</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">What happens if we already had that sink? Do we connect to this signal twice?</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D7992#inline-57638">View Inline</a><span style="color: #4b4d51; font-weight: bold;">systemvolumeplugin.cpp:131</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="n">QPulseAudio</span><span style="color: #aa2211">::</span><span class="n">Sink</span><span style="color: #aa2211">*</span> <span class="n">sink</span> <span style="color: #aa2211">=</span> <span class="n">i</span><span class="p">.</span><span class="n">value</span><span class="p">();</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="n">sinksMap</span><span class="p">.</span><span class="n">insert</span><span class="p">(</span><span class="n">sink</span><span style="color: #aa2211">-></span><span class="n">name</span><span class="p">(),</span> <span class="n">sink</span><span class="p">);</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="p">}</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">This code doesn't connect to the signals, so that's not correct, right?</p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R224 KDE Connect</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D7992">https://phabricator.kde.org/D7992</a></div></div><br /><div><strong>To: </strong>nicolasfella, KDE Connect, mtijink<br /><strong>Cc: </strong>zhigalin, albertvaka, davidedmundson, mtijink, KDE Connect, adeen-s, SemperPeritus, ahmedbesbes, daniel.z.tg, jeanv, seebauer, bugzy, MayeulC, menasshock, ach, apol<br /></div>