<table><tr><td style="">mtijink added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D7959" rel="noreferrer">View Revision</a></tr></table><br /><div><div><p>Works good, but I still have some comments.</p></div></div><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D7959#inline-44994" rel="noreferrer">View Inline</a><span style="color: #4b4d51; font-weight: bold;">addcommanddialog.xml:17</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #00702a"><EditText</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #354bb3">android:id=</span><span style="color: #766510">"@+id/addcommand_name"</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">I'd add some margin to these fields. The android docs use <tt style="background: #ebebeb; font-size: 13px;">4dp</tt>.</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D7959#inline-44996" rel="noreferrer">View Inline</a><span style="color: #4b4d51; font-weight: bold;">menu_runcommand.xml:1</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"><span style="color: #00702a"><menu</span> <span style="color: #354bb3">xmlns:android=</span><span style="color: #766510">"http://schemas.android.com/apk/res/android"</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #354bb3">xmlns:app=</span><span style="color: #766510">"http://schemas.android.com/apk/res-auto"</span><span style="color: #00702a">></span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Can we use a Floating-Action-Button instead of a menu button? Or did you specifically choose the menu button?</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D7959#inline-44997" rel="noreferrer">View Inline</a><span style="color: #4b4d51; font-weight: bold;">menu_runcommand.xml:5</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #354bb3">android:id=</span><span style="color: #766510">"@+id/action_addcommand"</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #354bb3">android:icon=</span><span style="color: #766510">"@drawable/ic_add_white_48dp"</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #354bb3">app:theme=</span><span style="color: #766510">"@style/ThemeOverlay.AppCompat.Dark.ActionBar"</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Can you use the vector asset instead?</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D7959#inline-44989" rel="noreferrer">View Inline</a><span style="color: #4b4d51; font-weight: bold;">AddCommandDialog.java:39</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="n">builder</span><span style="color: #aa2211">.</span><span style="color: #354bb3">setPositiveButton</span><span style="color: #aa2211">(</span><span class="n">R</span><span style="color: #aa2211">.</span><span style="color: #354bb3">string</span><span style="color: #aa2211">.</span><span style="color: #354bb3">ok</span><span style="color: #aa2211">,</span> <span style="color: #aa4000">new</span> <span class="n">DialogInterface</span><span style="color: #aa2211">.</span><span style="color: #354bb3">OnClickListener</span><span style="color: #aa2211">()</span> <span style="color: #aa2211">{</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #aa4000">public</span> <span style="color: #aa4000">void</span> <span style="color: #004012">onClick</span><span style="color: #aa2211">(</span><span class="n">DialogInterface</span> <span class="n">dialog</span><span style="color: #aa2211">,</span> <span style="color: #aa4000">int</span> <span class="n">id</span><span style="color: #aa2211">)</span> <span style="color: #aa2211">{</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Would it be possible to disable the <tt style="background: #ebebeb; font-size: 13px;">ok</tt> button while either input field is still empty?</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D7959#inline-44988" rel="noreferrer">View Inline</a><span style="color: #4b4d51; font-weight: bold;">AddCommandDialog.java:53</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #aa4000">public</span> <span style="color: #aa4000">void</span> <span style="color: #004012">onClick</span><span style="color: #aa2211">(</span><span class="n">DialogInterface</span> <span class="n">dialog</span><span style="color: #aa2211">,</span> <span style="color: #aa4000">int</span> <span class="n">id</span><span style="color: #aa2211">)</span> <span style="color: #aa2211">{</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #aa4000">if</span><span style="color: #aa2211">(</span><span class="n">getActivity</span><span style="color: #aa2211">()</span> <span style="color: #aa4000">instanceof</span> <span class="n">RunCommandActivity</span><span style="color: #aa2211">){</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Why is this empty <tt style="background: #ebebeb; font-size: 13px;">if</tt> here?</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D7959#inline-44986" rel="noreferrer">View Inline</a><span style="color: #4b4d51; font-weight: bold;">RunCommandActivity.java:52</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; "> <span style="color: #aa4000">private</span> <span class="n">String</span> <span class="n">deviceId</span><span style="color: #aa2211">;</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #aa4000">private</span> <span style="color: #aa4000">final</span> <span class="n">RunCommandPlugin</span><span style="color: #aa2211">.</span><span style="color: #354bb3">CommandsChangedCallback</span> <span class="n">theCallback</span> <span style="color: #aa2211">=</span> <span style="color: #aa4000">new</span> <span class="n">RunCommandPlugin</span><span style="color: #aa2211">.</span><span style="color: #354bb3">CommandsChangedCallback</span><span style="color: #aa2211">()</span> <span style="color: #aa2211">{</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #aa22ff">@Override</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;"><tt style="background: #ebebeb; font-size: 13px;">theCallback</tt> is a weird name, I'd suggest <tt style="background: #ebebeb; font-size: 13px;">addCommandDialogCallback</tt> or similar.</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D7959#inline-44992" rel="noreferrer">View Inline</a><span style="color: #4b4d51; font-weight: bold;">RunCommandPlugin.java:141</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; "> <span style="color: #aa4000">public</span> <span style="color: #aa4000">boolean</span> <span style="color: #004012">hasMainActivity</span><span style="color: #aa2211">()</span> <span style="color: #aa2211">{</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);"> <span style="color: #aa4000">return</span> <span class="bright"></span><span style="color: #aa2211"><span class="bright">!</span></span><span class="bright"></span><span class="n"><span class="bright">commandList</span></span><span class="bright"></span><span style="color: #aa2211"><span class="bright">.</span></span><span class="bright"></span><span style="color: #354bb3"><span class="bright">isEmpty</span></span><span class="bright"></span><span style="color: #aa2211"><span class="bright">()</span>;</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #aa4000">return</span> <span class="bright"></span><span style="color: #000a65"><span class="bright">true</span></span><span style="color: #aa2211">;</span>
</div><div style="padding: 0 8px; margin: 0 4px; "> <span style="color: #aa2211">}</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">So if the desktop does not support remotely adding commands, the (empty) activity still appears, without anything to do. Can we hide it in that case, or add a text displaying how to add commands on the desktop?</p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R225 KDE Connect - Android application</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D7959" rel="noreferrer">https://phabricator.kde.org/D7959</a></div></div><br /><div><strong>To: </strong>nicolasfella, KDE Connect<br /><strong>Cc: </strong>mtijink, KDE Connect, SemperPeritus, ahmedbesbes, daniel.z.tg, jeanv, tfella, aboudhar, seebauer, bugzy, progwolff, MayeulC, menasshock, ach, apol<br /></div>