<table><tr><td style="">mtijink added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D9690" rel="noreferrer">View Revision</a></tr></table><br /><div><div><p>Looks promising (didn't test it though), so I added a few initial comments. It's best if you think what <em>you</em> want to use it for. Otherwise you're implementing something which may never be used, or is unsuitable for an use case.</p></div></div><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D9690#inline-44476" rel="noreferrer">View Inline</a><span style="color: #4b4d51; font-weight: bold;">ContactsPlugin.java:106</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #74777d">// The reply is formatted as a series of:</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #74777d">// <int>: Name, Category, Number</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #74777d">// Where int is a unique (incrementing) integer,</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Two things: wouldn't it make more sense to keep the structure of the Android contacts (i.e. multiple numbers for one contact, so only send the name once)?</p>
<p style="padding: 0; margin: 8px;">And the index is never used (and does not uniquely correspond to a single contact), so you don't need to send it.</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D9690#inline-44472" rel="noreferrer">View Inline</a><span style="color: #4b4d51; font-weight: bold;">ContactsPlugin.java:140</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #aa4000">int</span> <span class="n">nameIndex</span> <span style="color: #aa2211">=</span> <span class="n">contactsCursor</span><span style="color: #aa2211">.</span><span style="color: #354bb3">getColumnIndex</span><span style="color: #aa2211">(</span><span class="n">ContactsContract</span><span style="color: #aa2211">.</span><span style="color: #354bb3">Contacts</span><span style="color: #aa2211">.</span><span style="color: #354bb3">DISPLAY_NAME</span><span style="color: #aa2211">);</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Can you separate this into a new function? Then we can reuse this stuff no matter how we query the contacts database (e.g. searching, single contacts, etc.) in the future.</p>
<p style="padding: 0; margin: 8px;">Also, some more comments what's happening here would be useful: not everyone has experience with ContentProvider code.</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D9690#inline-44471" rel="noreferrer">View Inline</a><span style="color: #4b4d51; font-weight: bold;">ContactsPlugin.java:169</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #aa2211">,</span> <span class="n">ContactsContract</span><span style="color: #aa2211">.</span><span style="color: #354bb3">CommonDataKinds</span><span style="color: #aa2211">.</span><span style="color: #354bb3">Phone</span><span style="color: #aa2211">.</span><span style="color: #354bb3">NUMBER</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #aa2211">,</span> <span class="n">ContactsContract</span><span style="color: #aa2211">.</span><span style="color: #354bb3">CommonDataKinds</span><span style="color: #aa2211">.</span><span style="color: #354bb3">Phone</span><span style="color: #aa2211">.</span><span style="color: #354bb3">TYPE</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #74777d">// Stores the label of the type of the number</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Maybe e-mail addresses are useful too?</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D9690#inline-44475" rel="noreferrer">View Inline</a><span style="color: #4b4d51; font-weight: bold;">ContactsPlugin.java:236</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #aa2211">{</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="n">Log</span><span style="color: #aa2211">.</span><span style="color: #354bb3">e</span><span style="color: #aa2211">(</span><span style="color: #766510">"ContactsPlugin"</span><span style="color: #aa2211">,</span> <span style="color: #766510">"Contacts plugin received an unexpected packet!"</span><span style="color: #aa2211">);</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #aa4000">return</span> <span style="color: #000a65">false</span><span style="color: #aa2211">;</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Maybe better to move this check to the beginning of the function: that improves readability and reduces indenting.</p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R225 KDE Connect - Android application</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D9690" rel="noreferrer">https://phabricator.kde.org/D9690</a></div></div><br /><div><strong>To: </strong>sredman, kdeconnect<br /><strong>Cc: </strong>mtijink<br /></div>