<table><tr><td style="">mtijink added inline comments.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D9548" rel="noreferrer">View Revision</a></tr></table><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D9548#inline-43642" rel="noreferrer">View Inline</a><span style="color: #4b4d51; font-weight: bold;">NotificationsPlugin.java:417</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);"> <span style="color: #aa4000">if</span> <span style="color: #aa2211">(</span><span class="n">Build</span><span style="color: #aa2211">.</span><span style="color: #354bb3">VERSION</span><span style="color: #aa2211">.</span><span style="color: #354bb3">SDK_INT</span> <span style="color: #aa2211">>=</span> <span class="n">Build</span><span style="color: #aa2211">.</span><span style="color: #354bb3">VERSION_CODES</span><span style="color: #aa2211">.</span><span style="color: #354bb3">JELLY_BEAN_MR2</span><span style="color: #aa2211">)</span>
</div><div style="padding: 0 8px; margin: 0 4px; "> <span class="n">NotificationReceiver</span><span style="color: #aa2211">.</span><span style="color: #354bb3">RunCommand</span><span style="color: #aa2211">(</span><span class="n">context</span><span style="color: #aa2211">,</span> <span style="color: #aa4000">new</span> <span class="n">NotificationReceiver</span><span style="color: #aa2211">.</span><span style="color: #354bb3">InstanceCallback</span><span style="color: #aa2211">()</span> <span style="color: #aa2211">{</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">This line shouldn't be removed, as it's a different version check than the other code.</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D9548#inline-43641" rel="noreferrer">View Inline</a><span style="color: #4b4d51; font-weight: bold;">NotificationsPlugin.java:453</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);"> <span style="color: #aa4000">if</span> <span style="color: #aa2211">(</span><span class="n">Build</span><span style="color: #aa2211">.</span><span style="color: #354bb3">VERSION</span><span style="color: #aa2211">.</span><span style="color: #354bb3">SDK_INT</span> <span style="color: #aa2211">>=</span> <span class="n">Build</span><span style="color: #aa2211">.</span><span style="color: #354bb3">VERSION_CODES</span><span style="color: #aa2211">.</span><span style="color: #354bb3">JELLY_BEAN_MR2</span><span style="color: #aa2211">)</span>
</div><div style="padding: 0 8px; margin: 0 4px; "> <span class="n">NotificationReceiver</span><span style="color: #aa2211">.</span><span style="color: #354bb3">RunCommand</span><span style="color: #aa2211">(</span><span class="n">context</span><span style="color: #aa2211">,</span> <span style="color: #aa4000">new</span> <span class="n">NotificationReceiver</span><span style="color: #aa2211">.</span><span style="color: #354bb3">InstanceCallback</span><span style="color: #aa2211">()</span> <span style="color: #aa2211">{</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Same here.</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D9548#inline-43643" rel="noreferrer">View Inline</a><span style="color: #4b4d51; font-weight: bold;">NotificationsPlugin.java:462</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #aa4000">if</span> <span style="color: #aa2211">(</span><span class="n">Build</span><span style="color: #aa2211">.</span><span style="color: #354bb3">VERSION</span><span style="color: #aa2211">.</span><span style="color: #354bb3">SDK_INT</span> <span style="color: #aa2211">>=</span> <span class="n">Build</span><span style="color: #aa2211">.</span><span style="color: #354bb3">VERSION_CODES</span><span style="color: #aa2211">.</span><span style="color: #354bb3">KITKAT_WATCH</span><span style="color: #aa2211">)</span> <span style="color: #aa2211">{</span>
</div><div style="padding: 0 8px; margin: 0 4px; "> <span class="n">replyToNotification</span><span style="color: #aa2211">(</span><span class="n">np</span><span style="color: #aa2211">.</span><span style="color: #354bb3">getString</span><span style="color: #aa2211">(</span><span style="color: #766510">"requestReplyId"</span><span style="color: #aa2211">),</span> <span class="n">np</span><span style="color: #aa2211">.</span><span style="color: #354bb3">getString</span><span style="color: #aa2211">(</span><span style="color: #766510">"message"</span><span style="color: #aa2211">));</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Why was this version check introduced? That version is already required by the <tt style="background: #ebebeb; font-size: 13px;">@RequiresApi</tt> annotation.</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D9548#inline-43645" rel="noreferrer">View Inline</a><span style="color: #4b4d51; font-weight: bold;">NotificationsPlugin.java:574</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #aa4000">public</span> <span style="color: #aa4000">int</span> <span style="color: #004012">getMinSdk</span><span style="color: #aa2211">()</span> <span style="color: #aa2211">{</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #aa4000">return</span> <span class="n">Build</span><span style="color: #aa2211">.</span><span style="color: #354bb3">VERSION_CODES</span><span style="color: #aa2211">.</span><span style="color: #354bb3">JELLY_BEAN_MR2</span><span style="color: #aa2211">;</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #aa2211">}</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Why Jelly Bean? As I understand the code, it should work with Kitkat.</p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R225 KDE Connect - Android application</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D9548" rel="noreferrer">https://phabricator.kde.org/D9548</a></div></div><br /><div><strong>To: </strong>nicolasfella, KDE Connect<br /><strong>Cc: </strong>mtijink, KDE Connect, SemperPeritus, ahmedbesbes, daniel.z.tg, jeanv, tfella, aboudhar, seebauer, bugzy, progwolff, MayeulC, menasshock, ach, apol<br /></div>