<table><tr><td style="">nicolasfella added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D9564" rel="noreferrer">View Revision</a></tr></table><br /><div><div><p>A propse:</p>
<p>With the limited Spotify controls:<br />
<a href="https://phabricator.kde.org/F5614171" style="background-color: #e7e7e7;
border-color: #e7e7e7;
border-radius: 3px;
padding: 0 4px;
font-weight: bold;
color: black;text-decoration: none;" rel="noreferrer">F5614171: Screenshot_20180102-204527.jpg</a></p>
<p>With full controls:<br />
<a href="https://phabricator.kde.org/F5614195" style="background-color: #e7e7e7;
border-color: #e7e7e7;
border-radius: 3px;
padding: 0 4px;
font-weight: bold;
color: black;text-decoration: none;" rel="noreferrer">F5614195: Screenshot_20180102-204342.jpg</a></p>
<p>Without artwork:<br />
<a href="https://phabricator.kde.org/F5614200" style="background-color: #e7e7e7;
border-color: #e7e7e7;
border-radius: 3px;
padding: 0 4px;
font-weight: bold;
color: black;text-decoration: none;" rel="noreferrer">F5614200: Screenshot_20180102-210619.jpg</a></p>
<p>The artwork has a fixed aspect ratio. In the first image the artwork uses the full width leaving space at the bottom. In the second image the height of the screen is fully used resulting in the artwork not using the full width.</p>
<p>This is generated by the following activity_mpris.xml:</p>
<div class="remarkup-code-block" style="margin: 12px 0;" data-code-lang="text" data-sigil="remarkup-code-block"><pre class="remarkup-code" style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; padding: 12px; margin: 0; background: rgba(71, 87, 120, 0.08);"><?xml version="1.0" encoding="utf-8"?>
<LinearLayout
xmlns:android="http://schemas.android.com/apk/res/android"
android:orientation="vertical"
android:paddingLeft="25dp"
android:paddingTop="25dip"
android:paddingRight="25dip"
android:paddingBottom="15dip"
android:layout_width="match_parent"
android:layout_height="match_parent"
android:gravity="center_vertical">
<ImageView
android:id="@+id/album_art"
android:layout_width="match_parent"
android:layout_height="0dp"
android:layout_weight="1"
android:layout_marginBottom="25dip"
android:scaleType="fitCenter" />
<include
android:layout_width="match_parent"
android:layout_height="wrap_content"
layout="@layout/mpris_control" />
</LinearLayout></pre></div></div></div><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D9564#inline-43534" rel="noreferrer">View Inline</a><span style="color: #4b4d51; font-weight: bold;">MprisActivity.java:203</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #aa4000">if</span> <span style="color: #aa2211">(</span><span class="n">albumArt</span> <span style="color: #aa2211">==</span> <span style="color: #000a65">null</span><span style="color: #aa2211">)</span> <span style="color: #aa2211">{</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="n">findViewById</span><span style="color: #aa2211">(</span><span class="n">R</span><span style="color: #aa2211">.</span><span style="color: #354bb3">id</span><span style="color: #aa2211">.</span><span style="color: #354bb3">album_art</span><span style="color: #aa2211">).</span><span style="color: #354bb3">setVisibility</span><span style="color: #aa2211">(</span><span class="n">View</span><span style="color: #aa2211">.</span><span style="color: #354bb3">INVISIBLE</span><span style="color: #aa2211">);</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #aa2211">((</span><span class="n">ImageView</span><span style="color: #aa2211">)</span> <span class="n">findViewById</span><span style="color: #aa2211">(</span><span class="n">R</span><span style="color: #aa2211">.</span><span style="color: #354bb3">id</span><span style="color: #aa2211">.</span><span style="color: #354bb3">album_art</span><span style="color: #aa2211">)).</span><span style="color: #354bb3">setImageBitmap</span><span style="color: #aa2211">(</span><span style="color: #000a65">null</span><span style="color: #aa2211">);</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">View.GONE works better with my suggestion</p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R225 KDE Connect - Android application</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D9564" rel="noreferrer">https://phabricator.kde.org/D9564</a></div></div><br /><div><strong>To: </strong>mtijink, KDE Connect, VDG<br /><strong>Cc: </strong>ngraham, nicolasfella, apol<br /></div>