<table><tr><td style="">thomasp added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D8942" rel="noreferrer">View Revision</a></tr></table><br /><div><div><p>I think you should give <tt style="background: #ebebeb; font-size: 13px;">MprisPlayer</tt> a reference to <tt style="background: #ebebeb; font-size: 13px;">MprisPlugin</tt> and move the setters into <tt style="background: #ebebeb; font-size: 13px;">MprisPlayer</tt> too.<br />
Then change <tt style="background: #ebebeb; font-size: 13px;">MprisActivity.targetPlayer</tt> to be a <tt style="background: #ebebeb; font-size: 13px;">MprisPlayer</tt>.</p>

<p>Otherwise this looks like an improvement. Just my 2 cents.</p></div></div><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D8942#inline-40534" rel="noreferrer">View Inline</a><span style="color: #4b4d51; font-weight: bold;">MprisActivity.java:156</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; ">                                <span style="color: #aa2211">}</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">                                <span style="color: #aa4000">if</span> <span style="color: #aa2211">((</span><span class="n">targetPlayer</span> <span style="color: #aa2211">==</span> <span style="color: #000a65">null</span> <span style="color: #aa2211">&&</span> <span class="n">selectedPlayer</span> <span style="color: #aa2211">!=</span> <span style="color: #000a65">null</span><span style="color: #aa2211">)</span> <span style="color: #aa2211">||</span> <span style="color: #aa2211">(</span><span class="n">targetPlayer</span> <span style="color: #aa2211">!=</span> <span style="color: #000a65">null</span> <span style="color: #aa2211">&&</span> <span style="color: #aa2211">!</span><span class="n">targetPlayer</span><span style="color: #aa2211">.</span><span style="color: #354bb3">equals</span><span style="color: #aa2211">(</span><span class="n">selectedPlayer</span><span style="color: #aa2211">)))</span> <span style="color: #aa2211">{</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">                                    <span class="n">targetPlayer</span> <span style="color: #aa2211">=</span> <span class="n">selectedPlayer</span><span style="color: #aa2211">;</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;"><tt style="background: #ebebeb; font-size: 13px;">targetPlayer</tt> is always <tt style="background: #ebebeb; font-size: 13px;">null</tt> here. Please simplify beginning from line 143.</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D8942#inline-40533" rel="noreferrer">View Inline</a><span style="color: #4b4d51; font-weight: bold;">MprisActivity.java:207</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">        <span style="color: #74777d">//Hacks for Spotify because it reports incorrect info about what it supports</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">        <span style="color: #aa4000">boolean</span> <span class="n">isSpotify</span> <span style="color: #aa2211">=</span> <span style="color: #766510">"spotify"</span><span style="color: #aa2211">.</span><span style="color: #354bb3">equals</span><span style="color: #aa2211">(</span><span class="n">playerStatus</span><span style="color: #aa2211">.</span><span style="color: #354bb3">getPlayer</span><span style="color: #aa2211">().</span><span style="color: #354bb3">toLowerCase</span><span style="color: #aa2211">());</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;"><tt style="background: #ebebeb; font-size: 13px;">MprisPlayer</tt> could report correct info.</p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R225 KDE Connect - Android application</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D8942" rel="noreferrer">https://phabricator.kde.org/D8942</a></div></div><br /><div><strong>To: </strong>mtijink, KDE Connect<br /><strong>Cc: </strong>thomasp<br /></div>