<table><tr><td style="">thomasp added inline comments.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D7146" rel="noreferrer">View Revision</a></tr></table><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D7146#inline-29138" rel="noreferrer">View Inline</a><span style="color: #4b4d51; font-weight: bold;">notification.cpp:37</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; "><span class="p">{</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);">    <span class="bright"></span><span class="n"><span class="bright">mImagesDir</span></span><span class="bright"> </span><span style="color: #aa2211"><span class="bright">=</span></span><span class="bright"> </span><span class="n"><span class="bright">QDir</span></span><span class="bright"></span><span style="color: #aa2211"><span class="bright">::</span></span><span class="bright"></span><span class="n"><span class="bright">temp</span></span><span class="bright"></span><span class="p"><span class="bright">().</span></span><span class="bright"></span><span class="n"><span class="bright">absoluteFilePath</span></span><span class="bright"></span><span class="p"><span class="bright">(</span></span><span class="bright"></span><span class="n"><span class="bright">QStringLiteral</span></span><span class="bright"></span><span class="p"><span class="bright">(</span></span><span class="bright"></span><span style="color: #766510"><span class="bright">"kdeconnect"</span></span><span class="bright"></span><span class="p"><span class="bright">));</span></span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">    <span class="bright"></span><span style="color: #74777d"><span class="bright">// Use CacheLocation instead of TempLocation because TempLocation may be accessible system-wide</span></span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">    <span class="n">mImagesDir</span> <span style="color: #aa2211">=</span> <span class="n">QDir</span><span class="p">(</span><span class="n">QStandardPaths</span><span style="color: #aa2211">::</span><span class="n">writableLocation</span><span class="p">(</span><span class="n">QStandardPaths</span><span style="color: #aa2211">::</span><span class="n">CacheLocation</span><span class="p">));</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Are the icons reused over restarts? In that case a cache is what you want.<br />
If they are only short lived, TempLocation is a better fit as /tmp is usually a tmpfs(5).<br />
Writing the files to disk just to delete them 5 seconds later does nothing but wear the disk.<br />
To address the privacy concerns, set appropriate permissions on the directory (i.e. only owner should have access)</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D7146#inline-29139" rel="noreferrer">View Inline</a><span style="color: #4b4d51; font-weight: bold;">notification.cpp:119</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">            <span class="n">destinationUrl</span><span class="p">.</span><span class="n">setScheme</span><span class="p">(</span><span class="n">QStringLiteral</span><span class="p">(</span><span style="color: #766510">"file"</span><span class="p">));</span>
</div><div style="padding: 0 8px; margin: 0 4px; ">            <span class="n">FileTransferJob</span><span style="color: #aa2211">*</span> <span class="n">job</span> <span style="color: #aa2211">=</span> <span class="n">np</span><span class="p">.</span><span class="n">createPayloadTransferJob</span><span class="p">(</span><span class="n">destinationUrl</span><span class="p">);</span>
</div><div style="padding: 0 8px; margin: 0 4px; ">            <span class="n">job</span><span style="color: #aa2211">-></span><span class="n">start</span><span class="p">();</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Where is this file deleted?</p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R224 KDE Connect</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D7146" rel="noreferrer">https://phabricator.kde.org/D7146</a></div></div><br /><div><strong>To: </strong>nicolasfella, KDE Connect, apol<br /><strong>Cc: </strong>thomasp, apol, KDE Connect, albertvaka, tfella, aboudhar, seebauer, progwolff, MayeulC, menasshock, ach, hkaelberer<br /></div>