<table><tr><td style="">albertvaka accepted this revision.<br />albertvaka added a comment.<br />This revision is now accepted and ready to land.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D6743" rel="noreferrer">View Revision</a></tr></table><br /><div><div><p>I try to avoid statics (and hence singletons) in Android, because Android can decide to unload classes when it's low on memory, and then static variables on that class become null.</p>

<p>Unfortunately, I can't find any way of doing it without having a singleton class, because the ChooserTargetService has no way to access anything...</p>

<p>So, I guess we will have to stick with this approach.</p></div></div><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D6743#inline-28522" rel="noreferrer">View Inline</a><span style="color: #4b4d51; font-weight: bold;">ShareActivity.java:176</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);">        <span class="bright">        </span><span class="n"><span class="bright">service</span></span><span class="bright"></span><span style="color: #aa2211"><span class="bright">.</span></span><span class="bright"></span><span style="color: #354bb3"><span class="bright">addDeviceListChangedCallback</span></span><span class="bright"></span><span style="color: #aa2211"><span class="bright">(</span></span><span class="bright"></span><span style="color: #766510"><span class="bright">"ShareActivity"</span></span><span class="bright"></span><span style="color: #aa2211"><span class="bright">,</span></span><span class="bright"> </span><span style="color: #aa4000"><span class="bright">new</span></span><span class="bright"> </span><span class="n"><span class="bright">BackgroundService</span></span><span class="bright"></span><span style="color: #aa2211"><span class="bright">.</span></span><span class="bright"></span><span style="color: #354bb3"><span class="bright">DeviceListChangedCallback</span></span><span class="bright"></span><span style="color: #aa2211"><span class="bright">(</span>)</span> <span style="color: #aa2211">{</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);">            <span class="bright">        </span><span style="color: #aa22ff"><span class="bright">@Override</span></span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);">            <span class="bright">        </span><span style="color: #aa4000"><span class="bright">public</span></span><span class="bright"> </span><span style="color: #aa4000"><span class="bright">void</span></span><span class="bright"> </span><span style="color: #004012"><span class="bright">onDe</span>vice<span class="bright">ListChanged</span></span><span class="bright"></span><span style="color: #aa2211"><span class="bright">()</span></span><span class="bright"> </span><span style="color: #aa2211"><span class="bright">{</span></span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">        <span class="bright"></span><span style="color: #aa4000"><span class="bright">if</span></span><span class="bright"> </span><span style="color: #aa2211"><span class="bright">(</span></span><span class="bright"></span><span class="n"><span class="bright">deviceId</span></span><span class="bright"></span><span style="color: #aa2211"><span class="bright">!=</span></span><span class="bright"></span><span style="color: #000a65"><span class="bright">null</span></span><span style="color: #aa2211">)</span> <span style="color: #aa2211">{</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">            <span class="bright"></span><span class="n"><span class="bright">Log</span></span><span class="bright"></span><span style="color: #aa2211"><span class="bright">.</span></span><span class="bright"></span><span style="color: #354bb3"><span class="bright">d</span></span><span class="bright"></span><span style="color: #aa2211"><span class="bright">(</span></span><span class="bright"></span><span style="color: #766510"><span class="bright">"DirectShare"</span></span><span class="bright"></span><span style="color: #aa2211"><span class="bright">,</span></span><span class="bright"> </span><span style="color: #766510"><span class="bright">"sharing to "</span></span><span class="bright"></span><span style="color: #aa2211"><span class="bright">+</span></span><span class="bright"></span><span class="n"><span class="bright">BackgroundService</span></span><span class="bright"></span><span style="color: #aa2211"><span class="bright">.</span></span><span class="bright"></span><span style="color: #354bb3"><span class="bright">getInstance</span></span><span class="bright"></span><span style="color: #aa2211"><span class="bright">().</span></span><span class="bright"></span><span style="color: #354bb3"><span class="bright">getDevice</span></span><span class="bright"></span><span style="color: #aa2211"><span class="bright">(</span></span><span class="bright"></span><span class="n"><span class="bright">deviceId</span></span><span class="bright"></span><span style="color: #aa2211"><span class="bright">).</span></span><span class="bright"></span><span style="color: #354bb3"><span class="bright">getName</span></span><span class="bright"></span><span style="color: #aa2211"><span class="bright">());</span></span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">            <span class="bright"></span><span class="n"><span class="bright">Device</span></span><span class="bright"> </span><span class="n"><span class="bright">device</span></span><span class="bright"> </span><span style="color: #aa2211"><span class="bright">=</span></span><span class="bright"> </span><span class="n"><span class="bright">BackgroundSer</span>vice<span class="bright"></span></span><span class="bright"></span><span style="color: #aa2211"><span class="bright">.</span></span><span class="bright"></span><span style="color: #354bb3"><span class="bright">getInstance</span></span><span class="bright"></span><span style="color: #aa2211"><span class="bright">().</span></span><span class="bright"></span><span style="color: #354bb3"><span class="bright">getDevice</span></span><span class="bright"></span><span style="color: #aa2211"><span class="bright">(</span></span><span class="bright"></span><span class="n"><span class="bright">deviceId</span></span><span class="bright"></span><span style="color: #aa2211"><span class="bright">);</span></span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">I think here we can use the BackgroundService.RunCommand construct, instead of using the singleton... I would prefer if we only use the singleton when it's 100% necessary (ie: only from the ChooserTargetService).</p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R225 KDE Connect - Android application</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D6743" rel="noreferrer">https://phabricator.kde.org/D6743</a></div></div><br /><div><strong>To: </strong>nicolasfella, KDE Connect, albertvaka<br /><strong>Cc: </strong>albertvaka, KDE Connect, tfella, aboudhar, seebauer, progwolff, MayeulC, menasshock, ach, apol, hkaelberer<br /></div>