<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=utf-8">
</head>
<body text="#000000" bgcolor="#FFFFFF">
You saying that almost makes the assumption that I understand
anything that's going on with KTp/Telepathy. It's a good thing
there's already a library or I would be totally lost :)<br>
<br>
Okay. Let's hope the power doesn't make me crazy!<br>
<br>
I have a few thoughts and questions, but I'm going to start a new
email thread. This one has long ago stopped being about what is in
the subject line... (Also, my first attempt to send it hit against
the size limit for the mailing list!)<br>
<br>
Thanks,<br>
Simon<br>
<br>
<div class="moz-cite-prefix">On 05/23/2017 02:11 PM, Albert Vaca
wrote:<br>
</div>
<blockquote type="cite"
cite="mid:CAAQViEsBXuJqtGz4MKvxus2vtoK4ttBOTOezN8MmComq9wtY=g@mail.gmail.com">
<div dir="ltr">I'm not knowledgeable enough about KTp to do a
meaningful review, so I'm adding David Edmundson (who started
the kdeconnect telpathy plugin) as a reviewer.
<div><br>
</div>
<div>Once you get them approved and merged, I think you should
apply for a developer account with commit rights (so I don't
have to merge your patches anymore :).</div>
</div>
<div class="gmail_extra"><br>
<div class="gmail_quote">On Tue, May 23, 2017 at 6:39 AM, Simon
Redman <span dir="ltr"><<a
href="mailto:simon@ergotech.com" target="_blank"
moz-do-not-send="true">simon@ergotech.com</a>></span>
wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0
.8ex;border-left:1px #ccc solid;padding-left:1ex">
<div text="#000000" bgcolor="#FFFFFF"> I finally kicked
something enough that the option to add a kdeconnect
account shows up in Empathy (but still not in KTp... I
can't figure out why), so step one to "Support multiple
devices by having one account per device" is done.<br>
<br>
There are two smaller revision requests and one mega
request... Sorry about the very large one -- for a long
time everything was broken because I specified a required
parameter to the account but then never set it, so I was
just reading documentation and tweaking things trying to
figure out why the plugin was not loading.<br>
<br>
Thanks,<br>
Simon
<div>
<div class="h5"><br>
<br>
<div class="m_-5587733780983075570moz-cite-prefix">On
05/21/2017 04:57 AM, Albert Vaca wrote:<br>
</div>
<blockquote type="cite">
<div dir="auto"><span
style="font-family:sans-serif;font-size:13.696px">And
support for multiple devices looks like
something you will end up needing. For other
Telepathy plugins you can already have several
accounts for the same plugin, so I guess it will
be something like that... no idea how easy it is
to implement it, though. </span><br
style="font-family:sans-serif;font-size:13.696px">
<br
style="font-family:sans-serif;font-size:13.696px">
<span
style="font-family:sans-serif;font-size:13.696px">Syncing
the entire contact book every time the plugin
loads and/or the contact list changes on Android
seems ok. Specially if you start without syncing
the profile pictures. Sounds like a good idea to
sync first names and numbers and then sync the
pictures later as you need them. </span>
<div dir="auto"><br
style="font-family:sans-serif;font-size:13.696px">
<font face="sans-serif"><span
style="font-size:13.696px">Make sure,
though, that when you fetch the contacts on
Android you do a single query to the contact
storage to retrieve them all. Since Android
uses sqlite internally, doing a query per
user is super slow. </span></font></div>
<div dir="auto"><br
style="font-family:sans-serif;font-size:13.696px">
<span
style="font-family:sans-serif;font-size:13.696px">About
maintaining the plugin, of course I will be
more than happy to help you and review the
patches :)</span></div>
</div>
<div class="gmail_extra"><br>
<div class="gmail_quote">On May 19, 2017 23:10,
"Simon Redman" <<a
href="mailto:simon@ergotech.com"
target="_blank" moz-do-not-send="true">simon@ergotech.com</a>>
wrote:<br type="attribution">
<blockquote class="gmail_quote" style="margin:0
0 0 .8ex;border-left:1px #ccc
solid;padding-left:1ex">
<div text="#000000" bgcolor="#FFFFFF"> I will
look into how other Telepathy plugins deal
with contacts. Maybe there is a very easy
way to deal with caching, or maybe they just
load the whole contacts list when the plugin
loads.<br>
<br>
The problems with the app watching for
changes is I have a desktop and a laptop
which are not both always connected to the
phone. The phone would have to keep track of
changes and which synchronized device has
seen those changes (Which is not impossible,
but I'm lazy :) ) -- And, of course,
different phones may have different contacts
books... Maybe I need to add support for
different devices sooner rather than later.<br>
<br>
Also, the plugin is not currently caching
any contacts, which would be required in
order to sync changes<br>
<br>
What about just getting the entire contact
book every time the plugin loads?<br>
<br>
Since we have not defined what makes up a
contact, it's a little hard to make a guess
of how expensive this would be. Regardless
of how much text is there, the picture is
going to be the prime contributor to size...
Say 50KB? Meaning if you have more than say
100 contacts the plugin could take a few
seconds to load (over WiFi).<br>
<br>
Maybe just dump the phone numbers + names,
then load contact photos as the contact is
actually used?<br>
<br>
If nobody else is currently maintaining this
plugin, I would be happy to take ownership.
But would it be okay if I still forwarded at
least the first few patches through you for
review? You've been working on this project
for far longer, so you're more likely to
catch bugs, like my dumb 160 letters vs. 160
bytes from my Android patches :)<br>
<br>
Thanks,<br>
Simon<br>
<br>
<div
class="m_-5587733780983075570m_4544440593400676142moz-cite-prefix">On
05/15/2017 02:16 AM, Albert Vaca wrote:<br>
</div>
<blockquote type="cite">
<div dir="auto">Feel free to make any
changes regarding comments, refactoring,
etc.
<div dir="auto"><br>
</div>
<div dir="auto">Also, I agree that
without the addressbook it is not very
useful to be able to send SMS. We can
have the Android app listening for
addressbook changes and then sending
it to the desktop, but I have no idea
on how to pass them to KTP. Any
ideas? </div>
<div dir="auto"><br>
<div dir="auto">Actually, since I
don't use KTP, there is no one
actively maintaining the kdeconnect
plugin. If you want to step in, I
would be more than happy to let you
own it :)</div>
<div dir="auto"><br>
</div>
<div dir="auto">Albert</div>
</div>
</div>
<div class="gmail_extra"><br>
<div class="gmail_quote"><br>
</div>
</div>
</blockquote>
<br>
</div>
</blockquote>
</div>
</div>
</blockquote>
<br>
</div>
</div>
</div>
</blockquote>
</div>
<br>
</div>
</blockquote>
<br>
</body>
</html>