<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/130050/">https://git.reviewboard.kde.org/r/130050/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#e0e0e0" width="100%" cellpadding="12" style="border: 1px gray solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<h1 style="margin: 0; padding: 0; font-size: 10pt;">This change has been marked as submitted.</h1>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for kdeconnect.</div>
<div>By Nicolas Fella.</div>
<p style="color: grey;"><i>Updated April 13, 2017, 10:32 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Submitted with commit 891f1bd355c8e390c9c55c80511fcc5b8ac7beab by Albert Vaca on behalf of Nicolas Fella to branch master.</pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kdeconnect-kde
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Notification icons are now displayed if Desktop and Android App support it both. Filetransferjob is now nonblocking and files are stored based on the images MD5. Some improvements in displaying the notification, e.g. Title is only displayed when different to the App Name. Most of the notification display code has moved to the notification class</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Tested with Plasma 5.9.3 (Manjaro)
Tested with patched Android + patched KDE, unpatched Android + patched KDE, patched Android + unpatched KDE from Manjaro repo</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>.gitignore <span style="color: grey">(d7f2d6068b0ecfc20040c84b268299895de4c519)</span></li>
<li>core/filetransferjob.h <span style="color: grey">(a94b38c0b39961471575e815acc8daaa43f2a7ad)</span></li>
<li>plugins/notifications/notification.h <span style="color: grey">(39a73ea435b571046d7f65909afc63470d4026b7)</span></li>
<li>plugins/notifications/notification.cpp <span style="color: grey">(487ca84fc1d5417aedda8509545eee5da8d6c03f)</span></li>
<li>plugins/notifications/notificationsdbusinterface.h <span style="color: grey">(b8120f661925a350109a55014eb62141f395d22f)</span></li>
<li>plugins/notifications/notificationsdbusinterface.cpp <span style="color: grey">(dbd63099f7fd41aeb730cbda78036888ef1a5a18)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/130050/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>