<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/129728/">https://git.reviewboard.kde.org/r/129728/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On gener 10th, 2017, 2:17 p.m. PST, <b>Albert Vaca Cintora</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="https://git.reviewboard.kde.org/r/129728/diff/1/?file=488310#file488310line168" style="color: black; font-weight: bold; text-decoration: underline;">src/org/kde/kdeconnect/Plugins/RemoteKeyboardPlugin/RemoteKeyboardService.java</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">168</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">ArrayList</span><span class="o"><</span><span class="n">RemoteKeyboardPlugin</span><span class="o">></span> <span class="n">instances</span> <span class="o">=</span> <span class="n">RemoteKeyboardPlugin</span><span class="o">.</span><span class="na">getInstances</span><span class="o">();</span></pre></td>
</tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">There is only one option in settins, so maybe this button could take you to the main app instead of the settings?</pre>
</blockquote>
<p>On gener 11th, 2017, 12:01 p.m. PST, <b>Holger Kaelberer</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Possibly. Idea was to add a short-cut to access the settings. I expect more settings to be added, like "Allow full screen editor" that seems useful.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">If it should take the user to the main app, the icon should better be replaced by ... maybe the kdeconnect-icon?</p></pre>
</blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Your call. I proposed the change because as of now there is only one setting, but it's not a big deal either way.</pre>
<br />
<p>- Albert</p>
<br />
<p>On desembre 30th, 2016, 8:57 a.m. PST, Holger Kaelberer wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for kdeconnect.</div>
<div>By Holger Kaelberer.</div>
<p style="color: grey;"><i>Updated des. 30, 2016, 8:57 a.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=370919">370919</a>
</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kdeconnect-android
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Allow to receive keypress events from remote devices.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Notes / open issues / possible improvements:</p>
<ul style="padding: 0;text-rendering: inherit;margin: 0 0 0 1em;line-height: inherit;white-space: normal;">
<li style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;">
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Pls. have a close look at the Android-code, that was written by a non-Android dev! ;-) Especially:</p>
</li>
<li style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;">
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Not sure if invocations of InputConnection::sendKeyEvents() from the thread triggering onPackageReceived() need to by async (using a Handler or so). Works fine for me as it is now, but maybe I'm not aware of some Android threading policies.</p>
</li>
<li style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;">
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">So far no settings-activity for the ime defined to be launched from the OS settings. Should we?</p>
</li>
<li style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;">
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Handles a couple of special key-sequences so far: Shift+Arrows/Home/End (update selection), Ctrl+(Shift+)Arrows (jump/update selection by word), Ctrl+Enter (force Send/Go/... IME-Action), Ctrl+c/v/x/a (Copy/Paste/Cut/Select all)</p>
</li>
<li style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;">
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">There is probably other behaviour that could be made configurable (like Ctrl+Return triggering IME-actions etc.)</p>
</li>
</ul></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Sure, on:
- S2 (4.2.2, CyanogenMod)
- Sony Z5 Compact (6.0.1)
- Galaxy Tab 4 (5.0.2)
- S3 Mini (4.1.2)</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>AndroidManifest.xml <span style="color: grey">(b1e1c51)</span></li>
<li>res/drawable-hdpi/ic_keyboard_hide_white_36dp.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>res/drawable-hdpi/ic_phonelink_off_white_36dp.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>res/drawable-hdpi/ic_phonelink_white_36dp.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>res/drawable-mdpi/ic_keyboard_hide_white_36dp.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>res/drawable-mdpi/ic_phonelink_off_white_36dp.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>res/drawable-mdpi/ic_phonelink_white_36dp.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>res/drawable-xhdpi/ic_keyboard_hide_white_36dp.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>res/drawable-xhdpi/ic_phonelink_off_white_36dp.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>res/drawable-xhdpi/ic_phonelink_white_36dp.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>res/drawable-xxhdpi/ic_keyboard_hide_white_36dp.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>res/drawable-xxhdpi/ic_phonelink_off_white_36dp.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>res/drawable-xxhdpi/ic_phonelink_white_36dp.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>res/drawable-xxxhdpi/ic_keyboard_hide_white_36dp.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>res/drawable-xxxhdpi/ic_phonelink_off_white_36dp.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>res/drawable-xxxhdpi/ic_phonelink_white_36dp.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>res/values/dimens.xml <span style="color: grey">(47c8224)</span></li>
<li>res/values/strings.xml <span style="color: grey">(955b88d)</span></li>
<li>res/xml/remotekeyboardplugin_keyboard.xml <span style="color: grey">(PRE-CREATION)</span></li>
<li>res/xml/remotekeyboardplugin_method.xml <span style="color: grey">(PRE-CREATION)</span></li>
<li>res/xml/remotekeyboardplugin_preferences.xml <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/org/kde/kdeconnect/Plugins/PluginFactory.java <span style="color: grey">(1da88ef)</span></li>
<li>src/org/kde/kdeconnect/Plugins/RemoteKeyboardPlugin/RemoteKeyboardPlugin.java <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/org/kde/kdeconnect/Plugins/RemoteKeyboardPlugin/RemoteKeyboardService.java <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/org/kde/kdeconnect/UserInterface/MaterialActivity.java <span style="color: grey">(c28e38c)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/129728/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>