<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/128253/">https://git.reviewboard.kde.org/r/128253/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Ping.</p></pre>
<br />
<p>- Saikrishna Arcot</p>
<br />
<p>On June 21st, 2016, 12:40 p.m. CDT, Saikrishna Arcot wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for kdeconnect.</div>
<div>By Saikrishna Arcot.</div>
<p style="color: grey;"><i>Updated June 21, 2016, 12:40 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kdeconnect-kde
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Sending payloads is not supported yet, but receiving payloads is.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">The getPairedDevices() method (used only if the Qt version is 5.4.0 or less) in the link provider class uses D-Bus to get the list of paired devices. This is needed because older versions of Qt didn't support BlueZ 5, and therefore the bluetooth backend wouldn't work at all.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Android side is in /r/128270.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">KDE Connect runs, and the bluetooth service gets published in the SDP (service discovery protocol), which other devices use to determine what services are available.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Receiving files works (tested with 1.5 MB picture), but sending files doesn't work due to how Qt sends data over bluetooth.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Browsing the remote device will not work since this uses SSHFS, which relies on a IP network.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>CMakeLists.txt <span style="color: grey">(abd3438c78bb3c4a49561870e5097c036523516b)</span></li>
<li>core/CMakeLists.txt <span style="color: grey">(0b16096345c3a39d820fb94e918e66c27ab8a568)</span></li>
<li>core/backends/bluetooth/CMakeLists.txt <span style="color: grey">(PRE-CREATION)</span></li>
<li>core/backends/bluetooth/bluetoothdevicelink.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>core/backends/bluetooth/bluetoothdevicelink.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>core/backends/bluetooth/bluetoothdownloadjob.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>core/backends/bluetooth/bluetoothdownloadjob.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>core/backends/bluetooth/bluetoothlinkprovider.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>core/backends/bluetooth/bluetoothlinkprovider.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>core/backends/bluetooth/bluetoothpairinghandler.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>core/backends/bluetooth/bluetoothpairinghandler.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>core/backends/bluetooth/bluetoothuploadjob.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>core/backends/bluetooth/bluetoothuploadjob.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>core/backends/devicelinereader.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>core/backends/devicelinereader.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>core/daemon.cpp <span style="color: grey">(b41616c388deaddf8350e411383c8b4360c40d72)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/128253/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>