<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/128149/">https://git.reviewboard.kde.org/r/128149/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for kdeconnect and David Edmundson.</div>
<div>By Aleix Pol Gonzalez.</div>
<p style="color: grey;"><i>Updated June 16, 2016, 2:13 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Moves the telepathy logic into a separate executable so that it can be used like a real telepathy service.
Now David Edmundson will make sure it works nicely.</pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kdeconnect-kde
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">At the moment, telepathy integration needs to be compiled within the daemon. This creates a rather aggressive dependency with Telepathy.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">This plugin proposes to move into a plugin, so that if the plugin isn't present, telepathy becomes out of the picture.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">David: I'm not really sure how well it's going to work, I'm relying on your feedback on how to proceed.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Builds</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> (updated)</h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>CMakeLists.txt <span style="color: grey">(b778ff9)</span></li>
<li>daemon/CMakeLists.txt <span style="color: grey">(359ea8d)</span></li>
<li>daemon/kdeconnectd.cpp <span style="color: grey">(1b7a841)</span></li>
<li>plugins/telephony/CMakeLists.txt <span style="color: grey">(666c54f)</span></li>
<li>plugins/telephony/telephonyplugin.h <span style="color: grey">(d1a6873)</span></li>
<li>plugins/telephony/telephonyplugin.cpp <span style="color: grey">(d285c39)</span></li>
<li>telepathy-cm/CMakeLists.txt <span style="color: grey">(fc763fb)</span></li>
<li>telepathy-cm/connectcm_export.h <span style="color: grey">(740ae98)</span></li>
<li>telepathy-cm/connection.h <span style="color: grey">(b4438bf)</span></li>
<li>telepathy-cm/kdeconnect.manager <span style="color: grey">(fcdeb08)</span></li>
<li>telepathy-cm/kdeconnecttelepathyprotocolfactory.h <span style="color: grey">(51b44fd)</span></li>
<li>telepathy-cm/kdeconnecttelephony.manager <span style="color: grey">(PRE-CREATION)</span></li>
<li>telepathy-cm/main.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>telepathy-cm/protocol.h <span style="color: grey">(5431aa8)</span></li>
<li>telepathy-cm/textchannel.h <span style="color: grey">(3781283)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/128149/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>