<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/127768/">https://git.reviewboard.kde.org/r/127768/</a>
</td>
</tr>
</table>
<br />
<p>
Ship it!
</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">The solution looks overly to complex IMHO, but it's indeed better like this.</p></pre>
<br />
<p>- Aleix Pol Gonzalez</p>
<br />
<p>On April 27th, 2016, 9:08 p.m. CEST, David Kahles wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for kdeconnect.</div>
<div>By David Kahles.</div>
<p style="color: grey;"><i>Updated April 27, 2016, 9:08 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kdeconnect-kde
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">The app name used by KNotification is translated, and thus the filtering
doesn't work if the translated app name is different.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Previously, when the phone gets a new notification and sends it to the computer, kdeconnect will post
a notification, but record this notification (as the filtering didn't work) and send it back to the phone. Therefore each notification on the phone will there be two times.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">This works on master because notifications aren't synchronized with the phone (a bug?). On sslrefactor this is fixed, and thus we need to fix the filtering.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I need to parse this configuration file, as I don't see another way to retrieve the translated app name.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">If the phone gets a notification, it will appear on the computer, but not again on the phone.
Sending notification from the computer to the phone still works fine.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>plugins/notifications/CMakeLists.txt <span style="color: grey">(d74cca6b249411d981a23fdf6ec5a493efd472e1)</span></li>
<li>plugins/notifications/notificationslistener.h <span style="color: grey">(dfa37b8a914e8cd03e1bb3d3eaf8f4f66269ef02)</span></li>
<li>plugins/notifications/notificationslistener.cpp <span style="color: grey">(d21f3d733752a155ea26f34bfab2b873f7e3de72)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/127768/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>