<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/126666/">https://git.reviewboard.kde.org/r/126666/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On January 11th, 2016, 2:15 p.m. UTC, <b>Albert Vaca Cintora</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Looks good. Maybe in a future it might be a good idea to split the notifications plugin in two: one for sending and one for receiving. This way we slit the code into smaller files and also users can disable one or the other independently.</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Ok.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I am about to finish an extension of icon synchronization, to also sync image-data and friends that come in the hints structure of the Notify message. I planned to update this RR this evening. Or do you prefer I open another RR for that?</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Sorry, I realized too late that there are other sources for icon images.</p></pre>
<br />
<p>- Holger</p>
<br />
<p>On January 7th, 2016, 6:55 p.m. UTC, Holger Kaelberer wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for kdeconnect.</div>
<div>By Holger Kaelberer.</div>
<p style="color: grey;"><i>Updated Jan. 7, 2016, 6:55 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kdeconnect-kde
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Configurably attach icons as payload to notification packages. By design and due to restrictions on mobile devices *only* png is sent. As KIconLoader preferably returns svg icons from iconPath() we fall back to loading from "hicolor" using KIconTheme directly. Otherwise *many* icons are dropped because of svg format.
This also improves slightly the test-case to use a tweaked TestDevice to allow for inspecting sent NetworkPackage-s.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">yep, works well with different android devices</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>plugins/notifications/CMakeLists.txt <span style="color: grey">(448be94)</span></li>
<li>plugins/notifications/notifications_config.cpp <span style="color: grey">(5086d9f)</span></li>
<li>plugins/notifications/notifications_config.ui <span style="color: grey">(3f3d8a4)</span></li>
<li>plugins/notifications/notificationslistener.cpp <span style="color: grey">(22d50fb)</span></li>
<li>tests/CMakeLists.txt <span style="color: grey">(66aeb5f)</span></li>
<li>tests/testnotificationlistener.cpp <span style="color: grey">(e1faa1c)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/126666/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>