<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/125140/">https://git.reviewboard.kde.org/r/125140/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for kdeconnect.</div>
<div>By Holger Kaelberer.</div>
<p style="color: grey;"><i>Updated Nov. 27, 2015, 8:15 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This also adds a kcm ui to to allow to configure how to sync desktop notifications:
Some Global options affect all notifications:
- Persistent only? --> Sync only notifications with timeout == 0?
- Include body? --> Add body string to summary when syncing?
- Minimum urgency
Per application options affect notifications sent by a specific application:
- Sync it at all?
- If yes, allow to define a "blacklist" pattern (QRegualarExpression) to define which notifications should *not* be synced.
Some notes/unclear issues (feedback welcome):
----------------------------------------------
- In daemon context, what is the recommended KDE/Qt-way to initialize stuff in a plugin that should best be initialized statically like the following:
qRegisterMetaTypeStreamOperators<NotifyingApplication>("NotifyingApplication");
Should be best something like a __attribute__((constructor)). Currently it's done in the NotificationListener contructor, i.e. not only once, which does probably no harm.
- To keep things simple I used the per-device dbus signal configChanged() to allow for reloading the list of known applications in notifications-plugin vs. kcm-module when changed in the resp. other one. This produces some superfluous reloads, but should be fine, as these events don't occur too often.
- Added some 'docu' to kcm in the tooltip texts. Should it be put elsewhere?</pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kdeconnect-kde
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Eavesdrop on the Notify call of the org.freedesktop.Notifications dbus-interface, proxy all caught notifications to our peer device and track them in the internal notifications-list.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Also fix "cancel" requests from peer devices, by cutting of kdeconnect-android's id-prefix.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I tested with my (patched) tablet, works fine.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> (updated)</h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>core/kdeconnectpluginconfig.h <span style="color: grey">(09bf68e)</span></li>
<li>core/kdeconnectpluginconfig.cpp <span style="color: grey">(980235c)</span></li>
<li>plugins/notifications/CMakeLists.txt <span style="color: grey">(41c5b78)</span></li>
<li>plugins/notifications/kdeconnect_notifications_config.desktop <span style="color: grey">(PRE-CREATION)</span></li>
<li>plugins/notifications/notifications_config.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>plugins/notifications/notifications_config.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>plugins/notifications/notifications_config.ui <span style="color: grey">(PRE-CREATION)</span></li>
<li>plugins/notifications/notificationsdbusinterface.h <span style="color: grey">(21d5a6a)</span></li>
<li>plugins/notifications/notificationsdbusinterface.cpp <span style="color: grey">(3c504c6)</span></li>
<li>plugins/notifications/notificationslistener.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>plugins/notifications/notificationslistener.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>plugins/notifications/notificationsplugin.h <span style="color: grey">(7cc67c5)</span></li>
<li>plugins/notifications/notificationsplugin.cpp <span style="color: grey">(badb5d3)</span></li>
<li>plugins/notifications/notifyingapplication.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>plugins/notifications/notifyingapplication.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>plugins/notifications/notifyingapplicationmodel.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>plugins/notifications/notifyingapplicationmodel.cpp <span style="color: grey">(PRE-CREATION)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/125140/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>