<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/124170/">https://git.reviewboard.kde.org/r/124170/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On June 25th, 2015, 7:16 a.m. CEST, <b>Albert Vaca Cintora</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">We have a plugin to inhibit the screen saver, I think it would make sense to merge them, and extend the plugin to manage the locking of the device. In a future we might add more stuff there, like automatically lock when your phone disconnects or unlock when it is connected, the same way we inhibit the locking right now.</pre>
</blockquote>
<p>On June 27th, 2015, 4:10 a.m. CEST, <b>Aleix Pol Gonzalez</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Well, at the moment, the inhibit plugin is supposed to be disabled if you don't want the inhibition to happen (and note it's disabled by default). Also note it doesn't send or receive packages either. It's a special plugin.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">The only similarity I see is that both are freedesktop services adopted.</p></pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">?</p></pre>
<br />
<p>- Aleix</p>
<br />
<p>On June 25th, 2015, 4:15 a.m. CEST, Aleix Pol Gonzalez wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for kdeconnect.</div>
<div>By Aleix Pol Gonzalez.</div>
<p style="color: grey;"><i>Updated June 25, 2015, 4:15 a.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kdeconnect-kde
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Connects to freedesktop ScreenSaver interface and un/locks it upon request.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Locked my computer.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>app/qml/main.qml <span style="color: grey">(9b4cf82)</span></li>
<li>cli/kdeconnect-cli.cpp <span style="color: grey">(3aa49e5)</span></li>
<li>interfaces/CMakeLists.txt <span style="color: grey">(0220af8)</span></li>
<li>interfaces/dbusinterfaces.h <span style="color: grey">(260a0e6)</span></li>
<li>interfaces/dbusinterfaces.cpp <span style="color: grey">(a89f7a0)</span></li>
<li>plasmoid/declarativeplugin/kdeconnectdeclarativeplugin.cpp <span style="color: grey">(0db9e8b)</span></li>
<li>plugins/CMakeLists.txt <span style="color: grey">(35aec66)</span></li>
<li>plugins/lockdevice/CMakeLists.txt <span style="color: grey">(PRE-CREATION)</span></li>
<li>plugins/lockdevice/kdeconnect_lockdevice.json <span style="color: grey">(PRE-CREATION)</span></li>
<li>plugins/lockdevice/lockdeviceplugin.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>plugins/lockdevice/lockdeviceplugin.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>plugins/lockdevice/org.freedesktop.ScreenSaver.xml <span style="color: grey">(PRE-CREATION)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/124170/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>