<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/124044/">https://git.reviewboard.kde.org/r/124044/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Instead of having /src/main (old "/src") and /src/androidTests, I would like to keep /src as it is, and add /androidTests to the root of the repo. Moving the sources doesn't only cause monstrous diffs in review board (as Aleix already saw), but also makes the git history more difficult to track and can create lots of conflicts for people with local changes when pulling this.</pre>
<br />
<p>- Albert Vaca Cintora</p>
<br />
<p>On June 8th, 2015, 9:28 a.m. PDT, Vineet Garg wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for kdeconnect and Albert Vaca Cintora.</div>
<div>By Vineet Garg.</div>
<p style="color: grey;"><i>Updated June 8, 2015, 9:28 a.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kdeconnect-android
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><ul style="padding: 0;text-rendering: inherit;margin: 0 0 0 1em;line-height: inherit;white-space: normal;">
<li style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;">Changed project structure to incorporate tests.</li>
<li style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;">Directory 'src' has 3 sub-directories main(contains main app source), androidTest(contains source for tests that needs to be run on Android device, test(contains source for tests that can be run on local JVM, currently empty).</li>
<li style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;">Written NetworkPackageTest based on NetworkPackageTest of kdeconnect-kde.</li>
<li style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;">Written a basic DeviceTest, that tests functionality for Device class.</li>
</ul></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Application builds properly
Tests run successfully</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>build.gradle <span style="color: grey">(fd4dabe)</span></li>
<li>src/androidTest/java/org/kde/kdeconnect/DeviceTest.java <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/androidTest/java/org/kde/kdeconnect/NetworkPackageTest.java <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/main/java/org/kde/kdeconnect/Backends/BaseLink.java <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/main/java/org/kde/kdeconnect/Backends/BaseLinkProvider.java <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/main/java/org/kde/kdeconnect/Backends/LanBackend/LanLink.java <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/main/java/org/kde/kdeconnect/Backends/LanBackend/LanLinkProvider.java <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/main/java/org/kde/kdeconnect/Backends/LoopbackBackend/LoopbackLink.java <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/main/java/org/kde/kdeconnect/Backends/LoopbackBackend/LoopbackLinkProvider.java <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/main/java/org/kde/kdeconnect/BackgroundService.java <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/main/java/org/kde/kdeconnect/Device.java <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/main/java/org/kde/kdeconnect/Helpers/AppsHelper.java <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/main/java/org/kde/kdeconnect/Helpers/ContactsHelper.java <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/main/java/org/kde/kdeconnect/Helpers/DeviceHelper.java <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/main/java/org/kde/kdeconnect/Helpers/FilesHelper.java <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/main/java/org/kde/kdeconnect/Helpers/ImagesHelper.java <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/main/java/org/kde/kdeconnect/Helpers/NotificationsHelper.java <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/main/java/org/kde/kdeconnect/Helpers/StorageHelper.java <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/main/java/org/kde/kdeconnect/KdeConnectBroadcastReceiver.java <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/main/java/org/kde/kdeconnect/NetworkPackage.java <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/main/java/org/kde/kdeconnect/Plugins/BatteryPlugin/BatteryPlugin.java <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/main/java/org/kde/kdeconnect/Plugins/ClibpoardPlugin/ClipboardListener.java <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/main/java/org/kde/kdeconnect/Plugins/ClibpoardPlugin/ClipboardPlugin.java <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/main/java/org/kde/kdeconnect/Plugins/MousePadPlugin/KeyListenerView.java <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/main/java/org/kde/kdeconnect/Plugins/MousePadPlugin/MousePadActivity.java <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/main/java/org/kde/kdeconnect/Plugins/MousePadPlugin/MousePadGestureDetector.java <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/main/java/org/kde/kdeconnect/Plugins/MousePadPlugin/MousePadPlugin.java <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/main/java/org/kde/kdeconnect/Plugins/MprisPlugin/MprisActivity.java <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/main/java/org/kde/kdeconnect/Plugins/MprisPlugin/MprisPlugin.java <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/main/java/org/kde/kdeconnect/Plugins/NotificationsPlugin/AppDatabase.java <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/main/java/org/kde/kdeconnect/Plugins/NotificationsPlugin/NotificationFilterActivity.java <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/main/java/org/kde/kdeconnect/Plugins/NotificationsPlugin/NotificationReceiver.java <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/main/java/org/kde/kdeconnect/Plugins/NotificationsPlugin/NotificationsPlugin.java <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/main/java/org/kde/kdeconnect/Plugins/PingPlugin/PingPlugin.java <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/main/java/org/kde/kdeconnect/Plugins/Plugin.java <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/main/java/org/kde/kdeconnect/Plugins/PluginFactory.java <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/main/java/org/kde/kdeconnect/Plugins/SftpPlugin/SftpImpl.java <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/main/java/org/kde/kdeconnect/Plugins/SftpPlugin/SftpPlugin.java <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/main/java/org/kde/kdeconnect/Plugins/SharePlugin/ShareActivity.java <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/main/java/org/kde/kdeconnect/Plugins/SharePlugin/SharePlugin.java <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/main/java/org/kde/kdeconnect/Plugins/TelephonyPlugin/TelephonyPlugin.java <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/main/java/org/kde/kdeconnect/UserInterface/CustomDevicesActivity.java <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/main/java/org/kde/kdeconnect/UserInterface/DeviceActivity.java <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/main/java/org/kde/kdeconnect/UserInterface/List/ButtonItem.java <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/main/java/org/kde/kdeconnect/UserInterface/List/CustomItem.java <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/main/java/org/kde/kdeconnect/UserInterface/List/DeviceItem.java <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/main/java/org/kde/kdeconnect/UserInterface/List/EntryItem.java <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/main/java/org/kde/kdeconnect/UserInterface/List/ListAdapter.java <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/main/java/org/kde/kdeconnect/UserInterface/List/SectionItem.java <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/main/java/org/kde/kdeconnect/UserInterface/List/SmallEntryItem.java <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/main/java/org/kde/kdeconnect/UserInterface/List/TextItem.java <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/main/java/org/kde/kdeconnect/UserInterface/MainActivity.java <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/main/java/org/kde/kdeconnect/UserInterface/MainSettingsActivity.java <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/main/java/org/kde/kdeconnect/UserInterface/MaxWidthImageButton.java <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/main/java/org/kde/kdeconnect/UserInterface/PairActivity.java <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/main/java/org/kde/kdeconnect/UserInterface/PluginSettingsActivity.java <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/main/java/org/kde/kdeconnect/UserInterface/SettingsActivity.java <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/org/kde/kdeconnect/Backends/BaseLink.java <span style="color: grey">(579a7af)</span></li>
<li>src/org/kde/kdeconnect/Backends/BaseLinkProvider.java <span style="color: grey">(cfaf621)</span></li>
<li>src/org/kde/kdeconnect/Backends/LanBackend/LanLink.java <span style="color: grey">(5994142)</span></li>
<li>src/org/kde/kdeconnect/Backends/LanBackend/LanLinkProvider.java <span style="color: grey">(ae26958)</span></li>
<li>src/org/kde/kdeconnect/Backends/LoopbackBackend/LoopbackLink.java <span style="color: grey">(add92f8)</span></li>
<li>src/org/kde/kdeconnect/Backends/LoopbackBackend/LoopbackLinkProvider.java <span style="color: grey">(bd9c41b)</span></li>
<li>src/org/kde/kdeconnect/BackgroundService.java <span style="color: grey">(5e3d8c2)</span></li>
<li>src/org/kde/kdeconnect/Device.java <span style="color: grey">(a8a25c7)</span></li>
<li>src/org/kde/kdeconnect/Helpers/AppsHelper.java <span style="color: grey">(17883f3)</span></li>
<li>src/org/kde/kdeconnect/Helpers/ContactsHelper.java <span style="color: grey">(7569f6e)</span></li>
<li>src/org/kde/kdeconnect/Helpers/DeviceHelper.java <span style="color: grey">(e9dd528)</span></li>
<li>src/org/kde/kdeconnect/Helpers/FilesHelper.java <span style="color: grey">(b5347c9)</span></li>
<li>src/org/kde/kdeconnect/Helpers/ImagesHelper.java <span style="color: grey">(ebe3ba5)</span></li>
<li>src/org/kde/kdeconnect/Helpers/NotificationsHelper.java <span style="color: grey">(6be50d8)</span></li>
<li>src/org/kde/kdeconnect/Helpers/StorageHelper.java <span style="color: grey">(a2a992c)</span></li>
<li>src/org/kde/kdeconnect/KdeConnectBroadcastReceiver.java <span style="color: grey">(e43afba)</span></li>
<li>src/org/kde/kdeconnect/NetworkPackage.java <span style="color: grey">(e5a777e)</span></li>
<li>src/org/kde/kdeconnect/Plugins/BatteryPlugin/BatteryPlugin.java <span style="color: grey">(ea03408)</span></li>
<li>src/org/kde/kdeconnect/Plugins/ClibpoardPlugin/ClipboardListener.java <span style="color: grey">(7f6601e)</span></li>
<li>src/org/kde/kdeconnect/Plugins/ClibpoardPlugin/ClipboardPlugin.java <span style="color: grey">(de00305)</span></li>
<li>src/org/kde/kdeconnect/Plugins/MousePadPlugin/KeyListenerView.java <span style="color: grey">(1228fd5)</span></li>
<li>src/org/kde/kdeconnect/Plugins/MousePadPlugin/MousePadActivity.java <span style="color: grey">(322609d)</span></li>
<li>src/org/kde/kdeconnect/Plugins/MousePadPlugin/MousePadGestureDetector.java <span style="color: grey">(fd8764f)</span></li>
<li>src/org/kde/kdeconnect/Plugins/MousePadPlugin/MousePadPlugin.java <span style="color: grey">(f17bd31)</span></li>
<li>src/org/kde/kdeconnect/Plugins/MprisPlugin/MprisActivity.java <span style="color: grey">(ccbd50f)</span></li>
<li>src/org/kde/kdeconnect/Plugins/MprisPlugin/MprisPlugin.java <span style="color: grey">(ee110e4)</span></li>
<li>src/org/kde/kdeconnect/Plugins/NotificationsPlugin/AppDatabase.java <span style="color: grey">(45bc9ab)</span></li>
<li>src/org/kde/kdeconnect/Plugins/NotificationsPlugin/NotificationFilterActivity.java <span style="color: grey">(903a320)</span></li>
<li>src/org/kde/kdeconnect/Plugins/NotificationsPlugin/NotificationReceiver.java <span style="color: grey">(537412c)</span></li>
<li>src/org/kde/kdeconnect/Plugins/NotificationsPlugin/NotificationsPlugin.java <span style="color: grey">(03b9c62)</span></li>
<li>src/org/kde/kdeconnect/Plugins/PingPlugin/PingPlugin.java <span style="color: grey">(1b58e80)</span></li>
<li>src/org/kde/kdeconnect/Plugins/Plugin.java <span style="color: grey">(556e89d)</span></li>
<li>src/org/kde/kdeconnect/Plugins/PluginFactory.java <span style="color: grey">(dcd1038)</span></li>
<li>src/org/kde/kdeconnect/Plugins/SftpPlugin/SftpImpl.java <span style="color: grey">(ec41060)</span></li>
<li>src/org/kde/kdeconnect/Plugins/SftpPlugin/SftpPlugin.java <span style="color: grey">(ecf5ca0)</span></li>
<li>src/org/kde/kdeconnect/Plugins/SharePlugin/ShareActivity.java <span style="color: grey">(f409fda)</span></li>
<li>src/org/kde/kdeconnect/Plugins/SharePlugin/SharePlugin.java <span style="color: grey">(0d14cb1)</span></li>
<li>src/org/kde/kdeconnect/Plugins/TelephonyPlugin/TelephonyPlugin.java <span style="color: grey">(f1e5ae2)</span></li>
<li>src/org/kde/kdeconnect/UserInterface/CustomDevicesActivity.java <span style="color: grey">(acb5e63)</span></li>
<li>src/org/kde/kdeconnect/UserInterface/DeviceActivity.java <span style="color: grey">(88aa95c)</span></li>
<li>src/org/kde/kdeconnect/UserInterface/List/ButtonItem.java <span style="color: grey">(a972b8f)</span></li>
<li>src/org/kde/kdeconnect/UserInterface/List/CustomItem.java <span style="color: grey">(927cac3)</span></li>
<li>src/org/kde/kdeconnect/UserInterface/List/DeviceItem.java <span style="color: grey">(247254b)</span></li>
<li>src/org/kde/kdeconnect/UserInterface/List/EntryItem.java <span style="color: grey">(2e3e91d)</span></li>
<li>src/org/kde/kdeconnect/UserInterface/List/ListAdapter.java <span style="color: grey">(df26194)</span></li>
<li>src/org/kde/kdeconnect/UserInterface/List/SectionItem.java <span style="color: grey">(a592b48)</span></li>
<li>src/org/kde/kdeconnect/UserInterface/List/SmallEntryItem.java <span style="color: grey">(2394fbe)</span></li>
<li>src/org/kde/kdeconnect/UserInterface/List/TextItem.java <span style="color: grey">(8848933)</span></li>
<li>src/org/kde/kdeconnect/UserInterface/MainActivity.java <span style="color: grey">(a79d9c0)</span></li>
<li>src/org/kde/kdeconnect/UserInterface/MainSettingsActivity.java <span style="color: grey">(cdfee7b)</span></li>
<li>src/org/kde/kdeconnect/UserInterface/MaxWidthImageButton.java <span style="color: grey">(7f97e58)</span></li>
<li>src/org/kde/kdeconnect/UserInterface/PairActivity.java <span style="color: grey">(7a45751)</span></li>
<li>src/org/kde/kdeconnect/UserInterface/PluginSettingsActivity.java <span style="color: grey">(ba44e4f)</span></li>
<li>src/org/kde/kdeconnect/UserInterface/SettingsActivity.java <span style="color: grey">(06fd373)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/124044/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>