<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/123263/">https://git.reviewboard.kde.org/r/123263/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I don't understand the portable media player part. Does it do something? Besides that, I think we need to fix the issues opened by Lamarque and Alex, but looks good to me :)</pre>
<br />
<p>- Albert Vaca Cintora</p>
<br />
<p>On abril 5th, 2015, 1:56 p.m. PDT, Kai Uwe Broulik wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for kdeconnect, Solid, Albert Vaca Cintora, and Emmanuel Pescosta.</div>
<div>By Kai Uwe Broulik.</div>
<p style="color: grey;"><i>Updated abr. 5, 2015, 1:56 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
solid
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">This adds a KDE Connect backend to Solid enabling us to show phone battery status in the device notifier, and have the phone appear in the device notifier like an external storage.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">It is pretty synchronous at the moment. Any ideas how I could improve that? I guess when someone wants to get devices, it creates a new device interface and calls allDevices() or devicesFromQuery() immediately afterwards, so I cannot just do that stuff async and defer population? Or call deviceAdded for each of the initial ones once I have them?</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">It requires adjustment in the kdeconnect KIO slave so it can handle addresses like kdeconnect://org/kde/kdeconnect/123456 or kdeconnect:udi=/org/kde/kdeconnect/123456 (like mtp kio does) because all Dolphin or the device notifier have is the UDI. It also needs a new device action that matches "Portable Media Player" with the "kdeconnect" protocol, similar to mtp.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">By adjusting the predicate in Dolphin's Places sidebar (and probably the file dialog) to query for the "kdeconnect" protocol, we can have its places automatically updated without having KDE Connect manually mess with KFilePlaces.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">With some crash fixes already pushed to plasma-workspace it works pretty well.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/solid/devices/CMakeLists.txt <span style="color: grey">(9271ae1)</span></li>
<li>src/solid/devices/backends/kdeconnect/CMakeLists.txt <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/solid/devices/backends/kdeconnect/kdeconnectbattery.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/solid/devices/backends/kdeconnect/kdeconnectbattery.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/solid/devices/backends/kdeconnect/kdeconnectdevice.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/solid/devices/backends/kdeconnect/kdeconnectdevice.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/solid/devices/backends/kdeconnect/kdeconnectdeviceinterface.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/solid/devices/backends/kdeconnect/kdeconnectdeviceinterface.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/solid/devices/backends/kdeconnect/kdeconnectmanager.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/solid/devices/backends/kdeconnect/kdeconnectmanager.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/solid/devices/backends/kdeconnect/kdeconnectportablemediaplayer.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/solid/devices/backends/kdeconnect/kdeconnectportablemediaplayer.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/solid/devices/managerbase.cpp <span style="color: grey">(eee4de5)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/123263/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>