<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/121708/">https://git.reviewboard.kde.org/r/121708/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On January 4th, 2015, 9:15 a.m. UTC, <b>Albert Vaca Cintora</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I've been thinking about ways to implement this without requesting new permissions, and I think we could do it with some changes. If it's not absolutely necessary we should try to avoid adding new permisions. My idea is to just ring the phone without starting a new activity, and stop ringing when the user unlocks the phone or turns on the screen (ACTION_SCREEN_ON event). Do you like this approach?</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Also, I would add a timer to stop ringing after 10 or 15 seconds even if you don't unlock it, just in case.</p></pre>
</blockquote>
<p>On January 4th, 2015, 10:39 p.m. UTC, <b>Apoorv Parle</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">The whole intent of adding the wake lock permissions was because it is much easier to find the phone when its screen is turned on (especially in a dark room with only your laptop lights). That is why I added the wake lock permissions. Otherwise, yes I can explore this action and remove the wake lock. Let me know your thoughts...
In current case, the ringer will stop ringing automatically once the media file finishes. I suppose I can loop the media and add a stop duration. I think 15s is too short to search a phone in a house, maybe 30s ?</p></pre>
</blockquote>
<p>On April 16th, 2015, 5:48 a.m. UTC, <b>Ashish Bansal</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">May be you can use key down event(onKeyDown) and stop ringing the phone when any key has been pressed(power key, home key) as that would mean you have found your phone. That way It would not need any new permissions and also no activity would be required to start or to stop ringing the phone.</p></pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">And also save the Alarm Stream volume, increase it to max on receive message and change it back to initial volume when phone has been found.</p></pre>
<br />
<p>- Ashish</p>
<br />
<p>On December 28th, 2014, 6:28 a.m. UTC, Apoorv Parle wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for kdeconnect and Albert Vaca Cintora.</div>
<div>By Apoorv Parle.</div>
<p style="color: grey;"><i>Updated Dec. 28, 2014, 6:28 a.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kdeconnect-android
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><ul style="padding: 0;text-rendering: inherit;margin: 0 0 0 1em;line-height: inherit;white-space: normal;">
<li style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;">Uses Alarm Stream so that it is not affected by music player volumes and silent mode. Because alarm stream is used, if alarm stream volume is 0, no sound will be heard.</li>
<li style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;">Chooses Alarm tone by default but falls back to ringtone if unavailable.</li>
<li style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;">Additional activity to disable ringing once phone is found.</li>
<li style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;">Extra wakelock permission required to display the activity above lockscreen.</li>
</ul>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Known Issues:
* Speaker phone is not used if earphones are connected.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">All testing done on Android 4.4.4 device.
<em style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;"> Tested behaviour with and without screen locked.
</em> Tested behaviour with multiple ring requests.
<em style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;"> Tested behaviour with all on-screen buttons.
</em> Tested silent mode.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Not tested:
* Behaviour when there is no default alarm tone set.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>res/layout/activity_findmyphone.xml <span style="color: grey">(PRE-CREATION)</span></li>
<li>AndroidManifest.xml <span style="color: grey">(6cbe4a7830cfe416fe98e42be143c0f26f2bf1e8)</span></li>
<li>res/values/strings.xml <span style="color: grey">(8d154b359edf2e2b082b51a8d0dbd2eae98a358c)</span></li>
<li>src/org/kde/kdeconnect/NetworkPackage.java <span style="color: grey">(40f29c88ca14e042bd229331a47a02f2967a54f8)</span></li>
<li>src/org/kde/kdeconnect/Plugins/FindMyPhonePlugin/FindMyPhoneActivity.java <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/org/kde/kdeconnect/Plugins/FindMyPhonePlugin/FindMyPhonePlugin.java <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/org/kde/kdeconnect/Plugins/PluginFactory.java <span style="color: grey">(6f51d1d9d138e6843948971052b5d665867a5ceb)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/121708/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>