<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/123208/">https://git.reviewboard.kde.org/r/123208/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On April 1st, 2015, 3 p.m. CEST, <b>Aleix Pol Gonzalez</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Isn't the share plugin doing this already?</p></pre>
</blockquote>
<p>On April 1st, 2015, 3:09 p.m. CEST, <b>Ashish Bansal</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Ah, yeah it is incrementing the destination file name if it exists, I just got to know this. But I wonder why it didn't work for me. I was getting error file already exists from kdeconnect core.</p></pre>
</blockquote>
<p>On April 1st, 2015, 3:32 p.m. CEST, <b>Ashish Bansal</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Well Is something wrong with my system or everyone has same problem?</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Code:
qCDebug(KDECONNECT_PLUGIN_SHARE) << destination.toString();
qCDebug(KDECONNECT_PLUGIN_SHARE) << "islocalfile" << destination.isLocalFile();
qCDebug(KDECONNECT_PLUGIN_SHARE) << "exists" << QFile::exists(destination.toLocalFile());
while (destination.isLocalFile() && QFile::exists(destination.toLocalFile())) {
and konsole output :</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">kdeconnect.plugin.share: File transfer
kdeconnect.plugin.share: "/home/phantom/Downloads/datafile"
kdeconnect.plugin.share: islocalfile false
kdeconnect.plugin.share: exists false
kdeconnect.plugin.share: "/home/phantom/Downloads/datafile"
Destination QUrl QUrl( "/home/phantom/Downloads/datafile" ) lacks a scheme. Setting its scheme to 'file'.
kdeconnect.core: FileTransferJob Downloading payload to QUrl( "/home/phantom/Downloads/datafile" )
kdeconnect.core: file already exists
kdeconnect.plugin.share: File transfer finished</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">But that file exists and this same thing comes out to be true, true in filetransfer.cpp
I don't know how it is possible O.o</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">diff(in case someone is damn lazy ;P) : http://ix.io/hfw</p></pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">This:
kdeconnect.plugin.share: "/home/phantom/Downloads/datafile"</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Should be:
"file:///home/phantom/Downloads/datafile"</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">It misses a fromLocalFile, I'll add it right away.</p></pre>
<br />
<p>- Aleix</p>
<br />
<p>On April 1st, 2015, 2:58 p.m. CEST, Ashish Bansal wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for kdeconnect, Albert Vaca Cintora and Aleix Pol Gonzalez.</div>
<div>By Ashish Bansal.</div>
<p style="color: grey;"><i>Updated April 1, 2015, 2:58 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kdeconnect-kde
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">During file transfer, If file already exists, it just gives error and transfer fails. Instead it should create new file with different name and proceed the file transfer.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">works fine!</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>core/filetransferjob.cpp <span style="color: grey">(73bad79)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/123208/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>