<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/123042/">https://git.reviewboard.kde.org/r/123042/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On March 19th, 2015, 3:08 p.m. GMT, <b>Alex Richardson</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="https://git.reviewboard.kde.org/r/123042/diff/1/?file=355576#file355576line5" style="color: black; font-weight: bold; text-decoration: underline;">KDEConnectMacros.cmake</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">5</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="c"># Thoroughly inspired in kdevplatform_add_plugin</span></pre></td>
</tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Shouldn't we add this to ECM?
Having it here for now is fine, but in the long run this macro should be used everywhere.</p></pre>
</blockquote>
<p>On March 19th, 2015, 3:12 p.m. GMT, <b>Aleix Pol Gonzalez</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">We can consider to, I'm unsure how generic that is. There's some important things going on there, like the dependency between the cpp file and the json file... I'm unsure.</p></pre>
</blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;"><code style="text-rendering: inherit;color: #4444cc;padding: 0;white-space: normal;margin: 0;line-height: inherit;">ecm_add_plugin()</code> would probably be too generic, but <code style="text-rendering: inherit;color: #4444cc;padding: 0;white-space: normal;margin: 0;line-height: inherit;">maybe ecm_add_qt_plugin()</code>?
If we also grep for Q_PLUGIN_METADATA() and add a parameter PLUGIN_MACRO it should be usable for other projects that use Qt only or a special macro (e.g. OKULAR_EXPORT_PLUGIN).</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Alternatively we could add it to kcoreaddons so that it is usable for all KDE applications.</p></pre>
<br />
<p>- Alex</p>
<br />
<p>On March 19th, 2015, 2:49 a.m. GMT, Aleix Pol Gonzalez wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for kdeconnect and Alex Richardson.</div>
<div>By Aleix Pol Gonzalez.</div>
<p style="color: grey;"><i>Updated March 19, 2015, 2:49 a.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kdeconnect-kde
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Uses KPluginLoader+KPluginMetadata instead.
Describes plugins in json instead of desktop files. These desktop files are then embedded into the .so file. All the plugins will be in a kdeconnect/ directory, and those will be the ones to look for.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Note it doesn't drop the KService dependency as KIOCore is a KDE Connect dependency as well.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">All plugins are still loaded.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>CMakeLists.txt <span style="color: grey">(b81a476)</span></li>
<li>KDEConnectMacros.cmake <span style="color: grey">(PRE-CREATION)</span></li>
<li>core/daemon.h <span style="color: grey">(70f9abb)</span></li>
<li>core/device.cpp <span style="color: grey">(0845c45)</span></li>
<li>core/pluginloader.h <span style="color: grey">(e92b73e)</span></li>
<li>core/pluginloader.cpp <span style="color: grey">(b6f0139)</span></li>
<li>interfaces/CMakeLists.txt <span style="color: grey">(78cc9f2)</span></li>
<li>kcm/kcm.cpp <span style="color: grey">(806d99f)</span></li>
<li>plugins/battery/CMakeLists.txt <span style="color: grey">(d2a4237)</span></li>
<li>plugins/battery/batteryplugin.cpp <span style="color: grey">(3202156)</span></li>
<li>plugins/battery/kdeconnect_battery.desktop <span style="color: grey">(9601e04)</span></li>
<li>plugins/battery/kdeconnect_battery.json <span style="color: grey">(PRE-CREATION)</span></li>
<li>plugins/clipboard/CMakeLists.txt <span style="color: grey">(3f8ef3c)</span></li>
<li>plugins/clipboard/clipboardplugin.cpp <span style="color: grey">(f9b2715)</span></li>
<li>plugins/clipboard/kdeconnect_clipboard.desktop <span style="color: grey">(94faa78)</span></li>
<li>plugins/clipboard/kdeconnect_clipboard.json <span style="color: grey">(PRE-CREATION)</span></li>
<li>plugins/mousepad/CMakeLists.txt <span style="color: grey">(a0994fb)</span></li>
<li>plugins/mousepad/kdeconnect_mousepad.desktop <span style="color: grey">(d6c68cf)</span></li>
<li>plugins/mousepad/kdeconnect_mousepad.json <span style="color: grey">(PRE-CREATION)</span></li>
<li>plugins/mousepad/mousepadplugin.cpp <span style="color: grey">(958a288)</span></li>
<li>plugins/mpriscontrol/CMakeLists.txt <span style="color: grey">(f10c502)</span></li>
<li>plugins/mpriscontrol/kdeconnect_mpriscontrol.desktop <span style="color: grey">(e9d4e3c)</span></li>
<li>plugins/mpriscontrol/kdeconnect_mpriscontrol.json <span style="color: grey">(PRE-CREATION)</span></li>
<li>plugins/mpriscontrol/mpriscontrolplugin.cpp <span style="color: grey">(7d705e7)</span></li>
<li>plugins/notifications/CMakeLists.txt <span style="color: grey">(9f56471)</span></li>
<li>plugins/notifications/kdeconnect_notifications.desktop <span style="color: grey">(040f5fe)</span></li>
<li>plugins/notifications/kdeconnect_notifications.json <span style="color: grey">(PRE-CREATION)</span></li>
<li>plugins/notifications/notificationsplugin.cpp <span style="color: grey">(9af82e1)</span></li>
<li>plugins/pausemusic/CMakeLists.txt <span style="color: grey">(2f9f42b)</span></li>
<li>plugins/pausemusic/kdeconnect_pausemusic.desktop <span style="color: grey">(31e40d3)</span></li>
<li>plugins/pausemusic/kdeconnect_pausemusic.json <span style="color: grey">(PRE-CREATION)</span></li>
<li>plugins/pausemusic/pausemusicplugin.cpp <span style="color: grey">(b6cf34a)</span></li>
<li>plugins/ping/CMakeLists.txt <span style="color: grey">(7628fd8)</span></li>
<li>plugins/ping/kdeconnect_ping.desktop <span style="color: grey">(46959a1)</span></li>
<li>plugins/ping/kdeconnect_ping.json <span style="color: grey">(PRE-CREATION)</span></li>
<li>plugins/ping/pingplugin.cpp <span style="color: grey">(519bee5)</span></li>
<li>plugins/screensaver-inhibit/CMakeLists.txt <span style="color: grey">(f7bda44)</span></li>
<li>plugins/screensaver-inhibit/kdeconnect_screensaver_inhibit.desktop <span style="color: grey">(d2773fd)</span></li>
<li>plugins/screensaver-inhibit/kdeconnect_screensaver_inhibit.json <span style="color: grey">(PRE-CREATION)</span></li>
<li>plugins/screensaver-inhibit/screensaverinhibitplugin.cpp <span style="color: grey">(4d74fb4)</span></li>
<li>plugins/sftp/CMakeLists.txt <span style="color: grey">(1f5123c)</span></li>
<li>plugins/sftp/kdeconnect_sftp.desktop <span style="color: grey">(7ad412c)</span></li>
<li>plugins/sftp/kdeconnect_sftp.json <span style="color: grey">(PRE-CREATION)</span></li>
<li>plugins/sftp/sftpplugin.cpp <span style="color: grey">(88f8a36)</span></li>
<li>plugins/share/CMakeLists.txt <span style="color: grey">(7016e26)</span></li>
<li>plugins/share/kdeconnect_share.desktop <span style="color: grey">(7433061)</span></li>
<li>plugins/share/kdeconnect_share.json <span style="color: grey">(PRE-CREATION)</span></li>
<li>plugins/share/shareplugin.cpp <span style="color: grey">(049f57d)</span></li>
<li>plugins/telephony/CMakeLists.txt <span style="color: grey">(8db5629)</span></li>
<li>plugins/telephony/kdeconnect_telephony.desktop <span style="color: grey">(d44b595)</span></li>
<li>plugins/telephony/kdeconnect_telephony.json <span style="color: grey">(PRE-CREATION)</span></li>
<li>plugins/telephony/telephonyplugin.cpp <span style="color: grey">(e8d9ad5)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/123042/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>