<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/122927/">https://git.reviewboard.kde.org/r/122927/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for kdeconnect and Aleix Pol Gonzalez.</div>
<div>By Albert Vaca Cintora.</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kdeconnect-kde
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Centralizing the plugins' config will ensure that all the plugins store it
the same way. The base KCM class, together with the already existing base
plugin class, will give access to all the plugins to this centralized
config. Also, now the settings are not shared across devices (that is:
every device can have different config for a same plugin).</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>core/CMakeLists.txt <span style="color: grey">(95b8bd84fb995ccf9dda3f953378beac8cd285ed)</span></li>
<li>core/kdeconnectconfig.h <span style="color: grey">(d1e721a1e3d4851a8a5b769654e6cc69af9fd6d1)</span></li>
<li>core/kdeconnectconfig.cpp <span style="color: grey">(b165f4dbbf082b709bc51a05becc7d799c48e44e)</span></li>
<li>core/kdeconnectplugin.h <span style="color: grey">(564786c296a2643d5e9d1b0c131aa5276668bea2)</span></li>
<li>core/kdeconnectplugin.cpp <span style="color: grey">(e7f72c60b032843af296de6fcdc0edb70d8ad593)</span></li>
<li>core/kdeconnectpluginconfig.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>core/kdeconnectpluginconfig.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>core/pluginloader.cpp <span style="color: grey">(37bd4baacc08d56f036cd7c74c4b65fb4ab3a97e)</span></li>
<li>kcm/CMakeLists.txt <span style="color: grey">(03796a06ab377a0b997badc81abc0bc250ff0297)</span></li>
<li>kcm/kcm.cpp <span style="color: grey">(8c377fa8c3ec54010c8d50880ca0e1dbb96bbeb0)</span></li>
<li>kcmplugin/CMakeLists.txt <span style="color: grey">(PRE-CREATION)</span></li>
<li>kcmplugin/kdeconnectpluginkcm.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>kcmplugin/kdeconnectpluginkcm.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>plugins/pausemusic/CMakeLists.txt <span style="color: grey">(44d0902f6a9bc229cdb5b06352e8388bfb24f58d)</span></li>
<li>plugins/pausemusic/pausemusic_config.h <span style="color: grey">(075e2958d7f0198c9402456c81f02fc11f5999e3)</span></li>
<li>plugins/pausemusic/pausemusic_config.cpp <span style="color: grey">(03dacf9ab79b1f1ef3d0c12adf675e710de94821)</span></li>
<li>plugins/pausemusic/pausemusicplugin.cpp <span style="color: grey">(a9cdc681183e372f3ff029a263024f3e99468385)</span></li>
<li>plugins/share/CMakeLists.txt <span style="color: grey">(4783864902773106afa40f7d7b55706a879bab27)</span></li>
<li>plugins/share/share_config.h <span style="color: grey">(7743fcc9c1f0f8d162a66dfbc048cdd71610b826)</span></li>
<li>plugins/share/share_config.cpp <span style="color: grey">(397547ac15e2cc1578359b7e0dee0bbf1abeb429)</span></li>
<li>plugins/share/shareplugin.cpp <span style="color: grey">(2c1566bd11a080dd711e01b75cd5d93bc722ee44)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/122927/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>