<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/122486/">https://git.reviewboard.kde.org/r/122486/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On February 15th, 2015, 11:52 a.m. UTC, <b>Vineet Garg</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">It's working quite fine, but I found some problems with it.
There is no point in dismissing notification when the app is exited. The real point of showing notification is lost by this. So adding a dismiss button at top right would be good.
The white notification seems very odd on black background, may be it will work correct on Lollipop but try to use system default theme.
A notification is shown even when there are no players, it's little bit odd.Try to dismiss notification in that situation.</p></pre>
</blockquote>
<p>On February 16th, 2015, 4:38 p.m. UTC, <b>Chandramouleshwar Sanivarapu</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I will take care of all these bugs.
I am currently trying to dimsiss the notification when:
1. When no players are detected
2. When connection is lost
3. When unpaired
If there are any other conditions please let me know.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I think there is porblem with onConnectionLost function. In Mpris activity, when the phone is locked and unlocked, in 'connectionReceiver', onConnectionLost is being called multiple times while onConnectionReceived is being called only once. Please check this once.</p></pre>
</blockquote>
<p>On February 16th, 2015, 8:34 p.m. UTC, <b>Albert Vaca Cintora</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">This was a bug that should be fixed now. It was fixed in the master branch and I merged it into this branch so you can pull and get the fix. Did you pull?</p></pre>
</blockquote>
<p>On February 17th, 2015, 10:14 a.m. UTC, <b>Chandramouleshwar Sanivarapu</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Yes..I pulled and i can still see the problem.</p></pre>
</blockquote>
<p>On February 17th, 2015, 10:32 a.m. UTC, <b>Chandramouleshwar Sanivarapu</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">And also I noticed that when I was in 'Mpris' Activity and I disconneced my laptop from the wifi, I can still see the player name in the app. Same thing happens when i disconnect my mobile from Wifi.</p></pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">That is because there is no implementation to change this in onConnectionLost. Also connectionReciever is added onCreation of activity and removed when the activity is destroyed. That is why you may have problem with onConnectionLost function.</p></pre>
<br />
<p>- Vineet</p>
<br />
<p>On February 14th, 2015, 3:39 p.m. UTC, Chandramouleshwar Sanivarapu wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for kdeconnect and Albert Vaca Cintora.</div>
<div>By Chandramouleshwar Sanivarapu.</div>
<p style="color: grey;"><i>Updated Feb. 14, 2015, 3:39 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kdeconnect-android
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Fixed some bugs in mpris notification in the 'feature/noti-mediacontrol' branch</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">1.Merge mester in this branch
2.Dismiss the notification on closing the app
3.Dismiss the notification when the music player is closed
4.Make the notification visible in lockscreen lollipop
5.Chage the background and icon of the notification
6.Add expandable notification</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">All testings done on android 4.4.4
All the above noted features worked well on the device.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Not tested:
Lockscreen notification in lollipop</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>res/layout/mpris_big_notification.xml <span style="color: grey">(PRE-CREATION)</span></li>
<li>res/layout/mpris_notification.xml <span style="color: grey">(c70d760)</span></li>
<li>res/values-ar/strings.xml <span style="color: grey">(PRE-CREATION)</span></li>
<li>res/values-bg/strings.xml <span style="color: grey">(730b47b)</span></li>
<li>res/values-bs/strings.xml <span style="color: grey">(94d7918)</span></li>
<li>res/values-ca/strings.xml <span style="color: grey">(277abe4)</span></li>
<li>res/values-cs/strings.xml <span style="color: grey">(74f5bcd)</span></li>
<li>res/values-da/strings.xml <span style="color: grey">(94ae3bd)</span></li>
<li>res/values-de/strings.xml <span style="color: grey">(7f290b2)</span></li>
<li>res/values-es/strings.xml <span style="color: grey">(cffb85a)</span></li>
<li>res/values-fi/strings.xml <span style="color: grey">(4c845bf)</span></li>
<li>res/values-fr/strings.xml <span style="color: grey">(9596ce2)</span></li>
<li>res/values-hu/strings.xml <span style="color: grey">(87127a9)</span></li>
<li>res/values-it/strings.xml <span style="color: grey">(8e26ec9)</span></li>
<li>res/values-ja/strings.xml <span style="color: grey">(7c4d5ac)</span></li>
<li>res/values-ko/strings.xml <span style="color: grey">(ff2c9cc)</span></li>
<li>res/values-lt/strings.xml <span style="color: grey">(7c4d5ac)</span></li>
<li>res/values-nl/strings.xml <span style="color: grey">(3696834)</span></li>
<li>res/values-pl/strings.xml <span style="color: grey">(3545803)</span></li>
<li>res/values-pt-rBR/strings.xml <span style="color: grey">(d5f4656)</span></li>
<li>res/values-pt/strings.xml <span style="color: grey">(2076573)</span></li>
<li>res/values-ro/strings.xml <span style="color: grey">(56a15b8)</span></li>
<li>res/values-ru/strings.xml <span style="color: grey">(d914c38)</span></li>
<li>res/values-sk/strings.xml <span style="color: grey">(9b4b984)</span></li>
<li>res/values-sv/strings.xml <span style="color: grey">(75cd035)</span></li>
<li>res/values-uk/strings.xml <span style="color: grey">(2b039d4)</span></li>
<li>res/values/dimens.xml <span style="color: grey">(47c8224)</span></li>
<li>res/values/strings.xml <span style="color: grey">(23d10dc)</span></li>
<li>res/values/styles.xml <span style="color: grey">(bf65b14)</span></li>
<li>src/org/kde/kdeconnect/Backends/BaseLink.java <span style="color: grey">(242ff67)</span></li>
<li>src/org/kde/kdeconnect/Backends/LanBackend/LanLink.java <span style="color: grey">(ca81c13)</span></li>
<li>src/org/kde/kdeconnect/Backends/LanBackend/LanLinkProvider.java <span style="color: grey">(19038bb)</span></li>
<li>src/org/kde/kdeconnect/Backends/LoopbackBackend/LoopbackLink.java <span style="color: grey">(0461cf1)</span></li>
<li>src/org/kde/kdeconnect/Device.java <span style="color: grey">(b9a876b)</span></li>
<li>src/org/kde/kdeconnect/Plugins/MprisPlugin/MprisActivity.java <span style="color: grey">(b601ddd)</span></li>
<li>src/org/kde/kdeconnect/Plugins/MprisPlugin/NotificationPanel.java <span style="color: grey">(ec4e83d)</span></li>
<li>src/org/kde/kdeconnect/Plugins/MprisPlugin/RemoteControlClientManager.java <span style="color: grey">(e1da548)</span></li>
<li>src/org/kde/kdeconnect/Plugins/NotificationsPlugin/AppDatabase.java <span style="color: grey">(2dbc249)</span></li>
<li>src/org/kde/kdeconnect/Plugins/NotificationsPlugin/NotificationFilterActivity.java <span style="color: grey">(0beff93)</span></li>
<li>src/org/kde/kdeconnect/Plugins/NotificationsPlugin/NotificationsPlugin.java <span style="color: grey">(add8ecf)</span></li>
<li>src/org/kde/kdeconnect/Plugins/SharePlugin/SharePlugin.java <span style="color: grey">(1e7e509)</span></li>
<li>src/org/kde/kdeconnect/Plugins/SharePlugin/ShareToReceiver.java <span style="color: grey">(170b7eb)</span></li>
<li>src/org/kde/kdeconnect/UserInterface/MainActivity.java <span style="color: grey">(de6aee7)</span></li>
<li>AndroidManifest.xml <span style="color: grey">(de48c65)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/122486/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>