<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/122174/">https://git.reviewboard.kde.org/r/122174/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for kdeconnect.</div>
<div>By Saikrishna Arcot.</div>
<p style="color: grey;"><i>Updated Jan. 26, 2015, 2:53 a.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kdeconnect-kde
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Add initial bluetooth backend implementation.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">This is based on the frameworks branch.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">The <code style="text-rendering: inherit;color: #4444cc;padding: 0;white-space: normal;margin: 0;line-height: inherit;">getPairedDevices()</code> method in the link provider class uses D-Bus to get the list of paired devices, since Qt doesn't have a method giving that information. As a result, that part of the code only works on Linux.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Note that the Qt Connectivity package in Ubuntu 14.04 and 14.10 doesn't include support for BlueZ, as it wasn't compiled with the BlueZ headers. I recompiled the package for 14.10 and is available <a href="https://launchpad.net/~saiarcot895/+archive/ubuntu/myppa" style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;">here</a>.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing (updated)</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">KDE Connect runs, and the bluetooth service gets published in the SDP (service discovery protocol), which other devices use to determine what services are available.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Android as client and KDE as server: My Android (4.1.2) sees the KDE connect service and tries to connect to it, but fails most of the time. Sometimes, it succeeds and creates a connection. I haven't been able to find out why it's failing the rest of the time. Newer versions of Android (4.2 and higher) might have better luck, since the Bluetooth code was changed.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">When it does connect, one time, I was able to pair the devices together (from my Android), and was able to send a ping, use the touchpad, and control my media player from my Android. The pairing data doesn't seem to be stored, as Android isn't remembering the KDE (or vice-versa), which may mean I'm missing something in the code.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">For me, sending a pair request from KDE to Android results in KDE Connect crashing on Android. It seems it's because the VIBRATE permission is necessary, which I've added on the Android side.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Android as server and KDE as client: I was able to successfully connect to the Android and use it.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> (updated)</h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>interfaces/modeltest.cpp <span style="color: grey">(40d7d282a8aef0d1c6932ccff5f5ae105ee9ff01)</span></li>
<li>interfaces/notificationsmodel.h <span style="color: grey">(f9a747973e726193ad25b32447c36a357ddc5c9f)</span></li>
<li>interfaces/notificationsmodel.cpp <span style="color: grey">(7ff163821b2d05072ed0321de67f5ef7a3bd6e56)</span></li>
<li>kcm/CMakeLists.txt <span style="color: grey">(0e30819ea5b3e7d23b8804b46b5d07d5c7fa8d4c)</span></li>
<li>kcm/devicessortproxymodel.cpp <span style="color: grey">(929371df4c38db0c83ed8ea7cf7248b701d569f3)</span></li>
<li>kcm/kcm.cpp <span style="color: grey">(2eff3cdad5fccac3130cf137966d6ee30a2037ea)</span></li>
<li>kcm/kcm_kdeconnect.desktop <span style="color: grey">(f626b7825475e4db9bad0ea352884dd052ed4630)</span></li>
<li>kcm/kdeconnect.desktop <span style="color: grey">(336680b9e493332f2c3b9444bbca9ec12928c9fc)</span></li>
<li>kdeconnect-non-plasma.desktop <span style="color: grey">(PRE-CREATION)</span></li>
<li>kded/CMakeLists.txt <span style="color: grey">(4c4e46b34af8d6d2fd82a49a00e5dd31cc9143e9)</span></li>
<li>kded/config-kded.h.cmake <span style="color: grey">(PRE-CREATION)</span></li>
<li>kded/kdeconnect.desktop <span style="color: grey">(1a1200e55d35e190581a2de980fcb3fed8f54ef6)</span></li>
<li>kded/kdeconnectd.cpp <span style="color: grey">(06cec727723e64954d1ed13e5b7f12cd35a6b784)</span></li>
<li>kded/kdeconnectd.desktop.cmake <span style="color: grey">(PRE-CREATION)</span></li>
<li>kded/kded.h <span style="color: grey">(9ae70310de1908862acabba5fa79641cf3f72cd9)</span></li>
<li>kded/kded.cpp <span style="color: grey">(2ec9062e6f95bbe04d3eff18dcbf30c180a58bb5)</span></li>
<li>kded/org.kde.kdeconnect.service.in <span style="color: grey">(9777642945f2ece13fee46819c3b138778ff2128)</span></li>
<li>kio/CMakeLists.txt <span style="color: grey">(b54bb1a2a927017005d37b670618969b05696150)</span></li>
<li>kio/kiokdeconnect.h <span style="color: grey">(ae63c1fb6bcf616444d85c0968dfe5f136b041b2)</span></li>
<li>kio/kiokdeconnect.cpp <span style="color: grey">(b7420934ccfa66efee854a3ae16214f11a8d4129)</span></li>
<li>plasmoid/CMakeLists.txt <span style="color: grey">(3289115e43efde562a7ae169852df8d5f02e71a8)</span></li>
<li>plasmoid/Messages.sh <span style="color: grey">(89e3c4059167121d1327eaed090fff2e70b8419f)</span></li>
<li>plasmoid/declarativeplugin/CMakeLists.txt <span style="color: grey">(615ee533cae740ea806c01d4997e1ba7ec4a4162)</span></li>
<li>plasmoid/declarativeplugin/kdeconnectdeclarativeplugin.h <span style="color: grey">(6324b7aba9f5fb305299e9b16442b7aa563b2704)</span></li>
<li>plasmoid/declarativeplugin/kdeconnectdeclarativeplugin.cpp <span style="color: grey">(0fa00b7b788de8f69962ff9020db37d0fb21f584)</span></li>
<li>plasmoid/declarativeplugin/processrunner.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>plasmoid/declarativeplugin/processrunner.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>plasmoid/declarativeplugin/qmldir <span style="color: grey">(9d5f411cb9dea3a76d7faf356fee150baa2c8854)</span></li>
<li>plasmoid/declarativeplugin/responsewaiter.h <span style="color: grey">(3d2a63dd2cc6aefe984c9b5c899dd4e9b250a391)</span></li>
<li>plasmoid/package/contents/ui/Battery.qml <span style="color: grey">(4b58e2da1604551b33d68ee4f39e2bb0915e5285)</span></li>
<li>plasmoid/package/contents/ui/CompactRepresentation.qml <span style="color: grey">(7614893d8d16eff20777ac62569bb384e2d8e7d3)</span></li>
<li>plasmoid/package/contents/ui/DeviceDelegate.qml <span style="color: grey">(372a1b63eb70ff7fda5ed480d86c1bfa82d6f70f)</span></li>
<li>plasmoid/package/contents/ui/Sftp.qml <span style="color: grey">(5a2437b92db30b9011fc2a320cd5d1adc9c42643)</span></li>
<li>plasmoid/package/contents/ui/kdeconnect.qml <span style="color: grey">(27a594e2f04653fcaffbfd457615f4c1cc63bb27)</span></li>
<li>plasmoid/package/contents/ui/main.qml <span style="color: grey">(PRE-CREATION)</span></li>
<li>plasmoid/package/metadata.desktop <span style="color: grey">(1dbbbd7dc121b9e4a0b9e2469845a1d8ccb2afb8)</span></li>
<li>plugins/CMakeLists.txt <span style="color: grey">(ed1efe0886e4938d2f40aced89e33ddc5c995e48)</span></li>
<li>plugins/battery/CMakeLists.txt <span style="color: grey">(1fea3b7929a12b2679ef2456f10cd2475bb2ac28)</span></li>
<li>plugins/battery/batterydbusinterface.cpp <span style="color: grey">(b3b22dd640658694a38dd9db5b4bd343f9b543cd)</span></li>
<li>plugins/battery/batteryplugin.h <span style="color: grey">(9ab9c509dc433193aecfd42927e2a01667e2ffdc)</span></li>
<li>plugins/battery/batteryplugin.cpp <span style="color: grey">(975ebaefad611da822468d8b73e47e3c3c3e838f)</span></li>
<li>plugins/clipboard/CMakeLists.txt <span style="color: grey">(b6624a03c0a5ee9b1b722c8565c786fffad06ff3)</span></li>
<li>plugins/clipboard/clipboardplugin.cpp <span style="color: grey">(655cb104f52aecfac69e18697ba5718f6a6b5482)</span></li>
<li>core/device.cpp <span style="color: grey">(c4043182b8d6dd47fa1d19f8097fe1fb68489bfa)</span></li>
<li>CMakeLists.txt <span style="color: grey">(5b916d929dfa3f3304a8ac84e7ef6c19f9aa4663)</span></li>
<li>cli/CMakeLists.txt <span style="color: grey">(0eb84026bb997869c68aae815940f25ed19e04f4)</span></li>
<li>cli/kdeconnect-cli.cpp <span style="color: grey">(b5336aa663a479345b6a9b27d2faf48ef6db7dad)</span></li>
<li>cmake/DbusInterfaceMacros.cmake <span style="color: grey">(9d4810d9540f868d6da6869493deec032afced59)</span></li>
<li>core/CMakeLists.txt <span style="color: grey">(17209b1a801b33d99e31a4b19eac45df2fa6fe02)</span></li>
<li>core/backends/bluetooth/CMakeLists.txt <span style="color: grey">(PRE-CREATION)</span></li>
<li>core/backends/bluetooth/bluetoothdevicelink.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>core/backends/bluetooth/bluetoothdevicelink.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>core/backends/bluetooth/bluetoothlinkprovider.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>core/backends/bluetooth/bluetoothlinkprovider.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>core/backends/devicelinereader.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>core/backends/devicelinereader.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>core/backends/lan/landevicelink.cpp <span style="color: grey">(e344e83747acb8dc0e1f33d1909253886df13d4f)</span></li>
<li>core/backends/lan/lanlinkprovider.cpp <span style="color: grey">(3042ff75a4e4163d9ff78e697e8696612406818c)</span></li>
<li>core/backends/lan/uploadjob.cpp <span style="color: grey">(77641171d24a7a608a8ee2a2e01b7f9b32e58be5)</span></li>
<li>core/backends/loopback/loopbacklinkprovider.cpp <span style="color: grey">(df793a6dde47f4df9be9b564406cb8fe7ad7fce0)</span></li>
<li>core/daemon.h <span style="color: grey">(5f2ae2624532c4dde657d0eda02a7336c73c754d)</span></li>
<li>core/daemon.cpp <span style="color: grey">(57548e5a671b7694125e733db06a58eebbadd264)</span></li>
<li>core/device.h <span style="color: grey">(82ecd81ee12511266c0e55ea7046b87c9a3755d6)</span></li>
<li>icon/CMakeLists.txt <span style="color: grey">(ffc1183c108dcb5a0aa63930e57cf1804c38443e)</span></li>
<li>interfaces/CMakeLists.txt <span style="color: grey">(174c65939ff26bb50268a0e8d1a5bf68ed937b10)</span></li>
<li>interfaces/devicesmodel.h <span style="color: grey">(75ee0c12b217c5a54a00fa460a65b2e81a57fcd1)</span></li>
<li>interfaces/devicesmodel.cpp <span style="color: grey">(bef9db4f3a28e54d6f3092a2ad99a8bdd07fc77b)</span></li>
<li>interfaces/interfaces_debug.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>fileitemactionplugin/sendfileitemaction.cpp <span style="color: grey">(54653b923cde13116481b1110103ed10d0d14ad1)</span></li>
<li>core/filetransferjob.h <span style="color: grey">(b022210b6fe64b064cecbcc84e20a56fdcefe5f9)</span></li>
<li>core/filetransferjob.cpp <span style="color: grey">(2dad5deba790608b3de7ccc2bcec7d8bb575d149)</span></li>
<li>core/kdebugnamespace.h <span style="color: grey">(c7a094a48e0c2b8a0e57e9eeecb443ce2fc03573)</span></li>
<li>core/kdeconnectplugin.h <span style="color: grey">(d73491f5ea7cb9ac114a3995c0f770aeb49ed73f)</span></li>
<li>core/kdeconnectplugin.cpp <span style="color: grey">(620550b214706e70a491d1e15e462e5150dfb460)</span></li>
<li>core/networkpackage.h <span style="color: grey">(5f1cfe87cb9809fce15291f5fdf4ed3d2c653eae)</span></li>
<li>core/networkpackage.cpp <span style="color: grey">(db44658b112183924835923dbe71edc5a500ea5f)</span></li>
<li>core/pluginloader.cpp <span style="color: grey">(12d7864608f6e3c929f745781c1a76d7cf38b938)</span></li>
<li>fileitemactionplugin/CMakeLists.txt <span style="color: grey">(3043f695457fd11a6dd8cc45587f28fd3a313e59)</span></li>
<li>fileitemactionplugin/Messages.sh <span style="color: grey">(118c91208fed047f1478872dabdd056a4a61cd7b)</span></li>
<li>fileitemactionplugin/sendfileitemaction.h <span style="color: grey">(d5dd74b9c99c8e4d937730ecc4df3c1adac66e55)</span></li>
<li>plugins/sftp/sftp_debug.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>plugins/sftp/sftpplugin.cpp <span style="color: grey">(53b818a999d5f6c772c1a90d07a74fbd04c3870f)</span></li>
<li>plugins/share/CMakeLists.txt <span style="color: grey">(ab91134c4cd2ceb8fa71a44a8083e868bb627f20)</span></li>
<li>plugins/share/autoclosingqfile.h <span style="color: grey">(c9673d8d918acf324b6421636fae848eb801206e)</span></li>
<li>plugins/share/share_config.cpp <span style="color: grey">(805f2770201d9461f7fed97dd4e2fd4cab0b30e9)</span></li>
<li>plugins/share/share_config.ui <span style="color: grey">(d6f618fb7295cfdb2cb187a048617e7a30ce378e)</span></li>
<li>plugins/share/share_debug.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>plugins/share/shareplugin.h <span style="color: grey">(72c79d2d924bdc463c6ee70bc578d494cee6a8b5)</span></li>
<li>plugins/share/shareplugin.cpp <span style="color: grey">(2c7c8152ef97e2bc600a04ca88079224e600a428)</span></li>
<li>plugins/telephony/CMakeLists.txt <span style="color: grey">(01b2f9a8654fdb392fd1fcbc4cedae62590c70f8)</span></li>
<li>plugins/telephony/telephonyplugin.h <span style="color: grey">(047d9869f58910492468d5828514e1be183b5a4e)</span></li>
<li>plugins/telephony/telephonyplugin.cpp <span style="color: grey">(5e46ba3bc7caa028083de28d363b2c09f8034b21)</span></li>
<li>tests/CMakeLists.txt <span style="color: grey">(51ad49d481cd1e805a0836ba08fe75891246da35)</span></li>
<li>plugins/sftp/CMakeLists.txt <span style="color: grey">(e6fd20444aad3dfbc6825295172726875ca6d098)</span></li>
<li>plugins/sftp/mounter.cpp <span style="color: grey">(c414f77b1aefbbbfe14b35eea0ae7e1b6bee644a)</span></li>
<li>plugins/sftp/sftp_config.cpp <span style="color: grey">(c996dd3f85898b9e4cba0719995d030151ff3d2a)</span></li>
<li>plugins/ping/CMakeLists.txt <span style="color: grey">(0f6f0ac3e12f611fec4b6e83d0dd74355cc931b4)</span></li>
<li>plugins/ping/pingplugin.h <span style="color: grey">(614da48504dfd42431175dd40c66bde28534706b)</span></li>
<li>plugins/ping/pingplugin.cpp <span style="color: grey">(042a953cb3d9ba210a30630cc68a779ac170e8bf)</span></li>
<li>plugins/screensaver-inhibit/CMakeLists.txt <span style="color: grey">(2f0d56d5677a478b9ae0c770f88705cb43563ad7)</span></li>
<li>plugins/screensaver-inhibit/screensaverinhibitplugin.h <span style="color: grey">(460ac6023f228d1d2925ed7a236684a07cd63f5f)</span></li>
<li>plugins/screensaver-inhibit/screensaverinhibitplugin.cpp <span style="color: grey">(85ac1995faee53b6e5288a2b79f892b1891d403b)</span></li>
<li>plugins/mousepad/mousepadplugin.cpp <span style="color: grey">(cf5f70ec9836b69c9db7875c75a9c96bd4f918cb)</span></li>
<li>plugins/mpriscontrol/CMakeLists.txt <span style="color: grey">(d5332fab6cb3f5832984c3ed077259ddcc067005)</span></li>
<li>plugins/mpriscontrol/mpriscontrolplugin.h <span style="color: grey">(737abc5f14783dc82a67c3ca5f155d2a0b6221b1)</span></li>
<li>plugins/mpriscontrol/mpriscontrolplugin.cpp <span style="color: grey">(003ad4227594b63f3549bd93dc345ed7c293d02d)</span></li>
<li>plugins/mpriscontrol/propertiesInterface.xml <span style="color: grey">(5118061546aa72b204a86a3fe73bdea88ed4bb7c)</span></li>
<li>plugins/notifications/CMakeLists.txt <span style="color: grey">(cfd271d22c9ba7379181ffd8268723c75bad598a)</span></li>
<li>plugins/notifications/notification.cpp <span style="color: grey">(3c15d47dcd263c0999717c827db6dd9dadabacd5)</span></li>
<li>plugins/notifications/notification_debug.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>plugins/notifications/notificationsdbusinterface.cpp <span style="color: grey">(84a71a73e09b899e5821132c8032b179f37d2c23)</span></li>
<li>plugins/notifications/notificationsplugin.cpp <span style="color: grey">(1387a7e05a892797c83d85831078096b3a111697)</span></li>
<li>plugins/pausemusic/CMakeLists.txt <span style="color: grey">(337e952460bc8b9ed6dff9729df2555b4d72f3dd)</span></li>
<li>plugins/pausemusic/pausemusic_config.cpp <span style="color: grey">(dc24b271514c9ac0b795f0869088368e37ca0b13)</span></li>
<li>plugins/pausemusic/pausemusicplugin.h <span style="color: grey">(aba9eb5ce423f966ef8c7bcba3660d5c41e40524)</span></li>
<li>plugins/pausemusic/pausemusicplugin.cpp <span style="color: grey">(c0e1859dde59b7013d55cdc4f0165fe418566efa)</span></li>
<li>plugins/mousepad/mousepadplugin.h <span style="color: grey">(2135123f860431b2ba73273e648d19b8fa4e3390)</span></li>
<li>plugins/mousepad/fixx11h.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>tests/networkpackagetests.cpp <span style="color: grey">(8f6f8ac7b57ff08162d882e8238b9125dab5873e)</span></li>
<li>plugins/clipboard/clipboardplugin.h <span style="color: grey">(c02859abcd376b35ba8b75b655940b5dc8267d1a)</span></li>
<li>plugins/mousepad/CMakeLists.txt <span style="color: grey">(02f36ab72e48232e172698f54b624ba0ae17cdfd)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/122174/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>