<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/121706/">https://git.reviewboard.kde.org/r/121706/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for kdeconnect and Albert Vaca Cintora.</div>
<div>By Apoorv Parle.</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kdeconnect-kde
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><ul style="padding: 0;text-rendering: inherit;margin: 0 0 0 1em;line-height: inherit;white-space: normal;">
<li style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;">FindMyPhone plugin itself.</li>
<li style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;">Plasmoid updated to include a button to ring the phone.</li>
<li style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;">Add -ring switch to CLI interface.</li>
</ul></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><ul style="padding: 0;text-rendering: inherit;margin: 0 0 0 1em;line-height: inherit;white-space: normal;">
<li style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;">Tested on KDE 4.14.2</li>
<li style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;">Plugin is non-blocking i.e. other plugins like browse work fine while the phone is ringing.</li>
<li style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;">Enable/Disable of the plugin has been tested. The button appears/disappears correspondingly.</li>
</ul></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>cli/kdeconnect-cli.cpp <span style="color: grey">(b5336aa663a479345b6a9b27d2faf48ef6db7dad)</span></li>
<li>interfaces/CMakeLists.txt <span style="color: grey">(174c65939ff26bb50268a0e8d1a5bf68ed937b10)</span></li>
<li>interfaces/dbusinterfaces.h <span style="color: grey">(702d6bb103c64b640cb5a4f6beab56496c6c4de9)</span></li>
<li>interfaces/dbusinterfaces.cpp <span style="color: grey">(c9b09fd259dbd4a66b4eaff94e16ab651d51c657)</span></li>
<li>plasmoid/declarativeplugin/kdeconnectdeclarativeplugin.cpp <span style="color: grey">(0fa00b7b788de8f69962ff9020db37d0fb21f584)</span></li>
<li>plasmoid/package/contents/ui/DeviceDelegate.qml <span style="color: grey">(372a1b63eb70ff7fda5ed480d86c1bfa82d6f70f)</span></li>
<li>plasmoid/package/contents/ui/FindMyPhone.qml <span style="color: grey">(PRE-CREATION)</span></li>
<li>plugins/CMakeLists.txt <span style="color: grey">(de1131d224c453f86f79c74cb7d720cd8116e1c7)</span></li>
<li>plugins/findmyphone/CMakeLists.txt <span style="color: grey">(PRE-CREATION)</span></li>
<li>plugins/findmyphone/README <span style="color: grey">(PRE-CREATION)</span></li>
<li>plugins/findmyphone/findmyphoneplugin.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>plugins/findmyphone/findmyphoneplugin.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>plugins/findmyphone/kdeconnect_findmyphone.desktop <span style="color: grey">(PRE-CREATION)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/121706/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>