<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/121104/">https://git.reviewboard.kde.org/r/121104/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Ship It!</p></pre>
<br />
<p>- Achilleas Koutsou</p>
<br />
<p>On November 21st, 2014, 1:41 a.m. EET, Achilleas Koutsou wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for kdeconnect.</div>
<div>By Achilleas Koutsou.</div>
<p style="color: grey;"><i>Updated Nov. 21, 2014, 1:41 a.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=326509">326509</a>
</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kdeconnect-android
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Created new backend (CustomLinkBackend) which reads a list of user-specified IP addresses or host names and attempts to send KDE-connect packets to them, bypassing the autodiscovery which usually happens via broadcast packets. This allows for the pairing and communication between two devices which are connected via a gateway (or route) that does not allow broadcasts (e.g., OpenVPN in tunnel mode, separate networks). This patch also adds a new menu and activity for adding and removing IP addresses and hostnames (Custom device list).</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">This resolves <a href="https://bugs.kde.org/show_bug.cgi?id=326509" style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;">bug 326509</a>.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/main/AndroidManifest.xml <span style="color: grey">(886e27c)</span></li>
<li>src/main/java/org/kde/kdeconnect/Backends/LanBackend/LanLinkProvider.java <span style="color: grey">(ae990ee)</span></li>
<li>src/main/java/org/kde/kdeconnect/UserInterface/CustomDevicesActivity.java <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/main/java/org/kde/kdeconnect/UserInterface/MainActivity.java <span style="color: grey">(a2c6c6d)</span></li>
<li>src/main/res/layout/custom_ip_list.xml <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/main/res/menu/main.xml <span style="color: grey">(189b036)</span></li>
<li>src/main/res/values/strings.xml <span style="color: grey">(5801b31)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/121104/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>