<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/120005/">https://git.reviewboard.kde.org/r/120005/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On August 31st, 2014, 12:04 a.m. UTC, <b>Aleix Pol Gonzalez</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="https://git.reviewboard.kde.org/r/120005/diff/2/?file=308640#file308640line76" style="color: black; font-weight: bold; text-decoration: underline;">src/main/res/values/strings.xml</a>
<span style="font-weight: normal;">
(Diff revision 2)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">76</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="nt"><string</span> <span class="na">name=</span><span class="s">"mpris_time_settings_title"</span><span class="nt">></span>Interval Time<span class="nt"></string></span></pre></td>
</tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Is that really something you'd want as a configuration? Maybe the UI should just be extended?</p></pre>
</blockquote>
<p>On September 2nd, 2014, 8:31 a.m. UTC, <b>Albert Vaca Cintora</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I like the patch to be able to have settings per-plugin, and even though I agree with you that this doesn't make much sense as a setting, I can't see a way to put it in the normal UI. Do you have any idea?</p></pre>
</blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">A long tap could open a dialog asking how much it needs to jump, for example.</p></pre>
<br />
<p>- Aleix</p>
<br />
<p>On August 30th, 2014, 4:04 p.m. UTC, Ronny Yabar Aizcorbe wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for kdeconnect.</div>
<div>By Ronny Yabar Aizcorbe.</div>
<p style="color: grey;"><i>Updated Aug. 30, 2014, 4:04 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kdeconnect-android
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Added support for specific plugin UI settings. Added interval time preferences to fast forward or rewind a multimedia file instead of harcording the time.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Checked and tested. Works well.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/main/AndroidManifest.xml <span style="color: grey">(499e92e)</span></li>
<li>src/main/java/org/kde/kdeconnect/Plugins/BatteryPlugin/BatteryPlugin.java <span style="color: grey">(7761c21)</span></li>
<li>src/main/java/org/kde/kdeconnect/Plugins/ClibpoardPlugin/ClipboardPlugin.java <span style="color: grey">(68315ff)</span></li>
<li>src/main/java/org/kde/kdeconnect/Plugins/MousePadPlugin/MousePadPlugin.java <span style="color: grey">(491e694)</span></li>
<li>src/main/java/org/kde/kdeconnect/Plugins/MprisPlugin/MprisActivity.java <span style="color: grey">(b219e07)</span></li>
<li>src/main/java/org/kde/kdeconnect/Plugins/MprisPlugin/MprisPlugin.java <span style="color: grey">(3884392)</span></li>
<li>src/main/java/org/kde/kdeconnect/Plugins/NotificationsPlugin/NotificationsPlugin.java <span style="color: grey">(adc4825)</span></li>
<li>src/main/java/org/kde/kdeconnect/Plugins/PingPlugin/PingPlugin.java <span style="color: grey">(51d2028)</span></li>
<li>src/main/java/org/kde/kdeconnect/Plugins/Plugin.java <span style="color: grey">(a91016a)</span></li>
<li>src/main/java/org/kde/kdeconnect/Plugins/PluginFactory.java <span style="color: grey">(8d046cc)</span></li>
<li>src/main/java/org/kde/kdeconnect/Plugins/SftpPlugin/SftpPlugin.java <span style="color: grey">(eee7bf9)</span></li>
<li>src/main/java/org/kde/kdeconnect/Plugins/SharePlugin/SharePlugin.java <span style="color: grey">(b0c28cb)</span></li>
<li>src/main/java/org/kde/kdeconnect/Plugins/TelephonyPlugin/TelephonyPlugin.java <span style="color: grey">(d26409a)</span></li>
<li>src/main/java/org/kde/kdeconnect/UserInterface/PluginSettingsActivity.java <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/main/java/org/kde/kdeconnect/UserInterface/SettingsActivity.java <span style="color: grey">(e1599c5)</span></li>
<li>src/main/res/values/arrays.xml <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/main/res/values/strings.xml <span style="color: grey">(bec4a22)</span></li>
<li>src/main/res/xml/plugin_mpris_preferences.xml <span style="color: grey">(PRE-CREATION)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/120005/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>