<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/116698/">https://git.reviewboard.kde.org/r/116698/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for kdeconnect.</div>
<div>By Mariusz Fik.</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kdeconnect-android
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Fix crash when user tries to unload plugin, which is not supported by platform.
Signed-off-by: Mariusz Fik <fisiu@opensuse.org></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Before this change, I got:
03-10 13:14:12.772 1320-1320/org.kde.kdeconnect_tp E/AndroidRuntime? FATAL EXCEPTION: main
java.lang.NoClassDefFoundError: org.kde.kdeconnect.Plugins.NotificationsPlugin.NotificationReceiver
at org.kde.kdeconnect.Plugins.NotificationsPlugin.NotificationsPlugin.onDestroy(NotificationsPlugin.java:152)
at org.kde.kdeconnect.Device.removePlugin(Device.java:591)
at org.kde.kdeconnect.Device.setPluginEnabled(Device.java:611)
at org.kde.kdeconnect.UserInterface.SettingsActivity$1$1.onItemClick(SettingsActivity.java:56)
After fix, user can toggle notification plugin in settings, without a crash.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/main/java/org/kde/kdeconnect/Plugins/NotificationsPlugin/NotificationsPlugin.java <span style="color: grey">(fa641d88a95ec967f79f1266333c74be0a74db5a)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/116698/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>