D15788: [cli] Allow sharing files and URLs together

Aleix Pol Gonzalez noreply at phabricator.kde.org
Fri Sep 28 02:12:52 BST 2018


apol added inline comments.

INLINE COMMENTS

> nicolasfella wrote in kdeconnect-cli.cpp:156
> But that would interpret google.com as a file, which is not what I would expect. If myfile.odt exists and is interpreted as http://myfile.odt that would be a bug in Qt. If myfile.odt doesn't exist it doesn't make sense sharing it, does it?

Maybe, but the fact that Qt has bugs doesn't make our life easier. Or leave it like that and we can test later.

REPOSITORY
  R224 KDE Connect

BRANCH
  sharemore

REVISION DETAIL
  https://phabricator.kde.org/D15788

To: nicolasfella, #kde_connect, apol
Cc: apol, kdeconnect, wistak, dvalencia, rmenezes, julioc, Leptopoda, timothyc, jdvr, yannux, Danial0_0, johnq, Pitel, adeen-s, SemperPeritus, ndavis, daniel.z.tg, jeanv, seebauer, bugzy, MayeulC, menasshock, tctara
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdeconnect/attachments/20180928/10558f65/attachment.html>


More information about the KDEConnect mailing list